Prepared by: | goetz on Mon May 9 14:03:09 CEST 2016 |
---|---|
Workspace: | /net/usr.work/d045726/oJ/8140594-covCo-hs-comp/hotspot |
Compare against: | http://hg.openjdk.java.net/jdk9/hs-comp/hotspot |
Compare against version: | 11178 |
Summary of changes: | 81 lines changed: 25 ins; 4 del; 52 mod; 49117 unchg |
Changeset: | hotspot.changeset |
Author comments: |
os_linux.cpp
- Buffer not null terminated
- size of pointer passed to jio_snprintf()
os_linux_x86.cpp
- wrong size passed, scaled automatically by C compiler.
dfa.cpp/formssel./cpp
- no real issues as this is a tool, but nevertheless...
c1_Instruction.hpp
- uninitialized field.
c1_LinearScan.cpp
- Access with negative index if called with any_reg
- Coverity doesn't grok that two calls to base_counter(i) result in same value.
ciMethodBlocks.cpp
- Out of bounds access
classFileParser.cpp
- Don't access array at BAD_ALLOCATION_TYPE, oob.
- CHECK macro results in two statements, second is not in if body.
classLoader.cpp
- jio_snprintf does null termination. But it might return -1 if truncated,
in this case array access at -1.
systemDictionary.cpp
- avoid %s in message text.
compileBroker.cpp
_last_method_compiled is an array, not a pointer.
compileLog.cpp
- buffer not null terminated
disassembler.cpp
- lib_offset might be -1.
logTagSet.cpp
- possible buffer overrun
constantPool.cpp
- flagts not initialized
generateOopMap.cpp
- Remaining fields not initialized.
block.cpp
- assertion assigns instead of comparing.
callnode.cpp
_bci not initialized.
graphKit.cpp
- assertion assings instead of comparing
matcher.cpp
- find_receiver might return any_reg
relocator.cpp
- delta might be -4 ... assert returns.
|
Legend: |
Modified file Deleted file New file |
Cdiffs
Udiffs
Wdiffs
Sdiffs
Frames
Old
New
-----
Raw
src/os/linux/vm/os_linux.cpp
rev 11179 : 8140594: Various minor code improvements (compiler) Reviewed-by: thartmann14 lines changed: 1 ins; 0 del; 13 mod; 6290 unchg
Cdiffs
Udiffs
Wdiffs
Sdiffs
Frames
Old
New
-----
Raw
src/os_cpu/linux_x86/vm/os_linux_x86.cpp
rev 11179 : 8140594: Various minor code improvements (compiler) Reviewed-by: thartmann1 line changed: 0 ins; 0 del; 1 mod; 944 unchg
Cdiffs
Udiffs
Wdiffs
Sdiffs
Frames
Old
New
-----
Raw
src/share/vm/adlc/formssel.cpp
rev 11179 : 8140594: Various minor code improvements (compiler) Reviewed-by: thartmann7 lines changed: 1 ins; 0 del; 6 mod; 4269 unchg
Cdiffs
Udiffs
Wdiffs
Sdiffs
Frames
Old
New
-----
Raw
src/share/vm/c1/c1_LinearScan.cpp
rev 11179 : 8140594: Various minor code improvements (compiler) Reviewed-by: thartmann5 lines changed: 2 ins; 0 del; 3 mod; 6775 unchg
Cdiffs
Udiffs
Wdiffs
Sdiffs
Frames
Old
New
-----
Raw
src/share/vm/ci/ciMethodBlocks.cpp
rev 11179 : 8140594: Various minor code improvements (compiler) Reviewed-by: thartmann1 line changed: 0 ins; 0 del; 1 mod; 401 unchg
Cdiffs
Udiffs
Wdiffs
Sdiffs
Frames
Old
New
-----
Raw
src/share/vm/classfile/classFileParser.cpp
rev 11179 : 8140594: Various minor code improvements (compiler) Reviewed-by: thartmann7 lines changed: 3 ins; 0 del; 4 mod; 5899 unchg
Cdiffs
Udiffs
Wdiffs
Sdiffs
Frames
Old
New
-----
Raw
src/share/vm/classfile/classLoader.cpp
rev 11179 : 8140594: Various minor code improvements (compiler) Reviewed-by: thartmann5 lines changed: 0 ins; 3 del; 2 mod; 1744 unchg
Cdiffs
Udiffs
Wdiffs
Sdiffs
Frames
Old
New
-----
Raw
src/share/vm/classfile/systemDictionary.cpp
rev 11179 : 8140594: Various minor code improvements (compiler) Reviewed-by: thartmann3 lines changed: 0 ins; 0 del; 3 mod; 2912 unchg
Cdiffs
Udiffs
Wdiffs
Sdiffs
Frames
Old
New
-----
Raw
src/share/vm/compiler/compileBroker.cpp
rev 11179 : 8140594: Various minor code improvements (compiler) Reviewed-by: thartmann4 lines changed: 0 ins; 1 del; 3 mod; 2404 unchg
Cdiffs
Udiffs
Wdiffs
Sdiffs
Frames
Old
New
-----
Raw
src/share/vm/compiler/compileLog.cpp
rev 11179 : 8140594: Various minor code improvements (compiler) Reviewed-by: thartmann2 lines changed: 1 ins; 0 del; 1 mod; 344 unchg
Cdiffs
Udiffs
Wdiffs
Sdiffs
Frames
Old
New
-----
Raw
src/share/vm/compiler/disassembler.cpp
rev 11179 : 8140594: Various minor code improvements (compiler) Reviewed-by: thartmann3 lines changed: 0 ins; 0 del; 3 mod; 592 unchg
Cdiffs
Udiffs
Wdiffs
Sdiffs
Frames
Old
New
-----
Raw
src/share/vm/logging/logTagSet.cpp
rev 11179 : 8140594: Various minor code improvements (compiler) Reviewed-by: thartmann8 lines changed: 6 ins; 0 del; 2 mod; 119 unchg
Cdiffs
Udiffs
Wdiffs
Sdiffs
Frames
Old
New
-----
Raw
src/share/vm/oops/constantPool.cpp
rev 11179 : 8140594: Various minor code improvements (compiler) Reviewed-by: thartmann2 lines changed: 1 ins; 0 del; 1 mod; 2083 unchg
Cdiffs
Udiffs
Wdiffs
Sdiffs
Frames
Old
New
-----
Raw
src/share/vm/oops/generateOopMap.cpp
rev 11179 : 8140594: Various minor code improvements (compiler) Reviewed-by: thartmann8 lines changed: 6 ins; 0 del; 2 mod; 2565 unchg
Cdiffs
Udiffs
Wdiffs
Sdiffs
Frames
Old
New
-----
Raw
src/share/vm/opto/block.cpp
rev 11179 : 8140594: Various minor code improvements (compiler) Reviewed-by: thartmann1 line changed: 0 ins; 0 del; 1 mod; 1777 unchg
Cdiffs
Udiffs
Wdiffs
Sdiffs
Frames
Old
New
-----
Raw
src/share/vm/opto/callnode.cpp
rev 11179 : 8140594: Various minor code improvements (compiler) Reviewed-by: thartmann1 line changed: 1 ins; 0 del; 0 mod; 2040 unchg
Cdiffs
Udiffs
Wdiffs
Sdiffs
Frames
Old
New
-----
Raw
src/share/vm/opto/graphKit.cpp
rev 11179 : 8140594: Various minor code improvements (compiler) Reviewed-by: thartmann1 line changed: 0 ins; 0 del; 1 mod; 4492 unchg
Cdiffs
Udiffs
Wdiffs
Sdiffs
Frames
Old
New
-----
Raw
src/share/vm/opto/matcher.cpp
rev 11179 : 8140594: Various minor code improvements (compiler) Reviewed-by: thartmann6 lines changed: 3 ins; 0 del; 3 mod; 2691 unchg
Cdiffs
Udiffs
Wdiffs
Sdiffs
Frames
Old
New
-----
Raw
src/share/vm/runtime/relocator.cpp
rev 11179 : 8140594: Various minor code improvements (compiler) Reviewed-by: thartmann2 lines changed: 0 ins; 0 del; 2 mod; 776 unchg
This code review page was prepared using /sapmnt/home/d045726/bin/webrev.ksh (vers 25.12-hg+openjdk.java.net).