< prev index next >
src/hotspot/share/oops/klassVtable.cpp
Print this page
rev 51756 : 8205611: Improve the wording of LinkageErrors to include module and class loader information
Summary: Clean up the wording of loader constraint violations to include the module and class loader information.
Reviewed-by: coleenp, goetz, hseigel
*** 504,531 ****
Symbol* failed_type_symbol =
SystemDictionary::check_signature_loaders(signature, target_loader,
super_loader, true,
CHECK_(false));
if (failed_type_symbol != NULL) {
! const char* msg = "loader constraint violation for class %s: when selecting "
"overriding method %s the class loader %s of the "
"selected method's type %s, and the class loader %s for its super "
! "type %s have different Class objects for the type %s used in the signature";
! const char* curr_class = klass->external_name();
! const char* method = target_method()->name_and_sig_as_C_string();
! const char* loader1 = java_lang_ClassLoader::describe_external(target_loader());
! const char* sel_class = target_klass->external_name();
! const char* loader2 = java_lang_ClassLoader::describe_external(super_loader());
! const char* super_class = super_klass->external_name();
! const char* failed_type_name = failed_type_symbol->as_klass_external_name();
! size_t buflen = strlen(msg) + strlen(curr_class) + strlen(method) +
! strlen(loader1) + strlen(sel_class) + strlen(loader2) +
! strlen(super_class) + strlen(failed_type_name);
! char* buf = NEW_RESOURCE_ARRAY_IN_THREAD(THREAD, char, buflen);
! jio_snprintf(buf, buflen, msg, curr_class, method, loader1, sel_class, loader2,
! super_class, failed_type_name);
! THROW_MSG_(vmSymbols::java_lang_LinkageError(), buf, false);
}
}
}
put_method_at(target_method(), i);
--- 504,528 ----
Symbol* failed_type_symbol =
SystemDictionary::check_signature_loaders(signature, target_loader,
super_loader, true,
CHECK_(false));
if (failed_type_symbol != NULL) {
! stringStream ss;
! ss.print("loader constraint violation for class %s: when selecting "
"overriding method %s the class loader %s of the "
"selected method's type %s, and the class loader %s for its super "
! "type %s have different Class objects for the type %s used in the signature (%s; %s)",
! klass->external_name(),
! target_method()->name_and_sig_as_C_string(),
! target_klass->class_loader_data()->loader_name_and_id(),
! target_klass->external_name(),
! super_klass->class_loader_data()->loader_name_and_id(),
! super_klass->external_name(),
! failed_type_symbol->as_klass_external_name(),
! target_klass->class_in_module_of_loader(false, true),
! super_klass->class_in_module_of_loader(false, true));
! THROW_MSG_(vmSymbols::java_lang_LinkageError(), ss.as_string(), false);
}
}
}
put_method_at(target_method(), i);
*** 1239,1267 ****
SystemDictionary::check_signature_loaders(m->signature(),
method_holder_loader,
interface_loader,
true, CHECK);
if (failed_type_symbol != NULL) {
! const char* msg = "loader constraint violation in interface itable"
" initialization for class %s: when selecting method %s the"
" class loader %s for super interface %s, and the class"
" loader %s of the selected method's type, %s have"
! " different Class objects for the type %s used in the signature";
! const char* current = _klass->external_name();
! const char* sig = m->name_and_sig_as_C_string();
! const char* loader1 = java_lang_ClassLoader::describe_external(interface_loader());
! const char* iface = InstanceKlass::cast(interf)->external_name();
! const char* loader2 = java_lang_ClassLoader::describe_external(method_holder_loader());
! const char* mclass = target()->method_holder()->external_name();
! const char* failed_type_name = failed_type_symbol->as_klass_external_name();
! size_t buflen = strlen(msg) + strlen(current) + strlen(sig) +
! strlen(loader1) + strlen(iface) + strlen(loader2) + strlen(mclass) +
! strlen(failed_type_name);
! char* buf = NEW_RESOURCE_ARRAY_IN_THREAD(THREAD, char, buflen);
! jio_snprintf(buf, buflen, msg, current, sig, loader1, iface,
! loader2, mclass, failed_type_name);
! THROW_MSG(vmSymbols::java_lang_LinkageError(), buf);
}
}
}
// ime may have moved during GC so recalculate address
--- 1236,1261 ----
SystemDictionary::check_signature_loaders(m->signature(),
method_holder_loader,
interface_loader,
true, CHECK);
if (failed_type_symbol != NULL) {
! stringStream ss;
! ss.print("loader constraint violation in interface itable"
" initialization for class %s: when selecting method %s the"
" class loader %s for super interface %s, and the class"
" loader %s of the selected method's type, %s have"
! " different Class objects for the type %s used in the signature (%s; %s)",
! _klass->external_name(),
! m->name_and_sig_as_C_string(),
! interf->class_loader_data()->loader_name_and_id(),
! interf->external_name(),
! target()->method_holder()->class_loader_data()->loader_name_and_id(),
! target()->method_holder()->external_name(),
! failed_type_symbol->as_klass_external_name(),
! interf->class_in_module_of_loader(false, true),
! target()->method_holder()->class_in_module_of_loader(false, true));
! THROW_MSG(vmSymbols::java_lang_LinkageError(), ss.as_string());
}
}
}
// ime may have moved during GC so recalculate address
< prev index next >