Code Review for 8218628-exMsg-NPE-jdk

Prepared by:goetz on Fri Mar 15 09:54:29 CET 2019
Workspace:
Compare against: http://hg.openjdk.java.net/jdk/jdk
Compare against version:54123
Summary of changes: 3295 lines changed: 3290 ins; 1 del; 4 mod; 13566 unchg
Changeset: 8218628-exMsg-NPE-jdk.changeset
Author comments:

This webrev changes the text of the messages considerably. The following files show example output.

Messages if classfiles contain debug info.
Messages if classfiles contain no debug info.

(The test added by this change currently is modified to output the exception messages, the testing is disabled.)

For completeness incremental patches for the new messages. (There are more changes to the code wrt. to webrev.04, though.)

change_message_assembly.patch
modify_test_to_print_messages.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw make/hotspot/symbols/symbols-unix 

rev 54124 : 8218628: Add detailed message to NullPointerException describing what is null.
2 lines changed: 1 ins; 0 del; 1 mod; 192 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/classfile/javaClasses.cpp 

rev 54124 : 8218628: Add detailed message to NullPointerException describing what is null.
33 lines changed: 32 ins; 0 del; 1 mod; 4384 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/classfile/javaClasses.hpp 

rev 54124 : 8218628: Add detailed message to NullPointerException describing what is null.
2 lines changed: 2 ins; 0 del; 0 mod; 1553 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/classfile/systemDictionary.hpp 

rev 54124 : 8218628: Add detailed message to NullPointerException describing what is null.
1 line changed: 1 ins; 0 del; 0 mod; 705 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/classfile/vmSymbols.hpp 

rev 54124 : 8218628: Add detailed message to NullPointerException describing what is null.
1 line changed: 1 ins; 0 del; 0 mod; 1659 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/include/jvm.h 

rev 54124 : 8218628: Add detailed message to NullPointerException describing what is null.
7 lines changed: 7 ins; 0 del; 0 mod; 1346 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/prims/jvm.cpp 

rev 54124 : 8218628: Add detailed message to NullPointerException describing what is null.
47 lines changed: 46 ins; 1 del; 0 mod; 3655 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/java.base/share/classes/java/lang/NullPointerException.java 

rev 54124 : 8218628: Add detailed message to NullPointerException describing what is null.
26 lines changed: 25 ins; 0 del; 1 mod; 71 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw test/hotspot/jtreg/vmTestbase/jit/t/t104/t104.gold 

rev 54124 : 8218628: Add detailed message to NullPointerException describing what is null.
1 line changed: 0 ins; 0 del; 1 mod; 1 unchg

------ ------ ------ ------ ------ --- New ----- Raw src/hotspot/share/interpreter/bytecodeUtils.cpp 

rev 54124 : 8218628: Add detailed message to NullPointerException describing what is null.
1682 lines changed: 1682 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw src/hotspot/share/interpreter/bytecodeUtils.hpp 

rev 54124 : 8218628: Add detailed message to NullPointerException describing what is null.
298 lines changed: 298 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw src/java.base/share/native/libjava/NullPointerException.c 

rev 54124 : 8218628: Add detailed message to NullPointerException describing what is null.
36 lines changed: 36 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/hotspot/jtreg/runtime/exceptionMsgs/NullPointerException/NullPointerExceptionTest.java 

rev 54124 : 8218628: Add detailed message to NullPointerException describing what is null.
1159 lines changed: 1159 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /usr/work/openjdk/bin/webrev.ksh (vers 25.12-hg+openjdk.java.net).