Code Review for 8221470-exMsg-signature-jdk

Prepared by:goetz on Thu Apr 4 14:10:23 CEST 2019
Workspace:
Compare against: http://hg.openjdk.java.net/jdk/jdk
Compare against version:54420
Summary of changes: 498 lines changed: 337 ins; 28 del; 133 mod; 23507 unchg
Changeset: 8221470-exMsg-signature-jdk.changeset
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/classfile/verifier.cpp

rev 54421 : 8221470: Print methods in exception messages in java-like Syntax.
Reviewed-by: dholmes, mdoerr
3 lines changed: 2 ins; 0 del; 1 mod; 3168 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/interpreter/linkResolver.cpp

rev 54421 : 8221470: Print methods in exception messages in java-like Syntax.
Reviewed-by: dholmes, mdoerr
117 lines changed: 23 ins; 20 del; 74 mod; 1731 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/interpreter/linkResolver.hpp

rev 54421 : 8221470: Print methods in exception messages in java-like Syntax.
Reviewed-by: dholmes, mdoerr
1 line changed: 0 ins; 1 del; 0 mod; 361 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/oops/constantPool.cpp

rev 54421 : 8221470: Print methods in exception messages in java-like Syntax.
Reviewed-by: dholmes, mdoerr
11 lines changed: 3 ins; 0 del; 8 mod; 2562 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/oops/klassVtable.cpp

rev 54421 : 8221470: Print methods in exception messages in java-like Syntax.
Reviewed-by: dholmes, mdoerr
13 lines changed: 5 ins; 4 del; 4 mod; 1613 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/oops/method.cpp

rev 54421 : 8221470: Print methods in exception messages in java-like Syntax.
Reviewed-by: dholmes, mdoerr
21 lines changed: 21 ins; 0 del; 0 mod; 2387 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/oops/method.hpp

rev 54421 : 8221470: Print methods in exception messages in java-like Syntax.
Reviewed-by: dholmes, mdoerr
14 lines changed: 12 ins; 0 del; 2 mod; 1162 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/oops/symbol.cpp

rev 54421 : 8221470: Print methods in exception messages in java-like Syntax.
Reviewed-by: dholmes, mdoerr
60 lines changed: 60 ins; 0 del; 0 mod; 335 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/oops/symbol.hpp

rev 54421 : 8221470: Print methods in exception messages in java-like Syntax.
Reviewed-by: dholmes, mdoerr
9 lines changed: 9 ins; 0 del; 0 mod; 264 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/prims/jni.cpp

rev 54421 : 8221470: Print methods in exception messages in java-like Syntax.
Reviewed-by: dholmes, mdoerr
6 lines changed: 2 ins; 0 del; 4 mod; 4338 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/prims/nativeLookup.cpp

rev 54421 : 8221470: Print methods in exception messages in java-like Syntax.
Reviewed-by: dholmes, mdoerr
5 lines changed: 3 ins; 0 del; 2 mod; 420 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/prims/stackwalk.cpp

rev 54421 : 8221470: Print methods in exception messages in java-like Syntax.
Reviewed-by: dholmes, mdoerr
2 lines changed: 0 ins; 0 del; 2 mod; 489 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/runtime/reflection.cpp

rev 54421 : 8221470: Print methods in exception messages in java-like Syntax.
Reviewed-by: dholmes, mdoerr
15 lines changed: 7 ins; 3 del; 5 mod; 1237 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw test/hotspot/jtreg/runtime/LoaderConstraints/itableLdrConstraint/Test.java

rev 54421 : 8221470: Print methods in exception messages in java-like Syntax.
Reviewed-by: dholmes, mdoerr
7 lines changed: 2 ins; 0 del; 5 mod; 89 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw test/hotspot/jtreg/runtime/LoaderConstraints/vtableLdrConstraint/Test.java

rev 54421 : 8221470: Print methods in exception messages in java-like Syntax.
Reviewed-by: dholmes, mdoerr
2 lines changed: 0 ins; 0 del; 2 mod; 93 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw test/hotspot/jtreg/runtime/Nestmates/membership/TestNestmateMembership.java

rev 54421 : 8221470: Print methods in exception messages in java-like Syntax.
Reviewed-by: dholmes, mdoerr
6 lines changed: 0 ins; 0 del; 6 mod; 1769 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw test/hotspot/jtreg/runtime/Nestmates/privateConstructors/TestConstructorHierarchy.java

rev 54421 : 8221470: Print methods in exception messages in java-like Syntax.
Reviewed-by: dholmes, mdoerr
3 lines changed: 0 ins; 0 del; 3 mod; 93 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw test/hotspot/jtreg/runtime/exceptionMsgs/AbstractMethodError/AbstractMethodErrorTest.java

rev 54421 : 8221470: Print methods in exception messages in java-like Syntax.
Reviewed-by: dholmes, mdoerr
11 lines changed: 0 ins; 0 del; 11 mod; 875 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw test/hotspot/jtreg/runtime/exceptionMsgs/IllegalAccessError/IllegalAccessErrorTest.java

rev 54421 : 8221470: Print methods in exception messages in java-like Syntax.
Reviewed-by: dholmes, mdoerr
2 lines changed: 0 ins; 0 del; 2 mod; 403 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw test/hotspot/jtreg/runtime/modules/AccessCheck/ExpQualToM1PrivateMethodIAE.java

rev 54421 : 8221470: Print methods in exception messages in java-like Syntax.
Reviewed-by: dholmes, mdoerr
2 lines changed: 0 ins; 0 del; 2 mod; 118 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/hotspot/jtreg/runtime/exceptionMsgs/methodPrinting/TeMe3_C.jasm

rev 54421 : 8221470: Print methods in exception messages in java-like Syntax.
Reviewed-by: dholmes, mdoerr
37 lines changed: 37 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/hotspot/jtreg/runtime/exceptionMsgs/methodPrinting/TestPrintingMethods.java

rev 54421 : 8221470: Print methods in exception messages in java-like Syntax.
Reviewed-by: dholmes, mdoerr
151 lines changed: 151 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /usr/work/openjdk/bin/webrev.ksh (vers 25.12-hg+openjdk.java.net).