Code Review for hs_darn

Prepared by:gromero on Tue Jun 19 19:31:38 CDT 2018
Workspace:/home/gromero/hg/jdk/hs_darn
Compare against: http://hg.openjdk.java.net/jdk/jdk
Compare against version:50667
Summary of changes: 795 lines changed: 791 ins; 0 del; 4 mod; 49323 unchg
Changeset: hs_darn.changeset
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/ppc/assembler_ppc.hpp

rev 50668 : PPC64: Add support for HW random number generator

Add support to use a hardware random number generator through new 'darn'
instruction introduced with POWER9 processor. That change introduces a new
JCA provider (called HWTRNG) with the proper methods to be intrinsified and
that are used, in the end, by generateSeed() and nextBytes() methods in
SecureRandom class when the HWTPRNG provider is selected. It also paves the
way to use a HW TRNG for other architectures that support it.
6 lines changed: 6 ins; 0 del; 0 mod; 2377 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/ppc/assembler_ppc.inline.hpp

rev 50668 : PPC64: Add support for HW random number generator

Add support to use a hardware random number generator through new 'darn'
instruction introduced with POWER9 processor. That change introduces a new
JCA provider (called HWTRNG) with the proper methods to be intrinsified and
that are used, in the end, by generateSeed() and nextBytes() methods in
SecureRandom class when the HWTPRNG provider is selected. It also paves the
way to use a HW TRNG for other architectures that support it.
3 lines changed: 3 ins; 0 del; 0 mod; 1093 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/ppc/c1_LIRAssembler_ppc.cpp

rev 50668 : PPC64: Add support for HW random number generator

Add support to use a hardware random number generator through new 'darn'
instruction introduced with POWER9 processor. That change introduces a new
JCA provider (called HWTRNG) with the proper methods to be intrinsified and
that are used, in the end, by generateSeed() and nextBytes() methods in
SecureRandom class when the HWTPRNG provider is selected. It also paves the
way to use a HW TRNG for other architectures that support it.
3 lines changed: 3 ins; 0 del; 0 mod; 3215 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/ppc/c1_LIRGenerator_ppc.cpp

rev 50668 : PPC64: Add support for HW random number generator

Add support to use a hardware random number generator through new 'darn'
instruction introduced with POWER9 processor. That change introduces a new
JCA provider (called HWTRNG) with the proper methods to be intrinsified and
that are used, in the end, by generateSeed() and nextBytes() methods in
SecureRandom class when the HWTPRNG provider is selected. It also paves the
way to use a HW TRNG for other architectures that support it.
5 lines changed: 5 ins; 0 del; 0 mod; 1382 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/ppc/globals_ppc.hpp

rev 50668 : PPC64: Add support for HW random number generator

Add support to use a hardware random number generator through new 'darn'
instruction introduced with POWER9 processor. That change introduces a new
JCA provider (called HWTRNG) with the proper methods to be intrinsified and
that are used, in the end, by generateSeed() and nextBytes() methods in
SecureRandom class when the HWTPRNG provider is selected. It also paves the
way to use a HW TRNG for other architectures that support it.
3 lines changed: 3 ins; 0 del; 0 mod; 209 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/ppc/ppc.ad

rev 50668 : PPC64: Add support for HW random number generator

Add support to use a hardware random number generator through new 'darn'
instruction introduced with POWER9 processor. That change introduces a new
JCA provider (called HWTRNG) with the proper methods to be intrinsified and
that are used, in the end, by generateSeed() and nextBytes() methods in
SecureRandom class when the HWTPRNG provider is selected. It also paves the
way to use a HW TRNG for other architectures that support it.
9 lines changed: 9 ins; 0 del; 0 mod; 14693 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/ppc/templateInterpreterGenerator_ppc.cpp

rev 50668 : PPC64: Add support for HW random number generator

Add support to use a hardware random number generator through new 'darn'
instruction introduced with POWER9 processor. That change introduces a new
JCA provider (called HWTRNG) with the proper methods to be intrinsified and
that are used, in the end, by generateSeed() and nextBytes() methods in
SecureRandom class when the HWTPRNG provider is selected. It also paves the
way to use a HW TRNG for other architectures that support it.
23 lines changed: 23 ins; 0 del; 0 mod; 2444 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/ppc/vm_version_ppc.cpp

rev 50668 : PPC64: Add support for HW random number generator

Add support to use a hardware random number generator through new 'darn'
instruction introduced with POWER9 processor. That change introduces a new
JCA provider (called HWTRNG) with the proper methods to be intrinsified and
that are used, in the end, by generateSeed() and nextBytes() methods in
SecureRandom class when the HWTPRNG provider is selected. It also paves the
way to use a HW TRNG for other architectures that support it.
5 lines changed: 3 ins; 0 del; 2 mod; 828 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/ppc/vm_version_ppc.hpp

rev 50668 : PPC64: Add support for HW random number generator

Add support to use a hardware random number generator through new 'darn'
instruction introduced with POWER9 processor. That change introduces a new
JCA provider (called HWTRNG) with the proper methods to be intrinsified and
that are used, in the end, by generateSeed() and nextBytes() methods in
SecureRandom class when the HWTPRNG provider is selected. It also paves the
way to use a HW TRNG for other architectures that support it.
3 lines changed: 3 ins; 0 del; 0 mod; 123 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/c1/c1_Compiler.cpp

rev 50668 : PPC64: Add support for HW random number generator

Add support to use a hardware random number generator through new 'darn'
instruction introduced with POWER9 processor. That change introduces a new
JCA provider (called HWTRNG) with the proper methods to be intrinsified and
that are used, in the end, by generateSeed() and nextBytes() methods in
SecureRandom class when the HWTPRNG provider is selected. It also paves the
way to use a HW TRNG for other architectures that support it.
1 line changed: 1 ins; 0 del; 0 mod; 258 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/c1/c1_LIR.cpp

rev 50668 : PPC64: Add support for HW random number generator

Add support to use a hardware random number generator through new 'darn'
instruction introduced with POWER9 processor. That change introduces a new
JCA provider (called HWTRNG) with the proper methods to be intrinsified and
that are used, in the end, by generateSeed() and nextBytes() methods in
SecureRandom class when the HWTPRNG provider is selected. It also paves the
way to use a HW TRNG for other architectures that support it.
2 lines changed: 2 ins; 0 del; 0 mod; 2064 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/c1/c1_LIR.hpp

rev 50668 : PPC64: Add support for HW random number generator

Add support to use a hardware random number generator through new 'darn'
instruction introduced with POWER9 processor. That change introduces a new
JCA provider (called HWTRNG) with the proper methods to be intrinsified and
that are used, in the end, by generateSeed() and nextBytes() methods in
SecureRandom class when the HWTPRNG provider is selected. It also paves the
way to use a HW TRNG for other architectures that support it.
2 lines changed: 2 ins; 0 del; 0 mod; 2470 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/c1/c1_LIRAssembler.cpp

rev 50668 : PPC64: Add support for HW random number generator

Add support to use a hardware random number generator through new 'darn'
instruction introduced with POWER9 processor. That change introduces a new
JCA provider (called HWTRNG) with the proper methods to be intrinsified and
that are used, in the end, by generateSeed() and nextBytes() methods in
SecureRandom class when the HWTPRNG provider is selected. It also paves the
way to use a HW TRNG for other architectures that support it.
4 lines changed: 4 ins; 0 del; 0 mod; 863 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/c1/c1_LIRAssembler.hpp

rev 50668 : PPC64: Add support for HW random number generator

Add support to use a hardware random number generator through new 'darn'
instruction introduced with POWER9 processor. That change introduces a new
JCA provider (called HWTRNG) with the proper methods to be intrinsified and
that are used, in the end, by generateSeed() and nextBytes() methods in
SecureRandom class when the HWTPRNG provider is selected. It also paves the
way to use a HW TRNG for other architectures that support it.
1 line changed: 1 ins; 0 del; 0 mod; 282 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/c1/c1_LIRGenerator.cpp

rev 50668 : PPC64: Add support for HW random number generator

Add support to use a hardware random number generator through new 'darn'
instruction introduced with POWER9 processor. That change introduces a new
JCA provider (called HWTRNG) with the proper methods to be intrinsified and
that are used, in the end, by generateSeed() and nextBytes() methods in
SecureRandom class when the HWTPRNG provider is selected. It also paves the
way to use a HW TRNG for other architectures that support it.
2 lines changed: 2 ins; 0 del; 0 mod; 3635 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/c1/c1_LIRGenerator.hpp

rev 50668 : PPC64: Add support for HW random number generator

Add support to use a hardware random number generator through new 'darn'
instruction introduced with POWER9 processor. That change introduces a new
JCA provider (called HWTRNG) with the proper methods to be intrinsified and
that are used, in the end, by generateSeed() and nextBytes() methods in
SecureRandom class when the HWTPRNG provider is selected. It also paves the
way to use a HW TRNG for other architectures that support it.
1 line changed: 1 ins; 0 del; 0 mod; 684 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/classfile/vmSymbols.cpp

rev 50668 : PPC64: Add support for HW random number generator

Add support to use a hardware random number generator through new 'darn'
instruction introduced with POWER9 processor. That change introduces a new
JCA provider (called HWTRNG) with the proper methods to be intrinsified and
that are used, in the end, by generateSeed() and nextBytes() methods in
SecureRandom class when the HWTPRNG provider is selected. It also paves the
way to use a HW TRNG for other architectures that support it.
2 lines changed: 2 ins; 0 del; 0 mod; 1055 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/classfile/vmSymbols.hpp

rev 50668 : PPC64: Add support for HW random number generator

Add support to use a hardware random number generator through new 'darn'
instruction introduced with POWER9 processor. That change introduces a new
JCA provider (called HWTRNG) with the proper methods to be intrinsified and
that are used, in the end, by generateSeed() and nextBytes() methods in
SecureRandom class when the HWTPRNG provider is selected. It also paves the
way to use a HW TRNG for other architectures that support it.
6 lines changed: 5 ins; 0 del; 1 mod; 1632 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/interpreter/abstractInterpreter.cpp

rev 50668 : PPC64: Add support for HW random number generator

Add support to use a hardware random number generator through new 'darn'
instruction introduced with POWER9 processor. That change introduces a new
JCA provider (called HWTRNG) with the proper methods to be intrinsified and
that are used, in the end, by generateSeed() and nextBytes() methods in
SecureRandom class when the HWTPRNG provider is selected. It also paves the
way to use a HW TRNG for other architectures that support it.
2 lines changed: 2 ins; 0 del; 0 mod; 447 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/interpreter/abstractInterpreter.hpp

rev 50668 : PPC64: Add support for HW random number generator

Add support to use a hardware random number generator through new 'darn'
instruction introduced with POWER9 processor. That change introduces a new
JCA provider (called HWTRNG) with the proper methods to be intrinsified and
that are used, in the end, by generateSeed() and nextBytes() methods in
SecureRandom class when the HWTPRNG provider is selected. It also paves the
way to use a HW TRNG for other architectures that support it.
1 line changed: 1 ins; 0 del; 0 mod; 336 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/interpreter/templateInterpreterGenerator.cpp

rev 50668 : PPC64: Add support for HW random number generator

Add support to use a hardware random number generator through new 'darn'
instruction introduced with POWER9 processor. That change introduces a new
JCA provider (called HWTRNG) with the proper methods to be intrinsified and
that are used, in the end, by generateSeed() and nextBytes() methods in
SecureRandom class when the HWTPRNG provider is selected. It also paves the
way to use a HW TRNG for other architectures that support it.
4 lines changed: 4 ins; 0 del; 0 mod; 487 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/interpreter/templateInterpreterGenerator.hpp

rev 50668 : PPC64: Add support for HW random number generator

Add support to use a hardware random number generator through new 'darn'
instruction introduced with POWER9 processor. That change introduces a new
JCA provider (called HWTRNG) with the proper methods to be intrinsified and
that are used, in the end, by generateSeed() and nextBytes() methods in
SecureRandom class when the HWTPRNG provider is selected. It also paves the
way to use a HW TRNG for other architectures that support it.
3 lines changed: 3 ins; 0 del; 0 mod; 132 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/opto/c2compiler.cpp

rev 50668 : PPC64: Add support for HW random number generator

Add support to use a hardware random number generator through new 'darn'
instruction introduced with POWER9 processor. That change introduces a new
JCA provider (called HWTRNG) with the proper methods to be intrinsified and
that are used, in the end, by generateSeed() and nextBytes() methods in
SecureRandom class when the HWTPRNG provider is selected. It also paves the
way to use a HW TRNG for other architectures that support it.
3 lines changed: 3 ins; 0 del; 0 mod; 609 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/opto/classes.hpp

rev 50668 : PPC64: Add support for HW random number generator

Add support to use a hardware random number generator through new 'darn'
instruction introduced with POWER9 processor. That change introduces a new
JCA provider (called HWTRNG) with the proper methods to be intrinsified and
that are used, in the end, by generateSeed() and nextBytes() methods in
SecureRandom class when the HWTPRNG provider is selected. It also paves the
way to use a HW TRNG for other architectures that support it.
1 line changed: 1 ins; 0 del; 0 mod; 381 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/opto/intrinsicnode.hpp

rev 50668 : PPC64: Add support for HW random number generator

Add support to use a hardware random number generator through new 'darn'
instruction introduced with POWER9 processor. That change introduces a new
JCA provider (called HWTRNG) with the proper methods to be intrinsified and
that are used, in the end, by generateSeed() and nextBytes() methods in
SecureRandom class when the HWTPRNG provider is selected. It also paves the
way to use a HW TRNG for other architectures that support it.
10 lines changed: 10 ins; 0 del; 0 mod; 183 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/opto/library_call.cpp

rev 50668 : PPC64: Add support for HW random number generator

Add support to use a hardware random number generator through new 'darn'
instruction introduced with POWER9 processor. That change introduces a new
JCA provider (called HWTRNG) with the proper methods to be intrinsified and
that are used, in the end, by generateSeed() and nextBytes() methods in
SecureRandom class when the HWTPRNG provider is selected. It also paves the
way to use a HW TRNG for other architectures that support it.
17 lines changed: 17 ins; 0 del; 0 mod; 6451 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/java.base/share/classes/sun/security/provider/SunEntries.java

rev 50668 : PPC64: Add support for HW random number generator

Add support to use a hardware random number generator through new 'darn'
instruction introduced with POWER9 processor. That change introduces a new
JCA provider (called HWTRNG) with the proper methods to be intrinsified and
that are used, in the end, by generateSeed() and nextBytes() methods in
SecureRandom class when the HWTPRNG provider is selected. It also paves the
way to use a HW TRNG for other architectures that support it.
4 lines changed: 4 ins; 0 del; 0 mod; 421 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/java.base/unix/classes/sun/security/provider/NativePRNG.java

rev 50668 : PPC64: Add support for HW random number generator

Add support to use a hardware random number generator through new 'darn'
instruction introduced with POWER9 processor. That change introduces a new
JCA provider (called HWTRNG) with the proper methods to be intrinsified and
that are used, in the end, by generateSeed() and nextBytes() methods in
SecureRandom class when the HWTPRNG provider is selected. It also paves the
way to use a HW TRNG for other architectures that support it.
1 line changed: 0 ins; 0 del; 1 mod; 569 unchg

------ ------ ------ ------ ------ --- New ----- Raw src/java.base/unix/classes/sun/security/provider/HWTRNG.java

rev 50668 : PPC64: Add support for HW random number generator

Add support to use a hardware random number generator through new 'darn'
instruction introduced with POWER9 processor. That change introduces a new
JCA provider (called HWTRNG) with the proper methods to be intrinsified and
that are used, in the end, by generateSeed() and nextBytes() methods in
SecureRandom class when the HWTPRNG provider is selected. It also paves the
way to use a HW TRNG for other architectures that support it.
668 lines changed: 668 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using ./webrev.ksh (vers 25.17-hg+openjdk.java.net).