--- old/src/share/vm/runtime/commandLineFlagConstraintsGC.cpp 2015-06-16 15:48:02.000000000 -0500 +++ new/src/share/vm/runtime/commandLineFlagConstraintsGC.cpp 2015-06-16 15:48:01.000000000 -0500 @@ -26,8 +26,6 @@ #include "runtime/arguments.hpp" #include "runtime/commandLineFlagConstraintsGC.hpp" #include "runtime/globals.hpp" -#include "runtime/java.hpp" -#include "runtime/os.hpp" #include "utilities/defaultStream.hpp" #if INCLUDE_ALL_GCS @@ -41,7 +39,7 @@ #endif // COMPILER2 Flag::Error MinHeapFreeRatioConstraintFunc(bool verbose, uintx* value) { - if ((CommandLineFlags::finishedInitializing() == true) && (*value > MaxHeapFreeRatio)) { + if ((CommandLineFlags::finishedInitializing()) && (*value > MaxHeapFreeRatio)) { if (verbose == true) { jio_fprintf(defaultStream::error_stream(), "MinHeapFreeRatio (" UINTX_FORMAT ") must be less than or " @@ -55,7 +53,7 @@ } Flag::Error MaxHeapFreeRatioConstraintFunc(bool verbose, uintx* value) { - if ((CommandLineFlags::finishedInitializing() == true) && (*value < MinHeapFreeRatio)) { + if ((CommandLineFlags::finishedInitializing()) && (*value < MinHeapFreeRatio)) { if (verbose == true) { jio_fprintf(defaultStream::error_stream(), "MaxHeapFreeRatio (" UINTX_FORMAT ") must be greater than or " @@ -69,7 +67,7 @@ } Flag::Error MinMetaspaceFreeRatioConstraintFunc(bool verbose, uintx* value) { - if ((CommandLineFlags::finishedInitializing() == true) && (*value > MaxMetaspaceFreeRatio)) { + if ((CommandLineFlags::finishedInitializing()) && (*value > MaxMetaspaceFreeRatio)) { if (verbose == true) { jio_fprintf(defaultStream::error_stream(), "MinMetaspaceFreeRatio (" UINTX_FORMAT ") must be less than or " @@ -83,7 +81,7 @@ } Flag::Error MaxMetaspaceFreeRatioConstraintFunc(bool verbose, uintx* value) { - if ((CommandLineFlags::finishedInitializing() == true) && (*value < MinMetaspaceFreeRatio)) { + if ((CommandLineFlags::finishedInitializing()) && (*value < MinMetaspaceFreeRatio)) { if (verbose == true) { jio_fprintf(defaultStream::error_stream(), "MaxMetaspaceFreeRatio (" UINTX_FORMAT ") must be greater than or " @@ -108,7 +106,7 @@ Flag::Error InitialTenuringThresholdConstraintFunc(bool verbose, uintx* value) { UseConcMarkSweepGCWorkaroundIfNeeded(*value, MaxTenuringThreshold); - if ((CommandLineFlags::finishedInitializing() == true) && (*value > MaxTenuringThreshold)) { + if ((CommandLineFlags::finishedInitializing()) && (*value > MaxTenuringThreshold)) { if (verbose == true) { jio_fprintf(defaultStream::error_stream(), "InitialTenuringThreshold (" UINTX_FORMAT ") must be less than or " @@ -124,7 +122,7 @@ Flag::Error MaxTenuringThresholdConstraintFunc(bool verbose, uintx* value) { UseConcMarkSweepGCWorkaroundIfNeeded(InitialTenuringThreshold, *value); - if ((CommandLineFlags::finishedInitializing() == true) && (*value < InitialTenuringThreshold)) { + if ((CommandLineFlags::finishedInitializing()) && (*value < InitialTenuringThreshold)) { if (verbose == true) { jio_fprintf(defaultStream::error_stream(), "MaxTenuringThreshold (" UINTX_FORMAT ") must be greater than or " @@ -140,7 +138,7 @@ #if INCLUDE_ALL_GCS Flag::Error G1NewSizePercentConstraintFunc(bool verbose, uintx* value) { - if ((CommandLineFlags::finishedInitializing() == true) && (*value > G1MaxNewSizePercent)) { + if ((CommandLineFlags::finishedInitializing()) && (*value > G1MaxNewSizePercent)) { if (verbose == true) { jio_fprintf(defaultStream::error_stream(), "G1NewSizePercent (" UINTX_FORMAT ") must be less than or " @@ -154,7 +152,7 @@ } Flag::Error G1MaxNewSizePercentConstraintFunc(bool verbose, uintx* value) { - if ((CommandLineFlags::finishedInitializing() == true) && (*value < G1NewSizePercent)) { + if ((CommandLineFlags::finishedInitializing()) && (*value < G1NewSizePercent)) { if (verbose == true) { jio_fprintf(defaultStream::error_stream(), "G1MaxNewSizePercent (" UINTX_FORMAT ") must be greater than or " @@ -170,7 +168,7 @@ #endif // INCLUDE_ALL_GCS Flag::Error CMSOldPLABMinConstraintFunc(bool verbose, size_t* value) { - if ((CommandLineFlags::finishedInitializing() == true) && (*value > CMSOldPLABMax)) { + if ((CommandLineFlags::finishedInitializing()) && (*value > CMSOldPLABMax)) { if (verbose == true) { jio_fprintf(defaultStream::error_stream(), "CMSOldPLABMin (" SIZE_FORMAT ") must be less than or " @@ -183,22 +181,8 @@ } } -Flag::Error CMSOldPLABMaxConstraintFunc(bool verbose, size_t* value) { - if ((CommandLineFlags::finishedInitializing() == true) && (*value < CMSOldPLABMax)) { - if (verbose == true) { - jio_fprintf(defaultStream::error_stream(), - "CMSOldPLABMax (" SIZE_FORMAT ") must be greater than or " - "equal to CMSOldPLABMax (" SIZE_FORMAT ")\n", - *value, CMSOldPLABMax); - } - return Flag::VIOLATES_CONSTRAINT; - } else { - return Flag::SUCCESS; - } -} - Flag::Error CMSPrecleanDenominatorConstraintFunc(bool verbose, uintx* value) { - if ((CommandLineFlags::finishedInitializing() == true) && (*value <= CMSPrecleanNumerator)) { + if ((CommandLineFlags::finishedInitializing()) && (*value <= CMSPrecleanNumerator)) { if (verbose == true) { jio_fprintf(defaultStream::error_stream(), "CMSPrecleanDenominator (" UINTX_FORMAT ") must be strickly greater than " @@ -212,7 +196,7 @@ } Flag::Error CMSPrecleanNumeratorConstraintFunc(bool verbose, uintx* value) { - if ((CommandLineFlags::finishedInitializing() == true) && (*value > (CMSPrecleanDenominator - 1))) { + if ((CommandLineFlags::finishedInitializing()) && (*value > (CMSPrecleanDenominator - 1))) { if (verbose == true) { jio_fprintf(defaultStream::error_stream(), "CMSPrecleanNumerator (" UINTX_FORMAT ") must be less than or " @@ -226,7 +210,7 @@ } Flag::Error SurvivorAlignmentInBytesConstraintFunc(bool verbose, intx* value) { - if (CommandLineFlags::finishedInitializing() == true) { + if (CommandLineFlags::finishedInitializing()) { if (*value != 0) { if (!is_power_of_2(*value)) { if (verbose == true) {