--- old/src/hotspot/share/services/management.cpp 2018-03-29 13:44:22.000000000 -0500 +++ new/src/hotspot/share/services/management.cpp 2018-03-29 13:44:22.000000000 -0500 @@ -866,10 +866,10 @@ static jint get_num_flags() { // last flag entry is always NULL, so subtract 1 - int nFlags = (int) Flag::numFlags - 1; + int nFlags = (int) JVMFlag::numFlags - 1; int count = 0; for (int i = 0; i < nFlags; i++) { - Flag* flag = &Flag::flags[i]; + JVMFlag* flag = &JVMFlag::flags[i]; // Exclude the locked (diagnostic, experimental) flags if (flag->is_unlocked() || flag->is_unlocker()) { count++; @@ -1419,14 +1419,14 @@ // Returns a String array of all VM global flag names JVM_ENTRY(jobjectArray, jmm_GetVMGlobalNames(JNIEnv *env)) // last flag entry is always NULL, so subtract 1 - int nFlags = (int) Flag::numFlags - 1; + int nFlags = (int) JVMFlag::numFlags - 1; // allocate a temp array objArrayOop r = oopFactory::new_objArray(SystemDictionary::String_klass(), nFlags, CHECK_0); objArrayHandle flags_ah(THREAD, r); int num_entries = 0; for (int i = 0; i < nFlags; i++) { - Flag* flag = &Flag::flags[i]; + JVMFlag* flag = &JVMFlag::flags[i]; // Exclude notproduct and develop flags in product builds. if (flag->is_constant_in_binary()) { continue; @@ -1454,7 +1454,7 @@ // Utility function used by jmm_GetVMGlobals. Returns false if flag type // can't be determined, true otherwise. If false is returned, then *global // will be incomplete and invalid. -bool add_global_entry(JNIEnv* env, Handle name, jmmVMGlobal *global, Flag *flag, TRAPS) { +bool add_global_entry(JNIEnv* env, Handle name, jmmVMGlobal *global, JVMFlag *flag, TRAPS) { Handle flag_name; if (name() == NULL) { flag_name = java_lang_String::create_from_str(flag->_name, CHECK_false); @@ -1499,25 +1499,25 @@ global->writeable = flag->is_writeable(); global->external = flag->is_external(); switch (flag->get_origin()) { - case Flag::DEFAULT: + case JVMFlag::DEFAULT: global->origin = JMM_VMGLOBAL_ORIGIN_DEFAULT; break; - case Flag::COMMAND_LINE: + case JVMFlag::COMMAND_LINE: global->origin = JMM_VMGLOBAL_ORIGIN_COMMAND_LINE; break; - case Flag::ENVIRON_VAR: + case JVMFlag::ENVIRON_VAR: global->origin = JMM_VMGLOBAL_ORIGIN_ENVIRON_VAR; break; - case Flag::CONFIG_FILE: + case JVMFlag::CONFIG_FILE: global->origin = JMM_VMGLOBAL_ORIGIN_CONFIG_FILE; break; - case Flag::MANAGEMENT: + case JVMFlag::MANAGEMENT: global->origin = JMM_VMGLOBAL_ORIGIN_MANAGEMENT; break; - case Flag::ERGONOMIC: + case JVMFlag::ERGONOMIC: global->origin = JMM_VMGLOBAL_ORIGIN_ERGONOMIC; break; - case Flag::ATTACH_ON_DEMAND: + case JVMFlag::ATTACH_ON_DEMAND: global->origin = JMM_VMGLOBAL_ORIGIN_ATTACH_ON_DEMAND; break; default: @@ -1531,7 +1531,7 @@ // specified by names. If names == NULL, fill globals array // with all Flags. Return value is number of entries // created in globals. -// If a Flag with a given name in an array element does not +// If a JVMFlag with a given name in an array element does not // exist, globals[i].name will be set to NULL. JVM_ENTRY(jint, jmm_GetVMGlobals(JNIEnv *env, jobjectArray names, @@ -1566,7 +1566,7 @@ Handle sh(THREAD, s); char* str = java_lang_String::as_utf8_string(s); - Flag* flag = Flag::find_flag(str, strlen(str)); + JVMFlag* flag = JVMFlag::find_flag(str, strlen(str)); if (flag != NULL && add_global_entry(env, sh, &globals[i], flag, THREAD)) { num_entries++; @@ -1579,11 +1579,11 @@ // return all globals if names == NULL // last flag entry is always NULL, so subtract 1 - int nFlags = (int) Flag::numFlags - 1; + int nFlags = (int) JVMFlag::numFlags - 1; Handle null_h; int num_entries = 0; for (int i = 0; i < nFlags && num_entries < count; i++) { - Flag* flag = &Flag::flags[i]; + JVMFlag* flag = &JVMFlag::flags[i]; // Exclude notproduct and develop flags in product builds. if (flag->is_constant_in_binary()) { continue; @@ -1609,10 +1609,10 @@ char* name = java_lang_String::as_utf8_string(fn); FormatBuffer<80> error_msg("%s", ""); - int succeed = WriteableFlags::set_flag(name, new_value, Flag::MANAGEMENT, error_msg); + int succeed = WriteableFlags::set_flag(name, new_value, JVMFlag::MANAGEMENT, error_msg); - if (succeed != Flag::SUCCESS) { - if (succeed == Flag::MISSING_VALUE) { + if (succeed != JVMFlag::SUCCESS) { + if (succeed == JVMFlag::MISSING_VALUE) { // missing value causes NPE to be thrown THROW(vmSymbols::java_lang_NullPointerException()); } else { @@ -1621,7 +1621,7 @@ error_msg.buffer()); } } - assert(succeed == Flag::SUCCESS, "Setting flag should succeed"); + assert(succeed == JVMFlag::SUCCESS, "Setting flag should succeed"); JVM_END class ThreadTimesClosure: public ThreadClosure {