Code Review for nashorn-openjdk

Prepared by:hannesw on Fri Jan 11 16:56:26 CET 2013
Workspace:/home/hannes/work/nashorn-openjdk
Summary of changes: 17698 lines changed: 17609 ins; 17 del; 72 mod; 3243 unchg
Patch of changes: nashorn-openjdk.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw bin/jjs

0 lines changed: 0 ins; 0 del; 0 mod; 29 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/objects/NativeRegExp.java

112 lines changed: 57 ins; 2 del; 53 mod; 717 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/objects/NativeString.java

3 lines changed: 0 ins; 1 del; 2 mod; 934 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/parser/RegExp.java

29 lines changed: 9 ins; 4 del; 16 mod; 160 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/parser/RegExpScanner.java

11 lines changed: 0 ins; 10 del; 1 mod; 1403 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk/nashorn/internal/joni/Analyser.java

2162 lines changed: 2162 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk/nashorn/internal/joni/ApplyCaseFold.java

91 lines changed: 91 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk/nashorn/internal/joni/ApplyCaseFoldArg.java

35 lines changed: 35 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk/nashorn/internal/joni/ArrayCompiler.java

1263 lines changed: 1263 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk/nashorn/internal/joni/AsmCompiler.java

109 lines changed: 109 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk/nashorn/internal/joni/AsmCompilerSupport.java

267 lines changed: 267 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk/nashorn/internal/joni/BitSet.java

115 lines changed: 115 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk/nashorn/internal/joni/BitStatus.java

55 lines changed: 55 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk/nashorn/internal/joni/ByteCodeMachine.java

1462 lines changed: 1462 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk/nashorn/internal/joni/ByteCodePrinter.java

416 lines changed: 416 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk/nashorn/internal/joni/CaptureTreeNode.java

74 lines changed: 74 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk/nashorn/internal/joni/CodeRangeBuffer.java

378 lines changed: 378 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk/nashorn/internal/joni/Compiler.java

178 lines changed: 178 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk/nashorn/internal/joni/Config.java

100 lines changed: 100 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk/nashorn/internal/joni/EncodingHelper.java

285 lines changed: 285 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk/nashorn/internal/joni/Lexer.java

1274 lines changed: 1274 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk/nashorn/internal/joni/Matcher.java

556 lines changed: 556 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk/nashorn/internal/joni/MatcherFactory.java

31 lines changed: 31 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk/nashorn/internal/joni/MinMaxLen.java

139 lines changed: 139 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk/nashorn/internal/joni/NameEntry.java

97 lines changed: 97 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk/nashorn/internal/joni/NativeMachine.java

27 lines changed: 27 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk/nashorn/internal/joni/NodeOptInfo.java

125 lines changed: 125 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk/nashorn/internal/joni/OptAnchorInfo.java

92 lines changed: 92 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk/nashorn/internal/joni/OptEnvironment.java

35 lines changed: 35 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk/nashorn/internal/joni/OptExactInfo.java

153 lines changed: 153 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk/nashorn/internal/joni/OptMapInfo.java

120 lines changed: 120 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk/nashorn/internal/joni/Option.java

122 lines changed: 122 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk/nashorn/internal/joni/Parser.java

953 lines changed: 953 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk/nashorn/internal/joni/Regex.java

413 lines changed: 413 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk/nashorn/internal/joni/Region.java

66 lines changed: 66 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk/nashorn/internal/joni/ScanEnvironment.java

137 lines changed: 137 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk/nashorn/internal/joni/ScannerSupport.java

178 lines changed: 178 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk/nashorn/internal/joni/SearchAlgorithm.java

294 lines changed: 294 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk/nashorn/internal/joni/StackEntry.java

164 lines changed: 164 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk/nashorn/internal/joni/StackMachine.java

621 lines changed: 621 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk/nashorn/internal/joni/Syntax.java

628 lines changed: 628 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk/nashorn/internal/joni/Token.java

172 lines changed: 172 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk/nashorn/internal/joni/UnsetAddrList.java

69 lines changed: 69 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk/nashorn/internal/joni/WarnCallback.java

33 lines changed: 33 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk/nashorn/internal/joni/Warnings.java

26 lines changed: 26 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk/nashorn/internal/joni/ast/AnchorNode.java

92 lines changed: 92 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk/nashorn/internal/joni/ast/AnyCharNode.java

40 lines changed: 40 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk/nashorn/internal/joni/ast/BackRefNode.java

98 lines changed: 98 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk/nashorn/internal/joni/ast/CClassNode.java

545 lines changed: 545 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk/nashorn/internal/joni/ast/CTypeNode.java

50 lines changed: 50 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk/nashorn/internal/joni/ast/CallNode.java

86 lines changed: 86 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk/nashorn/internal/joni/ast/ConsAltNode.java

152 lines changed: 152 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk/nashorn/internal/joni/ast/EncloseNode.java

151 lines changed: 151 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk/nashorn/internal/joni/ast/Node.java

135 lines changed: 135 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk/nashorn/internal/joni/ast/QuantifierNode.java

272 lines changed: 272 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk/nashorn/internal/joni/ast/StateNode.java

232 lines changed: 232 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk/nashorn/internal/joni/ast/StringNode.java

207 lines changed: 207 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk/nashorn/internal/joni/bench/AbstractBench.java

49 lines changed: 49 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk/nashorn/internal/joni/bench/BenchGreedyBacktrack.java

7 lines changed: 7 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk/nashorn/internal/joni/bench/BenchRailsRegs.java

31 lines changed: 31 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk/nashorn/internal/joni/bench/BenchSeveralRegexps.java

17 lines changed: 17 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk/nashorn/internal/joni/constants/AnchorType.java

58 lines changed: 58 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk/nashorn/internal/joni/constants/Arguments.java

31 lines changed: 31 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk/nashorn/internal/joni/constants/AsmConstants.java

49 lines changed: 49 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk/nashorn/internal/joni/constants/CCSTATE.java

27 lines changed: 27 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk/nashorn/internal/joni/constants/CCVALTYPE.java

26 lines changed: 26 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk/nashorn/internal/joni/constants/EncloseType.java

29 lines changed: 29 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk/nashorn/internal/joni/constants/MetaChar.java

31 lines changed: 31 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk/nashorn/internal/joni/constants/NodeStatus.java

39 lines changed: 39 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk/nashorn/internal/joni/constants/NodeType.java

66 lines changed: 66 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk/nashorn/internal/joni/constants/OPCode.java

387 lines changed: 387 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk/nashorn/internal/joni/constants/OPSize.java

76 lines changed: 76 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk/nashorn/internal/joni/constants/Reduce.java

61 lines changed: 61 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk/nashorn/internal/joni/constants/RegexState.java

28 lines changed: 28 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk/nashorn/internal/joni/constants/StackPopLevel.java

27 lines changed: 27 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk/nashorn/internal/joni/constants/StackType.java

51 lines changed: 51 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk/nashorn/internal/joni/constants/StringType.java

27 lines changed: 27 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk/nashorn/internal/joni/constants/SyntaxProperties.java

124 lines changed: 124 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk/nashorn/internal/joni/constants/TargetInfo.java

27 lines changed: 27 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk/nashorn/internal/joni/constants/TokenType.java

48 lines changed: 48 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk/nashorn/internal/joni/constants/Traverse.java

26 lines changed: 26 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk/nashorn/internal/joni/encoding/AsciiTables.java

157 lines changed: 157 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk/nashorn/internal/joni/encoding/CharacterType.java

79 lines changed: 79 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk/nashorn/internal/joni/encoding/IntHolder.java

24 lines changed: 24 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk/nashorn/internal/joni/encoding/ObjPtr.java

35 lines changed: 35 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk/nashorn/internal/joni/encoding/PosixBracket.java

77 lines changed: 77 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk/nashorn/internal/joni/encoding/Ptr.java

35 lines changed: 35 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk/nashorn/internal/joni/exception/ErrorMessages.java

98 lines changed: 98 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk/nashorn/internal/joni/exception/InternalException.java

28 lines changed: 28 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk/nashorn/internal/joni/exception/JOniException.java

28 lines changed: 28 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk/nashorn/internal/joni/exception/SyntaxException.java

28 lines changed: 28 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk/nashorn/internal/joni/exception/ValueException.java

37 lines changed: 37 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /home/hannes/bin/webrev.sh (vers 23.18-hg).