Code Review for nashorn9-dev

Prepared by:hannesw on Wed Nov 11 12:51:28 CET 2015
Workspace:/home/hannes/work/nashorn9-dev
Summary of changes: 939 lines changed: 703 ins; 87 del; 149 mod; 25109 unchg
Patch of changes: nashorn9-dev.patch
Bug id: <title>[JDK-8141702] Add support for Symbol property keys - Java Bug System</title>
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.scripting.nashorn.shell/share/classes/jdk/nashorn/tools/jjs/Main.java

1 line changed: 0 ins; 0 del; 1 mod; 230 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.scripting.nashorn/share/classes/jdk/nashorn/internal/codegen/MethodEmitter.java

1 line changed: 0 ins; 0 del; 1 mod; 2757 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.scripting.nashorn/share/classes/jdk/nashorn/internal/codegen/SpillObjectCreator.java

2 lines changed: 1 ins; 0 del; 1 mod; 199 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.scripting.nashorn/share/classes/jdk/nashorn/internal/objects/Global.java

31 lines changed: 25 ins; 0 del; 6 mod; 2756 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.scripting.nashorn/share/classes/jdk/nashorn/internal/objects/NativeArguments.java

2 lines changed: 0 ins; 0 del; 2 mod; 344 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.scripting.nashorn/share/classes/jdk/nashorn/internal/objects/NativeArray.java

2 lines changed: 0 ins; 0 del; 2 mod; 1894 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.scripting.nashorn/share/classes/jdk/nashorn/internal/objects/NativeJavaImporter.java

5 lines changed: 3 ins; 0 del; 2 mod; 177 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.scripting.nashorn/share/classes/jdk/nashorn/internal/objects/NativeObject.java

19 lines changed: 18 ins; 0 del; 1 mod; 848 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.scripting.nashorn/share/classes/jdk/nashorn/internal/objects/NativeString.java

24 lines changed: 6 ins; 14 del; 4 mod; 1394 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.scripting.nashorn/share/classes/jdk/nashorn/internal/runtime/AccessorProperty.java

7 lines changed: 0 ins; 0 del; 7 mod; 753 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.scripting.nashorn/share/classes/jdk/nashorn/internal/runtime/Context.java

52 lines changed: 8 ins; 42 del; 2 mod; 1650 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.scripting.nashorn/share/classes/jdk/nashorn/internal/runtime/GlobalConstants.java

2 lines changed: 0 ins; 0 del; 2 mod; 484 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.scripting.nashorn/share/classes/jdk/nashorn/internal/runtime/JSType.java

39 lines changed: 35 ins; 0 del; 4 mod; 1985 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.scripting.nashorn/share/classes/jdk/nashorn/internal/runtime/NativeJavaPackage.java

5 lines changed: 3 ins; 0 del; 2 mod; 275 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.scripting.nashorn/share/classes/jdk/nashorn/internal/runtime/Property.java

4 lines changed: 0 ins; 0 del; 4 mod; 715 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.scripting.nashorn/share/classes/jdk/nashorn/internal/runtime/PropertyHashMap.java

53 lines changed: 0 ins; 30 del; 23 mod; 661 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.scripting.nashorn/share/classes/jdk/nashorn/internal/runtime/PropertyListeners.java

1 line changed: 0 ins; 0 del; 1 mod; 245 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.scripting.nashorn/share/classes/jdk/nashorn/internal/runtime/PropertyMap.java

5 lines changed: 0 ins; 0 del; 5 mod; 1158 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.scripting.nashorn/share/classes/jdk/nashorn/internal/runtime/ScriptObject.java

82 lines changed: 19 ins; 1 del; 62 mod; 3773 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.scripting.nashorn/share/classes/jdk/nashorn/internal/runtime/ScriptRuntime.java

7 lines changed: 0 ins; 0 del; 7 mod; 1063 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.scripting.nashorn/share/classes/jdk/nashorn/internal/runtime/SpillProperty.java

2 lines changed: 0 ins; 0 del; 2 mod; 220 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.scripting.nashorn/share/classes/jdk/nashorn/internal/runtime/UserAccessorProperty.java

2 lines changed: 0 ins; 0 del; 2 mod; 384 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.scripting.nashorn/share/classes/jdk/nashorn/internal/runtime/WithObject.java

4 lines changed: 0 ins; 0 del; 4 mod; 399 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.scripting.nashorn/share/classes/jdk/nashorn/internal/runtime/resources/Messages.properties

5 lines changed: 5 ins; 0 del; 0 mod; 184 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.scripting.nashorn/share/classes/jdk/nashorn/tools/Shell.java

58 lines changed: 57 ins; 0 del; 1 mod; 493 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/script/basic/es6/let.js

2 lines changed: 1 ins; 0 del; 1 mod; 68 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.scripting.nashorn/share/classes/jdk/nashorn/internal/WeakValueCache.java

107 lines changed: 107 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.scripting.nashorn/share/classes/jdk/nashorn/internal/objects/NativeSymbol.java

152 lines changed: 152 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.scripting.nashorn/share/classes/jdk/nashorn/internal/runtime/Symbol.java

59 lines changed: 59 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/script/basic/es6.js

58 lines changed: 58 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/script/basic/es6/symbols.js

146 lines changed: 146 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /home/hannes/bin/webrev.ksh (vers 25.12-hg+openjdk.java.net).