Code Review for nashorn8u-dev

Prepared by:hannesw on Wed Aug 10 20:08:20 CEST 2016
Workspace:/Users/hannes/Work/nashorn8u-dev
Compare against: ssh://hg.openjdk.java.net/jdk8u/jdk8u-dev/nashorn
Compare against version:1900
Summary of changes: 276 lines changed: 221 ins; 19 del; 36 mod; 5095 unchg
Changeset: nashorn8u-dev.changeset
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw docs/DEVELOPER_README

rev 1905 : 8162955: Activate anonymous class loading for small sources
Reviewed-by: sundar
10 lines changed: 10 ins; 0 del; 0 mod; 618 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/jdk/nashorn/internal/codegen/CompilationPhase.java

rev 1901 : 8135251: Use Unsafe.defineAnonymousClass for loading Nashorn script code
Reviewed-by: hannesw, lagergren, sundar
3 lines changed: 1 ins; 0 del; 2 mod; 638 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/jdk/nashorn/internal/runtime/CodeInstaller.java

rev 1901 : 8135251: Use Unsafe.defineAnonymousClass for loading Nashorn script code
Reviewed-by: hannesw, lagergren, sundar
13 lines changed: 8 ins; 0 del; 5 mod; 114 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/jdk/nashorn/internal/runtime/Context.java

rev 1901 : 8135251: Use Unsafe.defineAnonymousClass for loading Nashorn script code
Reviewed-by: hannesw, lagergren, sundar
rev 1902 : 8136647: Syntactic error accidentally left in JDK-8135251 changeset
Reviewed-by: sundar
rev 1903 : 8136700: Make sure Context.anonymousHostClasses doesn't grow unbounded
Reviewed-by: hannesw, sundar
rev 1904 : 8138882: Performance regression due to anonymous classloading
Reviewed-by: attila, sundar
rev 1905 : 8162955: Activate anonymous class loading for small sources
Reviewed-by: sundar
190 lines changed: 153 ins; 18 del; 19 mod; 1480 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/jdk/nashorn/internal/runtime/RecompilableScriptFunctionData.java

rev 1901 : 8135251: Use Unsafe.defineAnonymousClass for loading Nashorn script code
Reviewed-by: hannesw, lagergren, sundar
1 line changed: 0 ins; 0 del; 1 mod; 1053 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/jdk/nashorn/internal/runtime/ScriptEnvironment.java

rev 1904 : 8138882: Performance regression due to anonymous classloading
Reviewed-by: attila, sundar
rev 1905 : 8162955: Activate anonymous class loading for small sources
Reviewed-by: sundar
38 lines changed: 38 ins; 0 del; 0 mod; 410 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/jdk/nashorn/internal/runtime/Timing.java

rev 1901 : 8135251: Use Unsafe.defineAnonymousClass for loading Nashorn script code
Reviewed-by: hannesw, lagergren, sundar
10 lines changed: 2 ins; 1 del; 7 mod; 237 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/jdk/nashorn/internal/runtime/resources/Options.properties

rev 1904 : 8138882: Performance regression due to anonymous classloading
Reviewed-by: attila, sundar
9 lines changed: 9 ins; 0 del; 0 mod; 394 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/script/nosecurity/JDK-8044798.js

rev 1904 : 8138882: Performance regression due to anonymous classloading
Reviewed-by: attila, sundar
2 lines changed: 0 ins; 0 del; 2 mod; 151 unchg

This code review page was prepared using /Users/hannes/webrev.ksh (vers 25.16-hg+openjdk.java.net).