Code Review for jdk

Prepared by:henryjen on Wed Aug 28 13:48:55 PDT 2013
Workspace:/home/hjen/ws/tl-work/jdk
Compare against: /home/hjen/ws/tl/jdk
Compare against version:7961
Summary of changes: 921 lines changed: 394 ins; 358 del; 169 mod; 12565 unchg
Changeset: jdk.changeset
Bug id: JDK-8017513 : Support for closeable streams - Java Bug System
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/classes/java/nio/file/Files.java

rev 7962 : 8017513: Support for closeable streams
8022237: j.u.s.BaseStream.onClose() has an issue in implementation or requires spec clarification
8022572: Same exception instances thrown from j.u.stream.Stream.onClose() handlers are not listed as suppressed
Summary: BaseStream implements AutoCloseable; Remove CloseableStream and DelegatingStream
Reviewed-by:
Contributed-by: brian.goetz@oracle.com
191 lines changed: 88 ins; 30 del; 73 mod; 3463 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/classes/java/util/stream/AbstractPipeline.java

rev 7962 : 8017513: Support for closeable streams
8022237: j.u.s.BaseStream.onClose() has an issue in implementation or requires spec clarification
8022572: Same exception instances thrown from j.u.stream.Stream.onClose() handlers are not listed as suppressed
Summary: BaseStream implements AutoCloseable; Remove CloseableStream and DelegatingStream
Reviewed-by:
Contributed-by: brian.goetz@oracle.com
36 lines changed: 28 ins; 0 del; 8 mod; 701 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/classes/java/util/stream/BaseStream.java

rev 7962 : 8017513: Support for closeable streams
8022237: j.u.s.BaseStream.onClose() has an issue in implementation or requires spec clarification
8022572: Same exception instances thrown from j.u.stream.Stream.onClose() handlers are not listed as suppressed
Summary: BaseStream implements AutoCloseable; Remove CloseableStream and DelegatingStream
Reviewed-by:
Contributed-by: brian.goetz@oracle.com
31 lines changed: 30 ins; 0 del; 1 mod; 105 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/classes/java/util/stream/DoublePipeline.java

rev 7962 : 8017513: Support for closeable streams
8022237: j.u.s.BaseStream.onClose() has an issue in implementation or requires spec clarification
8022572: Same exception instances thrown from j.u.stream.Stream.onClose() handlers are not listed as suppressed
Summary: BaseStream implements AutoCloseable; Remove CloseableStream and DelegatingStream
Reviewed-by:
Contributed-by: brian.goetz@oracle.com
5 lines changed: 1 ins; 0 del; 4 mod; 604 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/classes/java/util/stream/DoubleStream.java

rev 7962 : 8017513: Support for closeable streams
8022237: j.u.s.BaseStream.onClose() has an issue in implementation or requires spec clarification
8022572: Same exception instances thrown from j.u.stream.Stream.onClose() handlers are not listed as suppressed
Summary: BaseStream implements AutoCloseable; Remove CloseableStream and DelegatingStream
Reviewed-by:
Contributed-by: brian.goetz@oracle.com
4 lines changed: 2 ins; 0 del; 2 mod; 824 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/classes/java/util/stream/IntPipeline.java

rev 7962 : 8017513: Support for closeable streams
8022237: j.u.s.BaseStream.onClose() has an issue in implementation or requires spec clarification
8022572: Same exception instances thrown from j.u.stream.Stream.onClose() handlers are not listed as suppressed
Summary: BaseStream implements AutoCloseable; Remove CloseableStream and DelegatingStream
Reviewed-by:
Contributed-by: brian.goetz@oracle.com
5 lines changed: 1 ins; 0 del; 4 mod; 639 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/classes/java/util/stream/IntStream.java

rev 7962 : 8017513: Support for closeable streams
8022237: j.u.s.BaseStream.onClose() has an issue in implementation or requires spec clarification
8022572: Same exception instances thrown from j.u.stream.Stream.onClose() handlers are not listed as suppressed
Summary: BaseStream implements AutoCloseable; Remove CloseableStream and DelegatingStream
Reviewed-by:
Contributed-by: brian.goetz@oracle.com
4 lines changed: 2 ins; 0 del; 2 mod; 878 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/classes/java/util/stream/LongPipeline.java

rev 7962 : 8017513: Support for closeable streams
8022237: j.u.s.BaseStream.onClose() has an issue in implementation or requires spec clarification
8022572: Same exception instances thrown from j.u.stream.Stream.onClose() handlers are not listed as suppressed
Summary: BaseStream implements AutoCloseable; Remove CloseableStream and DelegatingStream
Reviewed-by:
Contributed-by: brian.goetz@oracle.com
5 lines changed: 1 ins; 0 del; 4 mod; 619 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/classes/java/util/stream/LongStream.java

rev 7962 : 8017513: Support for closeable streams
8022237: j.u.s.BaseStream.onClose() has an issue in implementation or requires spec clarification
8022572: Same exception instances thrown from j.u.stream.Stream.onClose() handlers are not listed as suppressed
Summary: BaseStream implements AutoCloseable; Remove CloseableStream and DelegatingStream
Reviewed-by:
Contributed-by: brian.goetz@oracle.com
4 lines changed: 2 ins; 0 del; 2 mod; 884 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/classes/java/util/stream/ReferencePipeline.java

rev 7962 : 8017513: Support for closeable streams
8022237: j.u.s.BaseStream.onClose() has an issue in implementation or requires spec clarification
8022572: Same exception instances thrown from j.u.stream.Stream.onClose() handlers are not listed as suppressed
Summary: BaseStream implements AutoCloseable; Remove CloseableStream and DelegatingStream
Reviewed-by:
Contributed-by: brian.goetz@oracle.com
20 lines changed: 4 ins; 0 del; 16 mod; 652 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/classes/java/util/stream/Stream.java

rev 7962 : 8017513: Support for closeable streams
8022237: j.u.s.BaseStream.onClose() has an issue in implementation or requires spec clarification
8022572: Same exception instances thrown from j.u.stream.Stream.onClose() handlers are not listed as suppressed
Summary: BaseStream implements AutoCloseable; Remove CloseableStream and DelegatingStream
Reviewed-by:
Contributed-by: brian.goetz@oracle.com
4 lines changed: 2 ins; 0 del; 2 mod; 970 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/classes/java/util/stream/Streams.java

rev 7962 : 8017513: Support for closeable streams
8022237: j.u.s.BaseStream.onClose() has an issue in implementation or requires spec clarification
8022572: Same exception instances thrown from j.u.stream.Stream.onClose() handlers are not listed as suppressed
Summary: BaseStream implements AutoCloseable; Remove CloseableStream and DelegatingStream
Reviewed-by:
Contributed-by: brian.goetz@oracle.com
59 lines changed: 59 ins; 0 del; 0 mod; 836 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw test/java/nio/file/Files/StreamTest.java

rev 7962 : 8017513: Support for closeable streams
8022237: j.u.s.BaseStream.onClose() has an issue in implementation or requires spec clarification
8022572: Same exception instances thrown from j.u.stream.Stream.onClose() handlers are not listed as suppressed
Summary: BaseStream implements AutoCloseable; Remove CloseableStream and DelegatingStream
Reviewed-by:
Contributed-by: brian.goetz@oracle.com
50 lines changed: 2 ins; 1 del; 47 mod; 613 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw test/java/util/stream/bootlib/java/util/stream/DoubleStreamTestScenario.java

rev 7962 : 8017513: Support for closeable streams
8022237: j.u.s.BaseStream.onClose() has an issue in implementation or requires spec clarification
8022572: Same exception instances thrown from j.u.stream.Stream.onClose() handlers are not listed as suppressed
Summary: BaseStream implements AutoCloseable; Remove CloseableStream and DelegatingStream
Reviewed-by:
Contributed-by: brian.goetz@oracle.com
2 lines changed: 1 ins; 0 del; 1 mod; 184 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw test/java/util/stream/bootlib/java/util/stream/IntStreamTestScenario.java

rev 7962 : 8017513: Support for closeable streams
8022237: j.u.s.BaseStream.onClose() has an issue in implementation or requires spec clarification
8022572: Same exception instances thrown from j.u.stream.Stream.onClose() handlers are not listed as suppressed
Summary: BaseStream implements AutoCloseable; Remove CloseableStream and DelegatingStream
Reviewed-by:
Contributed-by: brian.goetz@oracle.com
2 lines changed: 1 ins; 0 del; 1 mod; 185 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw test/java/util/stream/bootlib/java/util/stream/LongStreamTestScenario.java

rev 7962 : 8017513: Support for closeable streams
8022237: j.u.s.BaseStream.onClose() has an issue in implementation or requires spec clarification
8022572: Same exception instances thrown from j.u.stream.Stream.onClose() handlers are not listed as suppressed
Summary: BaseStream implements AutoCloseable; Remove CloseableStream and DelegatingStream
Reviewed-by:
Contributed-by: brian.goetz@oracle.com
2 lines changed: 1 ins; 0 del; 1 mod; 184 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw test/java/util/stream/bootlib/java/util/stream/StreamTestScenario.java

rev 7962 : 8017513: Support for closeable streams
8022237: j.u.s.BaseStream.onClose() has an issue in implementation or requires spec clarification
8022572: Same exception instances thrown from j.u.stream.Stream.onClose() handlers are not listed as suppressed
Summary: BaseStream implements AutoCloseable; Remove CloseableStream and DelegatingStream
Reviewed-by:
Contributed-by: brian.goetz@oracle.com
2 lines changed: 1 ins; 0 del; 1 mod; 224 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/java/util/stream/test/org/openjdk/tests/java/util/stream/StreamCloseTest.java

rev 7962 : 8017513: Support for closeable streams
8022237: j.u.s.BaseStream.onClose() has an issue in implementation or requires spec clarification
8022572: Same exception instances thrown from j.u.stream.Stream.onClose() handlers are not listed as suppressed
Summary: BaseStream implements AutoCloseable; Remove CloseableStream and DelegatingStream
Reviewed-by:
Contributed-by: brian.goetz@oracle.com
168 lines changed: 168 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- ----- --- src/share/classes/java/util/stream/CloseableStream.java

57 lines changed: 0 ins; 57 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- ----- --- src/share/classes/java/util/stream/DelegatingStream.java

270 lines changed: 0 ins; 270 del; 0 mod; 0 unchg

This code review page was prepared using ../make/scripts/webrev.ksh (vers 24.0-hg+jbs).