Code Review for panama.dev

Prepared by:henryjen on Tue Sep 24 19:32:41 PDT 2019
Workspace:/Users/hjen/ws/panama.dev
Compare against: https://hg.openjdk.java.net/panama/dev
Compare against version:qbase
Branch:foreign
Summary of changes: 340 lines changed: 296 ins; 30 del; 14 mod; 2436 unchg
Patch of changes: panama.dev.patch
Bug id: JDK-8229857
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/foreign/Scope.java 

rev 57829 : [mq]: 8229857
22 lines changed: 19 ins; 3 del; 0 mod; 227 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/foreign/memory/Pointer.java 

rev 57828 : 8229752: Use of pointer from scope.allocateArray with 0 element cause IllegalStateException
Reviewed-by: jvernee
rev 57829 : [mq]: 8229857
15 lines changed: 14 ins; 1 del; 0 mod; 313 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/foreign/ScopeImpl.java 

rev 57828 : 8229752: Use of pointer from scope.allocateArray with 0 element cause IllegalStateException
Reviewed-by: jvernee
rev 57829 : [mq]: 8229857
19 lines changed: 0 ins; 18 del; 1 mod; 316 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/foreign/memory/BoundedPointer.java 

rev 57829 : [mq]: 8229857
12 lines changed: 12 ins; 0 del; 0 mod; 369 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/foreign/memory/References.java 

rev 57829 : [mq]: 8229857
4 lines changed: 0 ins; 2 del; 2 mod; 731 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/foreign/ResourceStructTest.java 

rev 57829 : [mq]: 8229857
53 lines changed: 48 ins; 0 del; 5 mod; 184 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/foreign/ScopeTest.java 

rev 57829 : [mq]: 8229857
28 lines changed: 27 ins; 0 del; 1 mod; 190 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/foreign/types/FunctionAccessTest.java 

rev 57829 : [mq]: 8229857
27 lines changed: 16 ins; 6 del; 5 mod; 106 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/foreign/TestHelper.java 

rev 57829 : [mq]: 8229857
72 lines changed: 72 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/foreign/libTestHelpers.c 

rev 57829 : [mq]: 8229857
88 lines changed: 88 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /Users/hjen/bin/webrev.ksh (vers 25.17-hg+openjdk.java.net).