Code Review for open

Prepared by:herrick on Wed Jun 19 19:05:27 EDT 2019
Workspace:/home/aherrick/sandbox/open
Branch:JDK-8200758-branch
Summary of changes: 674 lines changed: 58 ins; 500 del; 116 mod; 11441 unchg
Patch of changes: open.patch
Bug id: JDK-8225428 : CLI change to remove "mode", rename to "package", and build only one target
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/linux/classes/jdk/jpackage/internal/LinuxDebBundler.java

6 lines changed: 5 ins; 0 del; 1 mod; 876 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/linux/classes/jdk/jpackage/internal/LinuxRpmBundler.java

6 lines changed: 5 ins; 0 del; 1 mod; 718 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/share/classes/jdk/jpackage/internal/Arguments.java

168 lines changed: 30 ins; 88 del; 50 mod; 730 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/share/classes/jdk/jpackage/internal/BundleParams.java

24 lines changed: 0 ins; 23 del; 1 mod; 333 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/share/classes/jdk/jpackage/internal/DeployParams.java

15 lines changed: 0 ins; 11 del; 4 mod; 436 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/share/classes/jdk/jpackage/internal/ValidOptions.java

4 lines changed: 1 ins; 3 del; 0 mod; 144 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/share/classes/jdk/jpackage/internal/resources/HelpResources.properties

35 lines changed: 5 ins; 14 del; 16 mod; 249 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/share/classes/jdk/jpackage/internal/resources/MainResources.properties

5 lines changed: 0 ins; 2 del; 3 mod; 83 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/share/classes/jdk/jpackage/internal/resources/MainResources_ja.properties

5 lines changed: 0 ins; 2 del; 3 mod; 83 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/share/classes/jdk/jpackage/internal/resources/MainResources_zh_CN.properties

5 lines changed: 0 ins; 2 del; 3 mod; 83 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/windows/classes/jdk/jpackage/internal/WinExeBundler.java

2 lines changed: 2 ins; 0 del; 0 mod; 157 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/windows/classes/jdk/jpackage/internal/WinMsiBundler.java

6 lines changed: 4 ins; 0 del; 2 mod; 1170 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/JPackageInvalidArgTest.java

1 line changed: 0 ins; 0 del; 1 mod; 82 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/JPackageMissingArgumentsTest.java

8 lines changed: 1 ins; 5 del; 2 mod; 160 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/createappimage/JPackageCreateAppImageAddLauncherModuleTest.java

1 line changed: 0 ins; 1 del; 0 mod; 51 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/createappimage/JPackageCreateAppImageAddLauncherTest.java

1 line changed: 0 ins; 1 del; 0 mod; 52 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/createappimage/JPackageCreateAppImageAddLaunchersTest.java

2 lines changed: 0 ins; 2 del; 0 mod; 81 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/createappimage/JPackageCreateAppImageAddModulesTest.java

3 lines changed: 0 ins; 3 del; 0 mod; 73 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/createappimage/JPackageCreateAppImageArgumentsModuleTest.java

1 line changed: 0 ins; 1 del; 0 mod; 51 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/createappimage/JPackageCreateAppImageArgumentsTest.java

1 line changed: 0 ins; 1 del; 0 mod; 52 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/createappimage/JPackageCreateAppImageAtFilenameTest.java

1 line changed: 0 ins; 1 del; 0 mod; 64 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/createappimage/JPackageCreateAppImageErrorTest.java

3 lines changed: 0 ins; 2 del; 1 mod; 95 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/createappimage/JPackageCreateAppImageIconTest.java

1 line changed: 0 ins; 1 del; 0 mod; 125 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/createappimage/JPackageCreateAppImageJLinkModuleTest.java

1 line changed: 0 ins; 1 del; 0 mod; 67 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/createappimage/JPackageCreateAppImageJavaOptionsEqualsTest.java

1 line changed: 0 ins; 1 del; 0 mod; 113 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/createappimage/JPackageCreateAppImageJavaOptionsModuleTest.java

2 lines changed: 0 ins; 2 del; 0 mod; 66 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/createappimage/JPackageCreateAppImageJavaOptionsTest.java

2 lines changed: 0 ins; 2 del; 0 mod; 67 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/createappimage/JPackageCreateAppImageMainClassAttributeTest.java

1 line changed: 0 ins; 1 del; 0 mod; 97 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/createappimage/JPackageCreateAppImageMainClassErrorTest.java

1 line changed: 0 ins; 1 del; 0 mod; 74 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/createappimage/JPackageCreateAppImageModularJarTest.java

2 lines changed: 0 ins; 2 del; 0 mod; 65 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/createappimage/JPackageCreateAppImageModuleMainClassErrorTest.java

2 lines changed: 0 ins; 2 del; 0 mod; 94 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/createappimage/JPackageCreateAppImageModulePathTest.java

3 lines changed: 0 ins; 3 del; 0 mod; 71 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/createappimage/JPackageCreateAppImageModuleTest.java

2 lines changed: 0 ins; 2 del; 0 mod; 74 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/createappimage/JPackageCreateAppImageNoNameTest.java

1 line changed: 0 ins; 1 del; 0 mod; 99 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/createappimage/JPackageCreateAppImageResourceTest.java

1 line changed: 0 ins; 1 del; 0 mod; 130 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/createappimage/JPackageCreateAppImageRuntimeModuleTest.java

1 line changed: 0 ins; 1 del; 0 mod; 51 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/createappimage/JPackageCreateAppImageRuntimeTest.java

1 line changed: 0 ins; 1 del; 0 mod; 53 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/createappimage/JPackageCreateAppImageTempRootTest.java

2 lines changed: 0 ins; 2 del; 0 mod; 106 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/createappimage/JPackageCreateAppImageTest.java

1 line changed: 0 ins; 1 del; 0 mod; 51 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/createappimage/JPackageCreateAppImageVerboseTest.java

2 lines changed: 0 ins; 2 del; 0 mod; 88 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/createappimage/JPackageCreateAppImageVersionTest.java

2 lines changed: 0 ins; 2 del; 0 mod; 100 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/createappimage/JPackageCreateAppImageWithSpaceTest.java

2 lines changed: 0 ins; 2 del; 0 mod; 68 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/createappimage/macosx/JPackageCreateAppImageBundleIdentifierTest.java

2 lines changed: 0 ins; 2 del; 0 mod; 157 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/createappimage/macosx/JPackageCreateAppImageBundleNameTest.java

2 lines changed: 0 ins; 2 del; 0 mod; 155 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/createappimage/windows/JPackageCreateAppImageWinConsoleTest.java

2 lines changed: 0 ins; 2 del; 0 mod; 136 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/createinstaller/linux/base/JPackageCreateInstallerBase.java

2 lines changed: 0 ins; 1 del; 1 mod; 88 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/createinstaller/linux/base/JPackageCreateInstallerBundleNameBase.java

2 lines changed: 0 ins; 1 del; 1 mod; 91 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/createinstaller/linux/base/JPackageCreateInstallerFileAssociationsBase.java

2 lines changed: 0 ins; 1 del; 1 mod; 154 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/createinstaller/linux/base/JPackageCreateInstallerInstallDirBase.java

2 lines changed: 0 ins; 1 del; 1 mod; 95 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/createinstaller/linux/base/JPackageCreateInstallerLicenseBase.java

2 lines changed: 0 ins; 1 del; 1 mod; 90 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/createinstaller/linux/base/JPackageCreateInstallerLicenseTypeBase.java

2 lines changed: 0 ins; 1 del; 1 mod; 112 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/createinstaller/linux/base/JPackageCreateInstallerMaintainerBase.java

2 lines changed: 0 ins; 1 del; 1 mod; 108 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/createinstaller/linux/base/JPackageCreateInstallerPackageDepsBase.java

4 lines changed: 0 ins; 2 del; 2 mod; 142 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/createinstaller/macosx/base/JPackageCreateInstallerBase.java

2 lines changed: 0 ins; 1 del; 1 mod; 82 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/createinstaller/macosx/base/JPackageCreateInstallerFileAssociationsBase.java

2 lines changed: 0 ins; 1 del; 1 mod; 148 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/createinstaller/macosx/base/JPackageCreateInstallerInstallDirBase.java

2 lines changed: 0 ins; 1 del; 1 mod; 83 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/createinstaller/macosx/base/JPackageCreateInstallerLicenseBase.java

2 lines changed: 0 ins; 1 del; 1 mod; 84 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/createinstaller/macosx/base/JPackageCreateInstallerMacOptionsBase.java

2 lines changed: 0 ins; 1 del; 1 mod; 173 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/createinstaller/windows/base/JPackageCreateInstallerBase.java

2 lines changed: 0 ins; 1 del; 1 mod; 90 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/createinstaller/windows/base/JPackageCreateInstallerFileAssociationsBase.java

4 lines changed: 0 ins; 2 del; 2 mod; 177 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/createinstaller/windows/base/JPackageCreateInstallerInstallDirBase.java

2 lines changed: 0 ins; 1 del; 1 mod; 100 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/createinstaller/windows/base/JPackageCreateInstallerLicenseBase.java

2 lines changed: 0 ins; 1 del; 1 mod; 91 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/createinstaller/windows/base/JPackageCreateInstallerRuntimeBase.java

2 lines changed: 0 ins; 1 del; 1 mod; 80 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/createinstaller/windows/base/JPackageCreateInstallerWinDirChooserBase.java

2 lines changed: 0 ins; 1 del; 1 mod; 91 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/createinstaller/windows/base/JPackageCreateInstallerWinMenuBase.java

2 lines changed: 0 ins; 1 del; 1 mod; 91 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/createinstaller/windows/base/JPackageCreateInstallerWinMenuGroupBase.java

2 lines changed: 0 ins; 1 del; 1 mod; 92 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/createinstaller/windows/base/JPackageCreateInstallerWinPerUserInstallBase.java

2 lines changed: 0 ins; 1 del; 1 mod; 93 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/createinstaller/windows/base/JPackageCreateInstallerWinRegistryNameBase.java

2 lines changed: 0 ins; 1 del; 1 mod; 169 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/createinstaller/windows/base/JPackageCreateInstallerWinShortcutBase.java

2 lines changed: 0 ins; 1 del; 1 mod; 97 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/createinstaller/windows/base/JPackageCreateInstallerWinUpgradeUUIDBase.java

4 lines changed: 0 ins; 2 del; 2 mod; 137 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/helpers/JPackageHelper.java

5 lines changed: 4 ins; 1 del; 0 mod; 629 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/jdk/jpackage/internal/DeployParamsTest.java

1 line changed: 1 ins; 0 del; 0 mod; 124 unchg

------ ------ ------ ------ Old --- Patch --- src/jdk.jpackage/share/classes/jdk/jpackage/internal/BundlerType.java

32 lines changed: 0 ins; 32 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/jdk.jpackage/windows/classes/jdk/jpackage/internal/WinExeBundler.java.html

240 lines changed: 0 ins; 240 del; 0 mod; 0 unchg

This code review page was prepared using /home/aherrick/bin/webrev.ksh (vers 25.17-hg+openjdk.java.net).