Code Review for jmc

Prepared by:hirt hirt on Tue May 28 15:38:25 DST 2019
Workspace:/mnt/c/Users/Marcus/hg/openjdk/jmc/jmc
Compare against: ssh://hg.openjdk.java.net/jmc/jmc
Summary of changes: 173 lines changed: 141 ins; 8 del; 24 mod; 8050 unchg
Patch of changes: jmc.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/org.openjdk.jmc.flightrecorder.ui/defaultPages.xml

16 lines changed: 12 ins; 0 del; 4 mod; 819 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/org.openjdk.jmc.flightrecorder.ui/plugin.xml

4 lines changed: 4 ins; 0 del; 0 mod; 317 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/JfrPropertySheet.java

1 line changed: 1 ins; 0 del; 0 mod; 727 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/common/DataPageToolkit.java

3 lines changed: 3 ins; 0 del; 0 mod; 1161 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/common/ImageConstants.java

1 line changed: 1 ins; 0 del; 0 mod; 134 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/messages/internal/Messages.java

2 lines changed: 1 ins; 1 del; 0 mod; 548 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/EventBrowserPage.java

3 lines changed: 0 ins; 3 del; 0 mod; 373 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/org.openjdk.jmc.flightrecorder.ui/src/main/resources/org/openjdk/jmc/flightrecorder/ui/messages/internal/messages.properties

1 line changed: 1 ins; 0 del; 0 mod; 600 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/latency/BiasedLockingRevocationRule.java

2 lines changed: 0 ins; 1 del; 1 mod; 323 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw core/org.openjdk.jmc.flightrecorder.rules/src/main/java/org/openjdk/jmc/flightrecorder/rules/util/JfrRuleTopics.java

7 lines changed: 6 ins; 1 del; 0 mod; 64 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/jdk/JdkAggregators.java

16 lines changed: 8 ins; 0 del; 8 mod; 444 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/jdk/JdkAttributes.java

14 lines changed: 7 ins; 0 del; 7 mod; 1208 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/jdk/JdkQueries.java

9 lines changed: 6 ins; 2 del; 1 mod; 234 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/jdk/JdkTypeIDs.java

2 lines changed: 2 ins; 0 del; 0 mod; 199 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/jdk/messages/internal/Messages.java

4 lines changed: 3 ins; 0 del; 1 mod; 460 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw core/org.openjdk.jmc.flightrecorder/src/main/resources/org/openjdk/jmc/flightrecorder/jdk/messages/internal/messages.properties

3 lines changed: 1 ins; 0 del; 2 mod; 439 unchg

------ ------ ------ ------ --- New Patch Raw application/org.openjdk.jmc.flightrecorder.ui/icons/pages/nativelibraries.png

Unexpected Error occurred reading `diff -e /dev/null new/application/org.openjdk.jmc.flightrecorder.ui/icons/pages/nativelibraries.png`: $?=0, err= 1

------ ------ ------ ------ --- New Patch Raw application/org.openjdk.jmc.flightrecorder.ui/icons/pages/nativelibraries@2x.png

Unexpected Error occurred reading `diff -e /dev/null new/application/org.openjdk.jmc.flightrecorder.ui/icons/pages/nativelibraries@2x.png`: $?=0, err= 1

------ ------ ------ ------ --- New Patch Raw application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/NativeLibraryPage.java

85 lines changed: 85 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /usr/local/bin/webrev.ksh (vers 25.17-hg+openjdk.java.net).