Code Review for jmc

Prepared by:hirt hirt on Fri Jun 21 17:10:49 DST 2019
Workspace:/mnt/c/Users/Marcus/hg/openjdk/jmc/jmc
Compare against: ssh://hg.openjdk.java.net/jmc/jmc
Summary of changes: 1069 lines changed: 937 ins; 26 del; 106 mod; 608 unchg
Patch of changes: jmc.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/org.openjdk.jmc.updatesite.ide/category.xml

119 lines changed: 0 ins; 21 del; 98 mod; 26 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/org.openjdk.jmc.updatesite.ide/feature.xml

4 lines changed: 4 ins; 0 del; 0 mod; 97 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/org.openjdk.jmc.updatesite.rcp/category.xml

13 lines changed: 5 ins; 0 del; 8 mod; 120 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/org.openjdk.jmc.updatesite.rcp/feature.xml

4 lines changed: 4 ins; 0 del; 0 mod; 77 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/pom.xml

2 lines changed: 2 ins; 0 del; 0 mod; 180 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/uitests/org.openjdk.jmc.console.uitest/src/test/java/org/openjdk/jmc/console/uitest/ConsolePreferencesTest.java

5 lines changed: 0 ins; 5 del; 0 mod; 108 unchg

------ ------ ------ ------ --- --- ----- --- configuration/ide/eclipse/launchers/JMC

Cdiffs Udiffs Sdiffs Frames --- --- ----- --- configuration/ide/eclipse/launchers/JMC

Cdiffs Udiffs Sdiffs Frames --- --- ----- --- configuration/ide/eclipse/launchers/JMC

Cdiffs Udiffs Sdiffs Frames --- --- ----- --- configuration/ide/eclipse/launchers/JMC

------ ------ ------ ------ --- New Patch Raw application/org.openjdk.jmc.feature.flightrecorder.ext.flameview/.project

23 lines changed: 23 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw application/org.openjdk.jmc.feature.flightrecorder.ext.flameview/build.properties

36 lines changed: 36 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw application/org.openjdk.jmc.feature.flightrecorder.ext.flameview/feature.properties

37 lines changed: 37 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw application/org.openjdk.jmc.feature.flightrecorder.ext.flameview/feature.xml

61 lines changed: 61 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw application/org.openjdk.jmc.feature.flightrecorder.ext.flameview/pom.xml

44 lines changed: 44 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw application/org.openjdk.jmc.flightrecorder.ext.flameview/.classpath

16 lines changed: 16 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw application/org.openjdk.jmc.flightrecorder.ext.flameview/.project

34 lines changed: 34 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw application/org.openjdk.jmc.flightrecorder.ext.flameview/.settings/org.eclipse.jdt.core.prefs

13 lines changed: 13 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw application/org.openjdk.jmc.flightrecorder.ext.flameview/.settings/org.eclipse.m2e.core.prefs

4 lines changed: 4 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw application/org.openjdk.jmc.flightrecorder.ext.flameview/META-INF/MANIFEST.MF

10 lines changed: 10 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw application/org.openjdk.jmc.flightrecorder.ext.flameview/build.properties

8 lines changed: 8 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw application/org.openjdk.jmc.flightrecorder.ext.flameview/icons/flame.png

Unexpected Error occurred reading `diff -e /dev/null new/application/org.openjdk.jmc.flightrecorder.ext.flameview/icons/flame.png`: $?=0, err= 1

------ ------ ------ ------ --- New Patch Raw application/org.openjdk.jmc.flightrecorder.ext.flameview/icons/flame@2x.png

Unexpected Error occurred reading `diff -e /dev/null new/application/org.openjdk.jmc.flightrecorder.ext.flameview/icons/flame@2x.png`: $?=0, err= 1

------ ------ ------ ------ --- New Patch Raw application/org.openjdk.jmc.flightrecorder.ext.flameview/plugin.properties

33 lines changed: 33 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw application/org.openjdk.jmc.flightrecorder.ext.flameview/plugin.xml

47 lines changed: 47 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw application/org.openjdk.jmc.flightrecorder.ext.flameview/pom.xml

44 lines changed: 44 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw application/org.openjdk.jmc.flightrecorder.ext.flameview/src/main/java/org/openjdk/jmc/flightrecorder/ext/flameview/tree/TraceNode.java

101 lines changed: 101 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw application/org.openjdk.jmc.flightrecorder.ext.flameview/src/main/java/org/openjdk/jmc/flightrecorder/ext/flameview/tree/TraceTreeUtils.java

123 lines changed: 123 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw application/org.openjdk.jmc.flightrecorder.ext.flameview/src/main/java/org/openjdk/jmc/flightrecorder/ext/flameview/views/FlameGraphView.java

240 lines changed: 240 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw application/org.openjdk.jmc.flightrecorder.ext.flameview/src/main/java/org/openjdk/jmc/flightrecorder/ext/flameview/views/page.html

48 lines changed: 48 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /usr/local/bin/webrev.ksh (vers 25.17-hg+openjdk.java.net).