Code Review for jmc

Prepared by:hirt hirt on Tue Dec 18 16:00:40 CET 2018
Workspace:/Users/marcus/hg/openjdk/jmc
Compare against: ssh://hg.openjdk.java.net/jmc/jmc
Summary of changes: 172 lines changed: 165 ins; 2 del; 5 mod; 847 unchg
Patch of changes: jmc.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw core/org.openjdk.jmc.flightrecorder/META-INF/MANIFEST.MF

2 lines changed: 1 ins; 0 del; 1 mod; 18 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/internal/parser/v1/ChunkLoaderV1.java

5 lines changed: 1 ins; 2 del; 2 mod; 125 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/util/ChunkReader.java

4 lines changed: 4 ins; 0 del; 0 mod; 377 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw core/tests/org.openjdk.jmc.common.test/src/test/java/org/openjdk/jmc/common/test/TestToolkit.java

8 lines changed: 8 ins; 0 del; 0 mod; 231 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw core/tests/org.openjdk.jmc.flightrecorder.test/src/test/java/org/openjdk/jmc/flightrecorder/test/util/RecordingToolkit.java

16 lines changed: 14 ins; 0 del; 2 mod; 96 unchg

------ ------ ------ ------ --- New Patch Raw core/tests/org.openjdk.jmc.flightrecorder.test/src/test/java/org/openjdk/jmc/flightrecorder/test/MetadataEventLocationUpdateTest.java

137 lines changed: 137 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw core/tests/org.openjdk.jmc.flightrecorder.test/src/test/resources/recordings/flush_incremental_metadata.jfr

Unexpected Error occurred reading `diff -e /dev/null new/core/tests/org.openjdk.jmc.flightrecorder.test/src/test/resources/recordings/flush_incremental_metadata.jfr`: $?=0, err= 1

------ ------ ------ ------ --- New Patch Raw core/tests/org.openjdk.jmc.flightrecorder.test/src/test/resources/recordings/flush_metadata.jfr

Unexpected Error occurred reading `diff -e /dev/null new/core/tests/org.openjdk.jmc.flightrecorder.test/src/test/resources/recordings/flush_metadata.jfr`: $?=0, err= 1

------ ------ ------ ------ --- New Patch Raw core/tests/org.openjdk.jmc.flightrecorder.test/src/test/resources/recordings/metadata_control.jfr

Unexpected Error occurred reading `diff -e /dev/null new/core/tests/org.openjdk.jmc.flightrecorder.test/src/test/resources/recordings/metadata_control.jfr`: $?=0, err= 1

------ ------ ------ ------ --- New Patch Raw core/tests/org.openjdk.jmc.flightrecorder.test/src/test/resources/recordings/metadata_new.jfr

Unexpected Error occurred reading `diff -e /dev/null new/core/tests/org.openjdk.jmc.flightrecorder.test/src/test/resources/recordings/metadata_new.jfr`: $?=0, err= 1

This code review page was prepared using /usr/local/bin/webrev.ksh (vers 25.17-hg+openjdk.java.net).