Code Review for jmc

Prepared by:hirt hirt on Mon Jan 7 20:04:35 CET 2019
Workspace:/Users/marcus/hg/openjdk/jmc
Compare against: ssh://hg.openjdk.java.net/jmc/jmc
Summary of changes: 156 lines changed: 79 ins; 18 del; 59 mod; 7561 unchg
Patch of changes: jmc.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/org.openjdk.jmc.browser.attach/src/main/java/org/openjdk/jmc/browser/attach/LocalJVMToolkit.java

1 line changed: 0 ins; 0 del; 1 mod; 579 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/org.openjdk.jmc.flightrecorder.ext.g1/pages.xml

1 line changed: 0 ins; 0 del; 1 mod; 38 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/org.openjdk.jmc.flightrecorder.ext.jfx/pages.xml

1 line changed: 0 ins; 0 del; 1 mod; 57 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/org.openjdk.jmc.flightrecorder.ext.jfx/src/main/java/org/openjdk/jmc/flightrecorder/ext/jfx/JfxConstants.java

19 lines changed: 6 ins; 4 del; 9 mod; 59 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/org.openjdk.jmc.flightrecorder.ext.jfx/src/main/java/org/openjdk/jmc/flightrecorder/ext/jfx/JfxPage.java

23 lines changed: 10 ins; 6 del; 7 mod; 404 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/org.openjdk.jmc.flightrecorder.ext.jfx/src/main/java/org/openjdk/jmc/flightrecorder/ext/jfx/JfxPulseDurationRule.java

13 lines changed: 6 ins; 1 del; 6 mod; 127 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/org.openjdk.jmc.flightrecorder.ext.jfx/src/main/java/org/openjdk/jmc/flightrecorder/ext/jfx/Messages.java

1 line changed: 0 ins; 0 del; 1 mod; 64 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/org.openjdk.jmc.flightrecorder.ext.jfx/src/main/resources/org/openjdk/jmc/flightrecorder/ext/jfx/messages.properties

1 line changed: 0 ins; 0 del; 1 mod; 51 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/org.openjdk.jmc.flightrecorder.metadata/pages.xml

1 line changed: 1 ins; 0 del; 0 mod; 48 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/DataPageDescriptor.java

5 lines changed: 4 ins; 0 del; 1 mod; 159 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/common/DataPageToolkit.java

1 line changed: 0 ins; 0 del; 1 mod; 1128 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/overview/ResultReportUi.java

7 lines changed: 0 ins; 0 del; 7 mod; 448 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/ClassLoadingPage.java

5 lines changed: 0 ins; 5 del; 0 mod; 562 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/GarbageCollectionsPage.java

2 lines changed: 0 ins; 1 del; 1 mod; 757 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/org.openjdk.jmc.rjmx/src/main/java/org/openjdk/jmc/rjmx/services/internal/HotSpot24DiagnosticCommandService.java

1 line changed: 0 ins; 0 del; 1 mod; 353 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/org.openjdk.jmc.ui/src/main/java/org/openjdk/jmc/ui/charts/XYDataRenderer.java

1 line changed: 0 ins; 1 del; 0 mod; 301 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/org.openjdk.jmc.ui/src/main/java/org/openjdk/jmc/ui/misc/AwtCanvas.java

2 lines changed: 0 ins; 0 del; 2 mod; 106 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/general/DuplicateFlagsRule.java

1 line changed: 0 ins; 0 del; 1 mod; 129 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/latency/MethodProfilingRule.java

4 lines changed: 0 ins; 0 del; 4 mod; 551 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/jdk/JdkAttributes.java

11 lines changed: 0 ins; 0 del; 11 mod; 1183 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/jdk/messages/internal/Messages.java

3 lines changed: 0 ins; 0 del; 3 mod; 457 unchg

------ ------ ------ ------ --- New Patch Raw application/org.openjdk.jmc.flightrecorder.ext.jfx/src/main/java/org/openjdk/jmc/flightrecorder/ext/jfx/JfxVersionUtil.java

52 lines changed: 52 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /usr/local/bin/webrev.ksh (vers 25.17-hg+openjdk.java.net).