Code Review for open

Prepared by:hseigel on Fri May 29 21:09:17 GMT 2020
Workspace:/scratch/hseigel/sealedClassHgRepo/open
Compare against: http://hg.openjdk.java.net/jdk/jdk/
Summary of changes: 3543 lines changed: 3457 ins; 5 del; 81 mod; 62994 unchg
Patch of changes: open.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/autoconf/spec.gmk.in

1 line changed: 1 ins; 0 del; 0 mod; 943 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/data/jdwp/jdwp.spec

2 lines changed: 0 ins; 0 del; 2 mod; 3293 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/hotspot/symbols/symbols-unix

1 line changed: 1 ins; 0 del; 0 mod; 197 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/classFileParser.cpp

129 lines changed: 122 ins; 5 del; 2 mod; 6602 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/classFileParser.hpp

6 lines changed: 6 ins; 0 del; 0 mod; 587 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/vmSymbols.hpp

1 line changed: 1 ins; 0 del; 0 mod; 1700 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/include/jvm.h

5 lines changed: 5 ins; 0 del; 0 mod; 1245 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/logging/logTag.hpp

1 line changed: 1 ins; 0 del; 0 mod; 233 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/instanceKlass.cpp

67 lines changed: 67 ins; 0 del; 0 mod; 4090 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/instanceKlass.hpp

14 lines changed: 14 ins; 0 del; 0 mod; 1478 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/prims/jvm.cpp

28 lines changed: 27 ins; 0 del; 1 mod; 3874 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/prims/jvmti.xml

10 lines changed: 7 ins; 0 del; 3 mod; 15047 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/prims/jvmtiClassFileReconstituter.cpp

26 lines changed: 26 ins; 0 del; 0 mod; 1019 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/prims/jvmtiClassFileReconstituter.hpp

1 line changed: 1 ins; 0 del; 0 mod; 147 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/prims/jvmtiRedefineClasses.cpp

84 lines changed: 84 ins; 0 del; 0 mod; 4474 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/prims/jvmtiRedefineClasses.hpp

1 line changed: 1 ins; 0 del; 0 mod; 562 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/Class.java

64 lines changed: 64 ins; 0 del; 0 mod; 4385 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/PreviewFeature.java

1 line changed: 1 ins; 0 del; 0 mod; 68 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/org/objectweb/asm/ClassReader.java

12 lines changed: 0 ins; 0 del; 12 mod; 3844 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/org/objectweb/asm/ClassVisitor.java

6 lines changed: 0 ins; 0 del; 6 mod; 407 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/org/objectweb/asm/ClassWriter.java

20 lines changed: 0 ins; 0 del; 20 mod; 1071 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/org/objectweb/asm/Constants.java

1 line changed: 0 ins; 0 del; 1 mod; 251 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/org/objectweb/asm/commons/ClassRemapper.java

3 lines changed: 0 ins; 0 del; 3 mod; 316 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/org/objectweb/asm/tree/ClassNode.java

10 lines changed: 0 ins; 0 del; 10 mod; 492 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/org/objectweb/asm/util/ASMifier.java

4 lines changed: 0 ins; 0 del; 4 mod; 1643 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/org/objectweb/asm/util/CheckClassAdapter.java

4 lines changed: 0 ins; 0 del; 4 mod; 1154 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/org/objectweb/asm/util/Printer.java

4 lines changed: 0 ins; 0 del; 4 mod; 1347 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/org/objectweb/asm/util/Textifier.java

4 lines changed: 0 ins; 0 del; 4 mod; 1636 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/org/objectweb/asm/util/TraceClassVisitor.java

4 lines changed: 0 ins; 0 del; 4 mod; 279 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/native/libjava/Class.c

1 line changed: 1 ins; 0 del; 0 mod; 192 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.instrument/share/native/libinstrument/JavaExceptions.c

1 line changed: 0 ins; 0 del; 1 mod; 418 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/runtime/modules/SealedModuleTest.java

95 lines changed: 95 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/runtime/modules/TEST.properties

23 lines changed: 23 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/runtime/modules/sealedP1/C1.java

30 lines changed: 30 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/runtime/modules/sealedP1/SuperClass.jcod

105 lines changed: 105 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/runtime/modules/sealedP2/C2.java

29 lines changed: 29 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/runtime/modules/sealedP3/C3.java

29 lines changed: 29 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/runtime/sealedClasses/AbstractSealedTest.java

45 lines changed: 45 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/runtime/sealedClasses/GetPermittedSubclasses.jcod

560 lines changed: 560 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/runtime/sealedClasses/GetPermittedSubclassesTest.java

138 lines changed: 138 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/runtime/sealedClasses/OverrideSealedTest.java

73 lines changed: 73 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/runtime/sealedClasses/Pkg/NotPermitted.jcod

95 lines changed: 95 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/runtime/sealedClasses/Pkg/Permitted.java

26 lines changed: 26 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/runtime/sealedClasses/Pkg/SealedInterface.jcod

72 lines changed: 72 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/runtime/sealedClasses/RedefineSealedClass.java

112 lines changed: 112 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/runtime/sealedClasses/SealedTest.java

49 lines changed: 49 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/runtime/sealedClasses/SealedUnnamedModuleIntfTest.java

59 lines changed: 59 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/runtime/sealedClasses/SealedUnnamedModuleTest.java

65 lines changed: 65 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/runtime/sealedClasses/TEST.properties

23 lines changed: 23 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/runtime/sealedClasses/asteroids/Pluto.java

27 lines changed: 27 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/runtime/sealedClasses/otherPkg/WrongPackage.java

26 lines changed: 26 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/runtime/sealedClasses/planets/Mars.jcod

92 lines changed: 92 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/runtime/sealedClasses/planets/Neptune.java

26 lines changed: 26 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/runtime/sealedClasses/planets/OuterPlanets.jcod

98 lines changed: 98 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/instrument/RedefinePermittedSubclassesAttr/ClassFour.java

24 lines changed: 24 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/instrument/RedefinePermittedSubclassesAttr/ClassOne.java

24 lines changed: 24 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/instrument/RedefinePermittedSubclassesAttr/ClassThree.java

24 lines changed: 24 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/instrument/RedefinePermittedSubclassesAttr/ClassTwo.java

24 lines changed: 24 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/instrument/RedefinePermittedSubclassesAttr/Host/Host.java

29 lines changed: 29 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/instrument/RedefinePermittedSubclassesAttr/Host/redef/Host.java

29 lines changed: 29 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/instrument/RedefinePermittedSubclassesAttr/HostA/Host.java

29 lines changed: 29 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/instrument/RedefinePermittedSubclassesAttr/HostA/redef/Host.java

29 lines changed: 29 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/instrument/RedefinePermittedSubclassesAttr/HostAB/Host.java

29 lines changed: 29 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/instrument/RedefinePermittedSubclassesAttr/HostAB/redef/Host.java

29 lines changed: 29 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/instrument/RedefinePermittedSubclassesAttr/HostABC/Host.java

29 lines changed: 29 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/instrument/RedefinePermittedSubclassesAttr/HostABC/redef/Host.java

29 lines changed: 29 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/instrument/RedefinePermittedSubclassesAttr/HostABCD/redef/Host.java

29 lines changed: 29 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/instrument/RedefinePermittedSubclassesAttr/HostABD/redef/Host.java

29 lines changed: 29 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/instrument/RedefinePermittedSubclassesAttr/HostAC/redef/Host.java

29 lines changed: 29 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/instrument/RedefinePermittedSubclassesAttr/HostACB/redef/Host.java

29 lines changed: 29 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/instrument/RedefinePermittedSubclassesAttr/HostB/redef/Host.java

29 lines changed: 29 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/instrument/RedefinePermittedSubclassesAttr/HostBA/redef/Host.java

29 lines changed: 29 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/instrument/RedefinePermittedSubclassesAttr/HostBAC/redef/Host.java

29 lines changed: 29 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/instrument/RedefinePermittedSubclassesAttr/HostBCA/redef/Host.java

29 lines changed: 29 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/instrument/RedefinePermittedSubclassesAttr/HostCAB/redef/Host.java

29 lines changed: 29 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/instrument/RedefinePermittedSubclassesAttr/HostCBA/redef/Host.java

29 lines changed: 29 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/instrument/RedefinePermittedSubclassesAttr/TestPermittedSubclassesAttr.java

273 lines changed: 273 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/reflect/sealed_classes/SealedClassesReflectionTest.java

239 lines changed: 239 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /home/hseigel/bin/webrev.ksh (vers 25.16-hg+openjdk.java.net).