# HG changeset patch # User igerasim # Date 1536990193 25200 # Fri Sep 14 22:43:13 2018 -0700 # Node ID 76fcf70a0299824fde7f0ab87a7327e1d413c9d0 # Parent 6c394ed56b07d453226e064bc011528cd89b7d69 [mq]: 8210787-Object-wait-long-int-throws-inappropriate-IllegalArgumentException diff --git a/src/java.base/share/classes/java/lang/Object.java b/src/java.base/share/classes/java/lang/Object.java --- a/src/java.base/share/classes/java/lang/Object.java +++ b/src/java.base/share/classes/java/lang/Object.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 1994, 2017, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 1994, 2018, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -455,7 +455,7 @@ "nanosecond timeout value out of range"); } - if (nanos > 0) { + if (nanos > 0 && timeoutMillis < Long.MAX_VALUE) { timeoutMillis++; } diff --git a/test/jdk/java/lang/Object/WaitTooLong.java b/test/jdk/java/lang/Object/WaitTooLong.java new file mode 100644 --- /dev/null +++ b/test/jdk/java/lang/Object/WaitTooLong.java @@ -0,0 +1,46 @@ +/* + * Copyright (c) 2018, Oracle and/or its affiliates. All rights reserved. + * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. + * + * This code is free software; you can redistribute it and/or modify it + * under the terms of the GNU General Public License version 2 only, as + * published by the Free Software Foundation. + * + * This code is distributed in the hope that it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License + * version 2 for more details (a copy is included in the LICENSE file that + * accompanied this code). + * + * You should have received a copy of the GNU General Public License version + * 2 along with this work; if not, write to the Free Software Foundation, + * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. + * + * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA + * or visit www.oracle.com if you need additional information or have any + * questions. + */ + +/* + * @test + * @bug 8210787 + * @summary Object.wait(long, int) throws inappropriate IllegalArgumentException + */ + +public class WaitTooLong { + public static void main(String[] args) { + test(0); + test(1); + test(500000); + test(999999); + } + + static void test(int nanos) { + try { + WaitTooLong.class.wait(Long.MAX_VALUE, nanos); + } catch (IllegalMonitorStateException expected) { + } catch (IllegalArgumentException | InterruptedException unexpected) { + throw new RuntimeException("Unexpected", unexpected); + } + } +}