Code Review for open

Prepared by:igerasim on Tue Nov 26 18:25:52 PST 2019
Workspace:/home/igerasim/JDK/jdk-dev/open
Compare against: ssh://hg.openjdk.java.net/jdk/jdk
Compare against version:57115
Summary of changes: 323 lines changed: 83 ins; 116 del; 124 mod; 38329 unchg
Changeset: open.changeset
Bug id: JDK-8234147 : Avoid looking up standard charsets in core libraries
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.base/share/classes/com/sun/java/util/jar/pack/Driver.java

rev 57116 : imported patch 8234147-Avoid-looking-up-standard-charsets-in-core-libraries
4 lines changed: 2 ins; 0 del; 2 mod; 746 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.base/share/classes/com/sun/security/ntlm/NTLM.java

rev 57116 : imported patch 8234147-Avoid-looking-up-standard-charsets-in-core-libraries
46 lines changed: 5 ins; 25 del; 16 mod; 389 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.base/share/classes/java/io/InputStreamReader.java

rev 57116 : imported patch 8234147-Avoid-looking-up-standard-charsets-in-core-libraries
6 lines changed: 0 ins; 4 del; 2 mod; 196 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.base/share/classes/java/io/OutputStreamWriter.java

rev 57116 : imported patch 8234147-Avoid-looking-up-standard-charsets-in-core-libraries
5 lines changed: 0 ins; 3 del; 2 mod; 255 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.base/share/classes/java/lang/CharacterName.java

rev 57116 : imported patch 8234147-Avoid-looking-up-standard-charsets-in-core-libraries
2 lines changed: 0 ins; 0 del; 2 mod; 178 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.base/share/classes/java/net/InetAddress.java

rev 57116 : imported patch 8234147-Avoid-looking-up-standard-charsets-in-core-libraries
10 lines changed: 5 ins; 1 del; 4 mod; 1754 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.base/share/classes/java/net/SocksSocketImpl.java

rev 57116 : imported patch 8234147-Avoid-looking-up-standard-charsets-in-core-libraries
21 lines changed: 1 ins; 16 del; 4 mod; 568 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.base/share/classes/java/net/URI.java

rev 57116 : imported patch 8234147-Avoid-looking-up-standard-charsets-in-core-libraries
5 lines changed: 1 ins; 1 del; 3 mod; 3635 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.base/share/classes/java/nio/charset/StandardCharsets.java

rev 57116 : imported patch 8234147-Avoid-looking-up-standard-charsets-in-core-libraries
1 line changed: 0 ins; 0 del; 1 mod; 76 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.base/share/classes/java/nio/file/FileChannelLinesSpliterator.java

rev 57116 : imported patch 8234147-Avoid-looking-up-standard-charsets-in-core-libraries
9 lines changed: 4 ins; 1 del; 4 mod; 262 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.base/share/classes/java/nio/file/Files.java

rev 57116 : imported patch 8234147-Avoid-looking-up-standard-charsets-in-core-libraries
8 lines changed: 1 ins; 0 del; 7 mod; 4186 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.base/share/classes/java/util/Base64.java

rev 57116 : imported patch 8234147-Avoid-looking-up-standard-charsets-in-core-libraries
4 lines changed: 3 ins; 0 del; 1 mod; 1100 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.base/share/classes/java/util/Properties.java

rev 57116 : imported patch 8234147-Avoid-looking-up-standard-charsets-in-core-libraries
3 lines changed: 2 ins; 0 del; 1 mod; 1572 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.base/share/classes/java/util/PropertyResourceBundle.java

rev 57116 : imported patch 8234147-Avoid-looking-up-standard-charsets-in-core-libraries
3 lines changed: 1 ins; 1 del; 1 mod; 240 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.base/share/classes/java/util/ServiceLoader.java

rev 57116 : imported patch 8234147-Avoid-looking-up-standard-charsets-in-core-libraries
4 lines changed: 2 ins; 1 del; 1 mod; 1847 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.base/share/classes/java/util/jar/Attributes.java

rev 57116 : imported patch 8234147-Avoid-looking-up-standard-charsets-in-core-libraries
7 lines changed: 1 ins; 1 del; 5 mod; 751 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.base/share/classes/java/util/jar/Manifest.java

rev 57116 : imported patch 8234147-Avoid-looking-up-standard-charsets-in-core-libraries
10 lines changed: 1 ins; 6 del; 3 mod; 560 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.base/share/classes/java/util/zip/ZipCoder.java

rev 57116 : imported patch 8234147-Avoid-looking-up-standard-charsets-in-core-libraries
4 lines changed: 0 ins; 0 del; 4 mod; 148 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.base/share/classes/java/util/zip/ZipFile.java

rev 57116 : imported patch 8234147-Avoid-looking-up-standard-charsets-in-core-libraries
4 lines changed: 1 ins; 1 del; 2 mod; 1572 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.base/share/classes/java/util/zip/ZipInputStream.java

rev 57116 : imported patch 8234147-Avoid-looking-up-standard-charsets-in-core-libraries
4 lines changed: 2 ins; 0 del; 2 mod; 423 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.base/share/classes/java/util/zip/ZipOutputStream.java

rev 57116 : imported patch 8234147-Avoid-looking-up-standard-charsets-in-core-libraries
3 lines changed: 1 ins; 1 del; 1 mod; 808 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.base/share/classes/jdk/internal/module/IllegalAccessMaps.java

rev 57116 : imported patch 8234147-Avoid-looking-up-standard-charsets-in-core-libraries
8 lines changed: 4 ins; 2 del; 2 mod; 124 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.base/share/classes/jdk/internal/module/ModulePath.java

rev 57116 : imported patch 8234147-Avoid-looking-up-standard-charsets-in-core-libraries
4 lines changed: 2 ins; 0 del; 2 mod; 785 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.base/share/classes/jdk/internal/perf/Perf.java

rev 57116 : imported patch 8234147-Avoid-looking-up-standard-charsets-in-core-libraries
24 lines changed: 2 ins; 18 del; 4 mod; 525 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.base/share/classes/jdk/internal/util/jar/JarIndex.java

rev 57116 : imported patch 8234147-Avoid-looking-up-standard-charsets-in-core-libraries
6 lines changed: 3 ins; 0 del; 3 mod; 332 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.base/share/classes/jdk/internal/util/xml/XMLStreamWriter.java

rev 57116 : imported patch 8234147-Avoid-looking-up-standard-charsets-in-core-libraries
3 lines changed: 0 ins; 0 del; 3 mod; 155 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.base/share/classes/sun/net/www/ParseUtil.java

rev 57116 : imported patch 8234147-Avoid-looking-up-standard-charsets-in-core-libraries
5 lines changed: 2 ins; 0 del; 3 mod; 705 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.base/share/classes/sun/net/www/http/ChunkedInputStream.java

rev 57116 : imported patch 8234147-Avoid-looking-up-standard-charsets-in-core-libraries
12 lines changed: 6 ins; 3 del; 3 mod; 774 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.base/share/classes/sun/net/www/http/ChunkedOutputStream.java

rev 57116 : imported patch 8234147-Avoid-looking-up-standard-charsets-in-core-libraries
17 lines changed: 2 ins; 5 del; 10 mod; 285 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.base/share/classes/sun/net/www/protocol/http/BasicAuthentication.java

rev 57116 : imported patch 8234147-Avoid-looking-up-standard-charsets-in-core-libraries
5 lines changed: 1 ins; 0 del; 4 mod; 192 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.base/share/classes/sun/net/www/protocol/http/DigestAuthentication.java

rev 57116 : imported patch 8234147-Avoid-looking-up-standard-charsets-in-core-libraries
13 lines changed: 5 ins; 7 del; 1 mod; 539 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.base/share/classes/sun/nio/cs/StandardCharsets.java.template

rev 57116 : imported patch 8234147-Avoid-looking-up-standard-charsets-in-core-libraries
3 lines changed: 2 ins; 0 del; 1 mod; 200 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.base/share/classes/sun/nio/cs/ThreadLocalCoders.java

rev 57116 : imported patch 8234147-Avoid-looking-up-standard-charsets-in-core-libraries
17 lines changed: 8 ins; 8 del; 1 mod; 127 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.base/share/classes/sun/nio/cs/UTF_16LE.java

rev 57116 : imported patch 8234147-Avoid-looking-up-standard-charsets-in-core-libraries
4 lines changed: 1 ins; 0 del; 3 mod; 62 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.base/share/classes/sun/util/PropertyResourceBundleCharset.java

rev 57116 : imported patch 8234147-Avoid-looking-up-standard-charsets-in-core-libraries
6 lines changed: 3 ins; 0 del; 3 mod; 102 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.base/unix/classes/sun/nio/fs/UnixFileStore.java

rev 57116 : imported patch 8234147-Avoid-looking-up-standard-charsets-in-core-libraries
3 lines changed: 2 ins; 0 del; 1 mod; 285 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.net.http/share/classes/jdk/internal/net/http/common/Utils.java

rev 57116 : imported patch 8234147-Avoid-looking-up-standard-charsets-in-core-libraries
11 lines changed: 1 ins; 7 del; 3 mod; 1122 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.prefs/share/classes/java/util/prefs/XmlSupport.java

rev 57116 : imported patch 8234147-Avoid-looking-up-standard-charsets-in-core-libraries
4 lines changed: 2 ins; 0 del; 2 mod; 418 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.sql.rowset/share/classes/com/sun/rowset/CachedRowSetImpl.java

rev 57116 : imported patch 8234147-Avoid-looking-up-standard-charsets-in-core-libraries
11 lines changed: 2 ins; 4 del; 5 mod; 10132 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/jdk/java/lang/reflect/AccessibleObject/TrySetAccessibleTest.java

rev 57116 : imported patch 8234147-Avoid-looking-up-standard-charsets-in-core-libraries
4 lines changed: 2 ins; 0 del; 2 mod; 199 unchg

This code review page was prepared using /home/igerasim/bin/webrev (vers 25.16-hg+openjdk.java.net).