Code Review for open

Prepared by:ihse on Thu Mar 15 02:00:55 CET 2018
Workspace:/localhome/hg/jdk-GAH/open
Summary of changes: 139 lines changed: 59 ins; 60 del; 20 mod; 13147 unchg
Patch of changes: open.patch
Bug id: JDK-8071469 : Cleanup include and exclude of sound native libraries after source code restructure
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/lib/SoundLibraries.gmk

139 lines changed: 59 ins; 60 del; 20 mod; 118 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/java.desktop/bsd/native/libjsound/PLATFORM_API_BsdOS_ALSA_CommonUtils.c (was src/java.desktop/unix/native/libjsound/PLATFORM_API_BsdOS_ALSA_CommonUtils.c)

0 lines changed: 0 ins; 0 del; 0 mod; 182 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/java.desktop/bsd/native/libjsound/PLATFORM_API_BsdOS_ALSA_CommonUtils.h (was src/java.desktop/unix/native/libjsound/PLATFORM_API_BsdOS_ALSA_CommonUtils.h)

0 lines changed: 0 ins; 0 del; 0 mod; 82 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/java.desktop/bsd/native/libjsound/PLATFORM_API_BsdOS_ALSA_MidiIn.c (was src/java.desktop/unix/native/libjsound/PLATFORM_API_BsdOS_ALSA_MidiIn.c)

0 lines changed: 0 ins; 0 del; 0 mod; 354 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/java.desktop/bsd/native/libjsound/PLATFORM_API_BsdOS_ALSA_MidiOut.c (was src/java.desktop/unix/native/libjsound/PLATFORM_API_BsdOS_ALSA_MidiOut.c)

0 lines changed: 0 ins; 0 del; 0 mod; 179 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/java.desktop/bsd/native/libjsound/PLATFORM_API_BsdOS_ALSA_MidiUtils.c (was src/java.desktop/unix/native/libjsound/PLATFORM_API_BsdOS_ALSA_MidiUtils.c)

0 lines changed: 0 ins; 0 del; 0 mod; 481 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/java.desktop/bsd/native/libjsound/PLATFORM_API_BsdOS_ALSA_MidiUtils.h (was src/java.desktop/unix/native/libjsound/PLATFORM_API_BsdOS_ALSA_MidiUtils.h)

0 lines changed: 0 ins; 0 del; 0 mod; 85 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/java.desktop/bsd/native/libjsound/PLATFORM_API_BsdOS_ALSA_PCM.c (was src/java.desktop/unix/native/libjsound/PLATFORM_API_BsdOS_ALSA_PCM.c)

0 lines changed: 0 ins; 0 del; 0 mod; 941 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/java.desktop/bsd/native/libjsound/PLATFORM_API_BsdOS_ALSA_PCMUtils.c (was src/java.desktop/unix/native/libjsound/PLATFORM_API_BsdOS_ALSA_PCMUtils.c)

0 lines changed: 0 ins; 0 del; 0 mod; 292 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/java.desktop/bsd/native/libjsound/PLATFORM_API_BsdOS_ALSA_PCMUtils.h (was src/java.desktop/unix/native/libjsound/PLATFORM_API_BsdOS_ALSA_PCMUtils.h)

0 lines changed: 0 ins; 0 del; 0 mod; 73 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/java.desktop/bsd/native/libjsound/PLATFORM_API_BsdOS_ALSA_Ports.c (was src/java.desktop/unix/native/libjsound/PLATFORM_API_BsdOS_ALSA_Ports.c)

0 lines changed: 0 ins; 0 del; 0 mod; 724 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/java.desktop/linux/native/libjsoundalsa/PLATFORM_API_LinuxOS_ALSA_CommonUtils.c (was src/java.desktop/unix/native/libjsound/PLATFORM_API_LinuxOS_ALSA_CommonUtils.c)

0 lines changed: 0 ins; 0 del; 0 mod; 187 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/java.desktop/linux/native/libjsoundalsa/PLATFORM_API_LinuxOS_ALSA_CommonUtils.h (was src/java.desktop/unix/native/libjsound/PLATFORM_API_LinuxOS_ALSA_CommonUtils.h)

0 lines changed: 0 ins; 0 del; 0 mod; 82 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/java.desktop/linux/native/libjsoundalsa/PLATFORM_API_LinuxOS_ALSA_MidiIn.c (was src/java.desktop/unix/native/libjsound/PLATFORM_API_LinuxOS_ALSA_MidiIn.c)

0 lines changed: 0 ins; 0 del; 0 mod; 354 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/java.desktop/linux/native/libjsoundalsa/PLATFORM_API_LinuxOS_ALSA_MidiOut.c (was src/java.desktop/unix/native/libjsound/PLATFORM_API_LinuxOS_ALSA_MidiOut.c)

0 lines changed: 0 ins; 0 del; 0 mod; 179 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/java.desktop/linux/native/libjsoundalsa/PLATFORM_API_LinuxOS_ALSA_MidiUtils.c (was src/java.desktop/unix/native/libjsound/PLATFORM_API_LinuxOS_ALSA_MidiUtils.c)

0 lines changed: 0 ins; 0 del; 0 mod; 481 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/java.desktop/linux/native/libjsoundalsa/PLATFORM_API_LinuxOS_ALSA_MidiUtils.h (was src/java.desktop/unix/native/libjsound/PLATFORM_API_LinuxOS_ALSA_MidiUtils.h)

0 lines changed: 0 ins; 0 del; 0 mod; 85 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/java.desktop/linux/native/libjsoundalsa/PLATFORM_API_LinuxOS_ALSA_PCM.c (was src/java.desktop/unix/native/libjsound/PLATFORM_API_LinuxOS_ALSA_PCM.c)

0 lines changed: 0 ins; 0 del; 0 mod; 941 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/java.desktop/linux/native/libjsoundalsa/PLATFORM_API_LinuxOS_ALSA_PCMUtils.c (was src/java.desktop/unix/native/libjsound/PLATFORM_API_LinuxOS_ALSA_PCMUtils.c)

0 lines changed: 0 ins; 0 del; 0 mod; 292 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/java.desktop/linux/native/libjsoundalsa/PLATFORM_API_LinuxOS_ALSA_PCMUtils.h (was src/java.desktop/unix/native/libjsound/PLATFORM_API_LinuxOS_ALSA_PCMUtils.h)

0 lines changed: 0 ins; 0 del; 0 mod; 73 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/java.desktop/linux/native/libjsoundalsa/PLATFORM_API_LinuxOS_ALSA_Ports.c (was src/java.desktop/unix/native/libjsound/PLATFORM_API_LinuxOS_ALSA_Ports.c)

0 lines changed: 0 ins; 0 del; 0 mod; 724 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/java.desktop/share/native/common/directaudio/DirectAudio.h (was src/java.desktop/share/native/libjsound/DirectAudio.h)

0 lines changed: 0 ins; 0 del; 0 mod; 102 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/java.desktop/share/native/common/directaudio/DirectAudioDevice.c (was src/java.desktop/share/native/libjsound/DirectAudioDevice.c)

0 lines changed: 0 ins; 0 del; 0 mod; 821 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/java.desktop/share/native/common/directaudio/DirectAudioDeviceProvider.c (was src/java.desktop/share/native/libjsound/DirectAudioDeviceProvider.c)

0 lines changed: 0 ins; 0 del; 0 mod; 116 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/java.desktop/share/native/common/midi_port/MidiInDevice.c (was src/java.desktop/share/native/libjsound/MidiInDevice.c)

0 lines changed: 0 ins; 0 del; 0 mod; 260 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/java.desktop/share/native/common/midi_port/MidiInDeviceProvider.c (was src/java.desktop/share/native/libjsound/MidiInDeviceProvider.c)

0 lines changed: 0 ins; 0 del; 0 mod; 143 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/java.desktop/share/native/common/midi_port/MidiOutDevice.c (was src/java.desktop/share/native/libjsound/MidiOutDevice.c)

0 lines changed: 0 ins; 0 del; 0 mod; 147 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/java.desktop/share/native/common/midi_port/MidiOutDeviceProvider.c (was src/java.desktop/share/native/libjsound/MidiOutDeviceProvider.c)

0 lines changed: 0 ins; 0 del; 0 mod; 144 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/java.desktop/share/native/common/midi_port/PlatformMidi.c (was src/java.desktop/share/native/libjsound/PlatformMidi.c)

0 lines changed: 0 ins; 0 del; 0 mod; 203 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/java.desktop/share/native/common/midi_port/PlatformMidi.h (was src/java.desktop/share/native/libjsound/PlatformMidi.h)

0 lines changed: 0 ins; 0 del; 0 mod; 335 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/java.desktop/share/native/common/midi_port/PortMixer.c (was src/java.desktop/share/native/libjsound/PortMixer.c)

0 lines changed: 0 ins; 0 del; 0 mod; 377 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/java.desktop/share/native/common/midi_port/PortMixerProvider.c (was src/java.desktop/share/native/libjsound/PortMixerProvider.c)

0 lines changed: 0 ins; 0 del; 0 mod; 106 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/java.desktop/share/native/common/midi_port/Ports.h (was src/java.desktop/share/native/libjsound/Ports.h)

0 lines changed: 0 ins; 0 del; 0 mod; 133 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/java.desktop/share/native/common/sound/Configure.h (was src/java.desktop/share/native/libjsound/Configure.h)

0 lines changed: 0 ins; 0 del; 0 mod; 51 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/java.desktop/share/native/common/sound/SoundDefs.h (was src/java.desktop/share/native/libjsound/SoundDefs.h)

0 lines changed: 0 ins; 0 del; 0 mod; 133 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/java.desktop/share/native/common/sound/Utilities.c (was src/java.desktop/share/native/libjsound/Utilities.c)

0 lines changed: 0 ins; 0 del; 0 mod; 49 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/java.desktop/share/native/common/sound/Utilities.h (was src/java.desktop/share/native/libjsound/Utilities.h)

0 lines changed: 0 ins; 0 del; 0 mod; 85 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/java.desktop/solaris/native/libjsound/PLATFORM_API_SolarisOS_PCM.c (was src/java.desktop/unix/native/libjsound/PLATFORM_API_SolarisOS_PCM.c)

0 lines changed: 0 ins; 0 del; 0 mod; 626 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/java.desktop/solaris/native/libjsound/PLATFORM_API_SolarisOS_Ports.c (was src/java.desktop/unix/native/libjsound/PLATFORM_API_SolarisOS_Ports.c)

0 lines changed: 0 ins; 0 del; 0 mod; 600 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/java.desktop/solaris/native/libjsound/PLATFORM_API_SolarisOS_Utils.c (was src/java.desktop/unix/native/libjsound/PLATFORM_API_SolarisOS_Utils.c)

0 lines changed: 0 ins; 0 del; 0 mod; 193 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/java.desktop/solaris/native/libjsound/PLATFORM_API_SolarisOS_Utils.h (was src/java.desktop/unix/native/libjsound/PLATFORM_API_SolarisOS_Utils.h)

0 lines changed: 0 ins; 0 del; 0 mod; 97 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/java.desktop/windows/native/common/sound/PLATFORM_API_WinOS_Charset_Util.cpp (was src/java.desktop/windows/native/libjsound/PLATFORM_API_WinOS_Charset_Util.cpp)

0 lines changed: 0 ins; 0 del; 0 mod; 52 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/java.desktop/windows/native/common/sound/PLATFORM_API_WinOS_Charset_Util.h (was src/java.desktop/windows/native/libjsound/PLATFORM_API_WinOS_Charset_Util.h)

0 lines changed: 0 ins; 0 del; 0 mod; 44 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/java.desktop/windows/native/libjsoundds/PLATFORM_API_WinOS_DirectSound.cpp (was src/java.desktop/windows/native/libjsound/PLATFORM_API_WinOS_DirectSound.cpp)

0 lines changed: 0 ins; 0 del; 0 mod; 1421 unchg

This code review page was prepared using /localhome/local-copy/webrev/webrev.ksh (vers 25.16-hg+openjdk.java.net).