Code Review for open

Prepared by:ihse on Tue Feb 27 12:11:42 CET 2018
Workspace:/localhome/hg/jdk-EXP/open
Summary of changes: 423 lines changed: 51 ins; 86 del; 286 mod; 6272 unchg
Patch of changes: open.patch
Bug id: JDK-8198751 : Refactor SetupNativeCompilation to take NAME and TYPE
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/common/NativeCompilation.gmk

219 lines changed: 23 ins; 74 del; 122 mod; 861 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/common/TestFilesCompilation.gmk

5 lines changed: 3 ins; 0 del; 2 mod; 97 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/hotspot/gensrc/GensrcAdlc.gmk

5 lines changed: 2 ins; 1 del; 2 mod; 195 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/hotspot/lib/CompileDtracePostJvm.gmk

6 lines changed: 2 ins; 1 del; 3 mod; 208 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/hotspot/lib/CompileGtest.gmk

5 lines changed: 2 ins; 1 del; 2 mod; 129 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/hotspot/lib/CompileJvm.gmk

3 lines changed: 1 ins; 1 del; 1 mod; 270 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/hotspot/lib/CompileLibjsig.gmk

2 lines changed: 0 ins; 0 del; 2 mod; 158 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/launcher/Launcher-java.base.gmk

7 lines changed: 4 ins; 2 del; 1 mod; 106 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/launcher/Launcher-jdk.accessibility.gmk

12 lines changed: 6 ins; 3 del; 3 mod; 125 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/launcher/Launcher-jdk.pack.gmk

5 lines changed: 2 ins; 1 del; 2 mod; 109 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/launcher/LauncherCommon.gmk

4 lines changed: 2 ins; 1 del; 1 mod; 235 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/lib/Awt2dLibraries.gmk

27 lines changed: 0 ins; 0 del; 27 mod; 1074 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/lib/CoreLibraries.gmk

24 lines changed: 3 ins; 0 del; 21 mod; 452 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/lib/Lib-java.instrument.gmk

3 lines changed: 0 ins; 0 del; 3 mod; 94 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/lib/Lib-java.management.gmk

3 lines changed: 0 ins; 0 del; 3 mod; 73 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/lib/Lib-java.prefs.gmk

3 lines changed: 0 ins; 0 del; 3 mod; 61 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/lib/Lib-java.rmi.gmk

3 lines changed: 0 ins; 0 del; 3 mod; 50 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/lib/Lib-java.security.jgss.gmk

5 lines changed: 0 ins; 0 del; 5 mod; 96 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/lib/Lib-java.smartcardio.gmk

3 lines changed: 0 ins; 0 del; 3 mod; 56 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/lib/Lib-jdk.accessibility.gmk

7 lines changed: 0 ins; 0 del; 7 mod; 128 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/lib/Lib-jdk.attach.gmk

3 lines changed: 0 ins; 0 del; 3 mod; 62 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/lib/Lib-jdk.crypto.cryptoki.gmk

3 lines changed: 0 ins; 0 del; 3 mod; 53 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/lib/Lib-jdk.crypto.ec.gmk

3 lines changed: 0 ins; 0 del; 3 mod; 73 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/lib/Lib-jdk.crypto.mscapi.gmk

3 lines changed: 0 ins; 0 del; 3 mod; 52 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/lib/Lib-jdk.crypto.ucrypto.gmk

3 lines changed: 0 ins; 0 del; 3 mod; 51 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/lib/Lib-jdk.hotspot.agent.gmk

3 lines changed: 1 ins; 1 del; 1 mod; 118 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/lib/Lib-jdk.internal.le.gmk

3 lines changed: 0 ins; 0 del; 3 mod; 57 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/lib/Lib-jdk.jdi.gmk

3 lines changed: 0 ins; 0 del; 3 mod; 61 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/lib/Lib-jdk.jdwp.agent.gmk

5 lines changed: 0 ins; 0 del; 5 mod; 120 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/lib/Lib-jdk.management.agent.gmk

3 lines changed: 0 ins; 0 del; 3 mod; 56 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/lib/Lib-jdk.management.gmk

3 lines changed: 0 ins; 0 del; 3 mod; 83 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/lib/Lib-jdk.net.gmk

3 lines changed: 0 ins; 0 del; 3 mod; 69 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/lib/Lib-jdk.pack.gmk

3 lines changed: 0 ins; 0 del; 3 mod; 59 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/lib/Lib-jdk.sctp.gmk

3 lines changed: 0 ins; 0 del; 3 mod; 57 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/lib/Lib-jdk.security.auth.gmk

3 lines changed: 0 ins; 0 del; 3 mod; 61 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/lib/LibosxLibraries.gmk

3 lines changed: 0 ins; 0 del; 3 mod; 64 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/lib/NetworkingLibraries.gmk

3 lines changed: 0 ins; 0 del; 3 mod; 57 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/lib/NioLibraries.gmk

3 lines changed: 0 ins; 0 del; 3 mod; 88 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/lib/PlatformLibraries.gmk

3 lines changed: 0 ins; 0 del; 3 mod; 58 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/lib/SecurityLibraries.gmk

4 lines changed: 0 ins; 0 del; 4 mod; 62 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/lib/SoundLibraries.gmk

7 lines changed: 0 ins; 0 del; 7 mod; 208 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/test/BuildFailureHandler.gmk

2 lines changed: 0 ins; 0 del; 2 mod; 126 unchg

This code review page was prepared using /localhome/local-copy/webrev/webrev.ksh (vers 25.16-hg+openjdk.java.net).