--- old/make/hotspot/lib/CompileJvm.gmk 2019-02-05 16:27:49.198742141 +0100 +++ new/make/hotspot/lib/CompileJvm.gmk 2019-02-05 16:27:49.022742140 +0100 @@ -56,9 +56,9 @@ JVM_EXCLUDES += adlc # Needed by vm_version.cpp -ifeq ($(OPENJDK_TARGET_CPU), x86_64) +ifeq ($(call isTargetCpu, x86_64), true) OPENJDK_TARGET_CPU_VM_VERSION := amd64 -else ifeq ($(OPENJDK_TARGET_CPU), sparcv9) +else ifeq ($(call isTargetCpu, sparcv9), true) OPENJDK_TARGET_CPU_VM_VERSION := sparc else OPENJDK_TARGET_CPU_VM_VERSION := $(OPENJDK_TARGET_CPU) @@ -107,10 +107,10 @@ # ARM source selection -ifeq ($(OPENJDK_TARGET_OS)-$(OPENJDK_TARGET_CPU), linux-arm) +ifeq ($(call isTargetOs, linux)+$(call isTargetCpu, arm), true+true) JVM_EXCLUDE_PATTERNS += arm_64 -else ifeq ($(OPENJDK_TARGET_OS)-$(OPENJDK_TARGET_CPU), linux-aarch64) +else ifeq ($(call isTargetOs, linux)+$(call isTargetCpu, aarch64), true+true) # For 64-bit arm builds, we use the 64 bit hotspot/src/cpu/arm # hotspot sources if HOTSPOT_TARGET_CPU_ARCH is set to arm. # Exclude the aarch64 and 32 bit arm files for this build. @@ -119,21 +119,21 @@ endif endif -ifneq ($(filter $(OPENJDK_TARGET_OS), linux macosx windows), ) +ifeq ($(call isTargetOs, linux macosx windows), true) JVM_PRECOMPILED_HEADER := $(TOPDIR)/src/hotspot/share/precompiled/precompiled.hpp endif -ifeq ($(OPENJDK_TARGET_CPU), x86) +ifeq ($(call isTargetCpu, x86), true) JVM_EXCLUDE_PATTERNS += x86_64 -else ifeq ($(OPENJDK_TARGET_CPU), x86_64) +else ifeq ($(call isTargetCpu, x86_64), true) JVM_EXCLUDE_PATTERNS += x86_32 endif # Inline assembly for solaris -ifeq ($(OPENJDK_TARGET_OS), solaris) - ifeq ($(OPENJDK_TARGET_CPU), x86_64) +ifeq ($(call isTargetOs, solaris), true) + ifeq ($(call isTargetCpu, x86_64), true) JVM_CFLAGS += $(TOPDIR)/src/hotspot/os_cpu/solaris_x86/solaris_x86_64.il - else ifeq ($(OPENJDK_TARGET_CPU), sparcv9) + else ifeq ($(call isTargetCpu, sparcv9), true) JVM_CFLAGS += $(TOPDIR)/src/hotspot/os_cpu/solaris_sparc/solaris_sparc.il endif # Exclude warnings in devstudio 12.6 @@ -143,7 +143,7 @@ endif endif -ifeq ($(OPENJDK_TARGET_OS)-$(OPENJDK_TARGET_CPU), solaris-sparcv9) +ifeq ($(call isTargetOs, solaris)+$(call isTargetCpu, sparcv9), true+true) ifeq ($(COMPILE_WITH_DEBUG_SYMBOLS), false) # NOTE: In the old build, we weirdly enough set -g/-g0 always, regardless # of if debug symbols were needed. Without it, compilation fails on @@ -152,8 +152,8 @@ endif endif -ifeq ($(OPENJDK_TARGET_OS), windows) - ifeq ($(OPENJDK_TARGET_CPU_BITS), 64) +ifeq ($(call isTargetOs, windows), true) + ifeq ($(call isTargetCpuBits, 64), true) RC_DESC := 64-Bit$(SPACE) endif JVM_RCFLAGS += -D"HS_FILEDESC=$(HOTSPOT_VM_DISTRO) $(RC_DESC)$(JVM_VARIANT) VM" @@ -209,7 +209,7 @@ $(BUILD_LIBJVM_TARGET_DEPS)) ifneq ($(GENERATE_COMPILE_COMMANDS_ONLY), true) - ifeq ($(OPENJDK_TARGET_OS), windows) + ifeq ($(call isTargetOs, windows), true) # It doesn't matter which jvm.lib file gets exported, but we need # to pick just one. ifeq ($(JVM_VARIANT), $(JVM_VARIANT_MAIN))