Code Review for open

Prepared by:ihse on Wed Feb 6 16:34:04 CET 2019
Workspace:/localhome/hg/jdk-JAY/open
Summary of changes: 319 lines changed: 83 ins; 7 del; 229 mod; 15427 unchg
Patch of changes: open.patch
Bug id: JDK-8218431 : Improved platform checking in makefiles
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/Bundles.gmk

3 lines changed: 0 ins; 0 del; 3 mod; 287 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/CompileDemos.gmk

1 line changed: 0 ins; 0 del; 1 mod; 265 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/CompileJavaModules.gmk

12 lines changed: 0 ins; 4 del; 8 mod; 670 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/CopyImportModules.gmk

1 line changed: 0 ins; 0 del; 1 mod; 103 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/CreateJmods.gmk

1 line changed: 0 ins; 0 del; 1 mod; 179 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/Images.gmk

3 lines changed: 0 ins; 0 del; 3 mod; 253 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/InitSupport.gmk

1 line changed: 0 ins; 0 del; 1 mod; 636 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/MacBundles.gmk

1 line changed: 0 ins; 0 del; 1 mod; 114 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/Main.gmk

1 line changed: 0 ins; 0 del; 1 mod; 1218 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/ModuleWrapper.gmk

1 line changed: 0 ins; 0 del; 1 mod; 113 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/RunTests.gmk

4 lines changed: 0 ins; 0 del; 4 mod; 1202 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/TestImage.gmk

1 line changed: 0 ins; 0 del; 1 mod; 45 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/ZipSecurity.gmk

2 lines changed: 0 ins; 0 del; 2 mod; 102 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/common/MakeBase.gmk

3 lines changed: 0 ins; 0 del; 3 mod; 516 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/common/Modules.gmk

2 lines changed: 0 ins; 0 del; 2 mod; 470 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/common/NativeCompilation.gmk

11 lines changed: 0 ins; 0 del; 11 mod; 1061 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/common/Utils.gmk

61 lines changed: 61 ins; 0 del; 0 mod; 307 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/copy/Copy-java.base.gmk

5 lines changed: 0 ins; 0 del; 5 mod; 250 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/copy/Copy-jdk.crypto.cryptoki.gmk

1 line changed: 0 ins; 0 del; 1 mod; 44 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/copy/Copy-jdk.crypto.ucrypto.gmk

1 line changed: 0 ins; 0 del; 1 mod; 41 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/gensrc/Gensrc-java.desktop.gmk

5 lines changed: 0 ins; 0 del; 5 mod; 82 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/gensrc/Gensrc-jdk.hotspot.agent.gmk

1 line changed: 0 ins; 0 del; 1 mod; 63 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/gensrc/GensrcIcons.gmk

1 line changed: 0 ins; 0 del; 1 mod; 128 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/gensrc/GensrcMisc.gmk

2 lines changed: 0 ins; 0 del; 2 mod; 134 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/hotspot/CopyToExplodedJdk.gmk

1 line changed: 0 ins; 0 del; 1 mod; 55 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/hotspot/gensrc/GensrcAdlc.gmk

10 lines changed: 0 ins; 0 del; 10 mod; 201 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/hotspot/gensrc/GensrcDtrace.gmk

4 lines changed: 0 ins; 0 del; 4 mod; 108 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/hotspot/ide/CreateVSProject.gmk

3 lines changed: 0 ins; 0 del; 3 mod; 160 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/hotspot/lib/CompileDtraceLibraries.gmk

1 line changed: 0 ins; 0 del; 1 mod; 61 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/hotspot/lib/CompileGtest.gmk

2 lines changed: 0 ins; 0 del; 2 mod; 122 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/hotspot/lib/CompileJvm.gmk

14 lines changed: 0 ins; 0 del; 14 mod; 288 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/hotspot/lib/JvmDtraceObjects.gmk

2 lines changed: 0 ins; 0 del; 2 mod; 137 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/hotspot/lib/JvmFeatures.gmk

2 lines changed: 0 ins; 0 del; 2 mod; 283 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/hotspot/lib/JvmFlags.gmk

1 line changed: 0 ins; 0 del; 1 mod; 100 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/hotspot/lib/JvmMapfile.gmk

10 lines changed: 0 ins; 0 del; 10 mod; 175 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/hotspot/lib/JvmOverrideFiles.gmk

8 lines changed: 0 ins; 0 del; 8 mod; 194 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/hotspot/test/GtestImage.gmk

2 lines changed: 0 ins; 0 del; 2 mod; 65 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/launcher/Launcher-java.base.gmk

3 lines changed: 0 ins; 0 del; 3 mod; 98 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/launcher/Launcher-java.security.jgss.gmk

1 line changed: 0 ins; 0 del; 1 mod; 39 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/launcher/Launcher-jdk.accessibility.gmk

2 lines changed: 0 ins; 0 del; 2 mod; 111 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/launcher/Launcher-jdk.pack.gmk

1 line changed: 0 ins; 0 del; 1 mod; 100 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/launcher/LauncherCommon.gmk

4 lines changed: 0 ins; 0 del; 4 mod; 255 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/lib/Awt2dLibraries.gmk

48 lines changed: 0 ins; 0 del; 48 mod; 932 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/lib/CoreLibraries.gmk

6 lines changed: 0 ins; 0 del; 6 mod; 247 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/lib/Lib-java.base.gmk

3 lines changed: 0 ins; 0 del; 3 mod; 211 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/lib/Lib-java.desktop.gmk

5 lines changed: 0 ins; 1 del; 4 mod; 140 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/lib/Lib-java.instrument.gmk

2 lines changed: 0 ins; 0 del; 2 mod; 72 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/lib/Lib-java.management.gmk

2 lines changed: 0 ins; 1 del; 1 mod; 58 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/lib/Lib-java.prefs.gmk

1 line changed: 0 ins; 0 del; 1 mod; 53 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/lib/Lib-java.security.jgss.gmk

2 lines changed: 0 ins; 0 del; 2 mod; 78 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/lib/Lib-jdk.accessibility.gmk

2 lines changed: 0 ins; 0 del; 2 mod; 114 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/lib/Lib-jdk.attach.gmk

1 line changed: 0 ins; 0 del; 1 mod; 52 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/lib/Lib-jdk.crypto.mscapi.gmk

1 line changed: 0 ins; 0 del; 1 mod; 43 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/lib/Lib-jdk.crypto.ucrypto.gmk

1 line changed: 0 ins; 0 del; 1 mod; 45 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/lib/Lib-jdk.hotspot.agent.gmk

5 lines changed: 0 ins; 0 del; 5 mod; 73 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/lib/Lib-jdk.internal.le.gmk

2 lines changed: 0 ins; 0 del; 2 mod; 42 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/lib/Lib-jdk.jdi.gmk

2 lines changed: 0 ins; 0 del; 2 mod; 45 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/lib/Lib-jdk.management.gmk

3 lines changed: 0 ins; 1 del; 2 mod; 65 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/lib/Lib-jdk.net.gmk

1 line changed: 0 ins; 0 del; 1 mod; 47 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/lib/Lib-jdk.sctp.gmk

2 lines changed: 0 ins; 0 del; 2 mod; 54 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/test/BuildFailureHandler.gmk

2 lines changed: 0 ins; 0 del; 2 mod; 126 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/test/JtregNativeHotspot.gmk

5 lines changed: 0 ins; 0 del; 5 mod; 1543 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/test/JtregNativeJdk.gmk

4 lines changed: 0 ins; 0 del; 4 mod; 113 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw test/make/TestMakeBase.gmk

22 lines changed: 22 ins; 0 del; 0 mod; 398 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw test/make/UtilsForTests.gmk

1 line changed: 0 ins; 0 del; 1 mod; 41 unchg

This code review page was prepared using /localhome/local-copy/webrev/webrev.ksh (vers 25.16-hg+openjdk.java.net).