Code Review for jdk

Prepared by:iignatyev on Mon Jun 5 22:05:05 PDT 2017
Workspace:/Users/iignatye/ws/jdk10/jdk10/jdk
Compare against: ssh://hg.openjdk.java.net/jdk10/jdk10/jdk
Compare against version:17314
Summary of changes: 298 lines changed: 61 ins; 96 del; 141 mod; 12680 unchg
Changeset: jdk.changeset
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/java/io/FilePermission/ReadFileOnPath.java

rev 17315 : 8181335: remove packageless CompilerUtils
Reviewed-by: duke
2 lines changed: 1 ins; 0 del; 1 mod; 82 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/java/lang/Class/forName/modules/TestDriver.java

rev 17315 : 8181335: remove packageless CompilerUtils
Reviewed-by: duke
2 lines changed: 1 ins; 0 del; 1 mod; 171 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/java/lang/Class/getResource/ResourcesTest.java

rev 17315 : 8181335: remove packageless CompilerUtils
Reviewed-by: duke
4 lines changed: 1 ins; 0 del; 3 mod; 92 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/java/lang/ClassLoader/getResource/modules/ResourcesTest.java

rev 17315 : 8181335: remove packageless CompilerUtils
Reviewed-by: duke
4 lines changed: 1 ins; 0 del; 3 mod; 88 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/java/lang/ModuleLayer/LayerAndLoadersTest.java

rev 17315 : 8181335: remove packageless CompilerUtils
Reviewed-by: duke
4 lines changed: 1 ins; 0 del; 3 mod; 718 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/java/lang/ModuleTests/access/AccessTest.java

rev 17315 : 8181335: remove packageless CompilerUtils
Reviewed-by: duke
4 lines changed: 1 ins; 0 del; 3 mod; 83 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/java/lang/StackTraceElement/WithClassLoaderName.java

rev 17315 : 8181335: remove packageless CompilerUtils
Reviewed-by: duke
3 lines changed: 2 ins; 0 del; 1 mod; 121 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/java/lang/System/LoggerFinder/modules/Base.java

rev 17315 : 8181335: remove packageless CompilerUtils
Reviewed-by: duke
1 line changed: 1 ins; 0 del; 0 mod; 273 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/java/lang/System/LoggerFinder/modules/JDKLoggerForImageTest.java

rev 17315 : 8181335: remove packageless CompilerUtils
Reviewed-by: duke
2 lines changed: 0 ins; 0 del; 2 mod; 90 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/java/lang/System/LoggerFinder/modules/JDKLoggerForJDKTest.java

rev 17315 : 8181335: remove packageless CompilerUtils
Reviewed-by: duke
2 lines changed: 0 ins; 0 del; 2 mod; 84 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/java/lang/System/LoggerFinder/modules/LoggerInImageTest.java

rev 17315 : 8181335: remove packageless CompilerUtils
Reviewed-by: duke
2 lines changed: 0 ins; 0 del; 2 mod; 96 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/java/lang/System/LoggerFinder/modules/NamedLoggerForImageTest.java

rev 17315 : 8181335: remove packageless CompilerUtils
Reviewed-by: duke
2 lines changed: 0 ins; 0 del; 2 mod; 101 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/java/lang/System/LoggerFinder/modules/NamedLoggerForJDKTest.java

rev 17315 : 8181335: remove packageless CompilerUtils
Reviewed-by: duke
2 lines changed: 0 ins; 0 del; 2 mod; 90 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/java/lang/System/LoggerFinder/modules/UnnamedLoggerForImageTest.java

rev 17315 : 8181335: remove packageless CompilerUtils
Reviewed-by: duke
2 lines changed: 0 ins; 0 del; 2 mod; 101 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/java/lang/System/LoggerFinder/modules/UnnamedLoggerForJDKTest.java

rev 17315 : 8181335: remove packageless CompilerUtils
Reviewed-by: duke
2 lines changed: 0 ins; 0 del; 2 mod; 90 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/java/lang/module/ModuleReader/ModuleReaderTest.java

rev 17315 : 8181335: remove packageless CompilerUtils
Reviewed-by: duke
4 lines changed: 1 ins; 0 del; 3 mod; 421 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/java/lang/reflect/Proxy/ProxyClassAccessTest.java

rev 17315 : 8181335: remove packageless CompilerUtils
Reviewed-by: duke
4 lines changed: 1 ins; 0 del; 3 mod; 115 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/java/lang/reflect/Proxy/ProxyLayerTest.java

rev 17315 : 8181335: remove packageless CompilerUtils
Reviewed-by: duke
4 lines changed: 1 ins; 0 del; 3 mod; 174 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/java/lang/reflect/Proxy/ProxyTest.java

rev 17315 : 8181335: remove packageless CompilerUtils
Reviewed-by: duke
4 lines changed: 1 ins; 0 del; 3 mod; 79 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/java/net/URLClassLoader/closetest/CloseTest.java

rev 17315 : 8181335: remove packageless CompilerUtils
Reviewed-by: duke
3 lines changed: 2 ins; 0 del; 1 mod; 201 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/java/net/URLClassLoader/closetest/GetResourceAsStream.java

rev 17315 : 8181335: remove packageless CompilerUtils
Reviewed-by: duke
2 lines changed: 1 ins; 0 del; 1 mod; 135 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/java/net/URLClassLoader/definePackage/SplitPackage.java

rev 17315 : 8181335: remove packageless CompilerUtils
Reviewed-by: duke
4 lines changed: 1 ins; 0 del; 3 mod; 100 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/java/rmi/module/ModuleTest.java

rev 17315 : 8181335: remove packageless CompilerUtils
Reviewed-by: duke
4 lines changed: 1 ins; 0 del; 3 mod; 156 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/java/security/Provider/SecurityProviderModularTest.java

rev 17315 : 8181335: remove packageless CompilerUtils
Reviewed-by: duke
4 lines changed: 2 ins; 0 del; 2 mod; 337 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/java/util/ResourceBundle/modules/cache/CacheTest.java

rev 17315 : 8181335: remove packageless CompilerUtils
Reviewed-by: duke
5 lines changed: 1 ins; 1 del; 3 mod; 115 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/java/util/ResourceBundle/modules/casesensitive/CaseInsensitiveNameClash.java

rev 17315 : 8181335: remove packageless CompilerUtils
Reviewed-by: duke
3 lines changed: 1 ins; 0 del; 2 mod; 70 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/java/util/ResourceBundle/modules/security/TestPermission.java

rev 17315 : 8181335: remove packageless CompilerUtils
Reviewed-by: duke
4 lines changed: 1 ins; 0 del; 3 mod; 77 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/java/util/ServiceLoader/modules/BadProvidersTest.java

rev 17315 : 8181335: remove packageless CompilerUtils
Reviewed-by: duke
5 lines changed: 2 ins; 0 del; 3 mod; 192 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/java/util/logging/modules/GetResourceBundleTest.java

rev 17315 : 8181335: remove packageless CompilerUtils
Reviewed-by: duke
4 lines changed: 1 ins; 0 del; 3 mod; 107 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/javax/security/auth/login/modules/JaasModularClientTest.java

rev 17315 : 8181335: remove packageless CompilerUtils
Reviewed-by: duke
4 lines changed: 1 ins; 0 del; 3 mod; 296 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/javax/security/auth/login/modules/JaasModularDefaultHandlerTest.java

rev 17315 : 8181335: remove packageless CompilerUtils
Reviewed-by: duke
4 lines changed: 1 ins; 0 del; 3 mod; 252 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/jdk/modules/incubator/DefaultImage.java

rev 17315 : 8181335: remove packageless CompilerUtils
Reviewed-by: duke
5 lines changed: 1 ins; 1 del; 3 mod; 177 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/jdk/modules/incubator/ImageModules.java

rev 17315 : 8181335: remove packageless CompilerUtils
Reviewed-by: duke
2 lines changed: 1 ins; 0 del; 1 mod; 382 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/jdk/modules/scenarios/automaticmodules/RunWithAutomaticModules.java

rev 17315 : 8181335: remove packageless CompilerUtils
Reviewed-by: duke
4 lines changed: 1 ins; 0 del; 3 mod; 177 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/jdk/modules/scenarios/container/ContainerTest.java

rev 17315 : 8181335: remove packageless CompilerUtils
Reviewed-by: duke
4 lines changed: 1 ins; 0 del; 3 mod; 145 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/jdk/modules/scenarios/overlappingpackages/OverlappingPackagesTest.java

rev 17315 : 8181335: remove packageless CompilerUtils
Reviewed-by: duke
4 lines changed: 1 ins; 0 del; 3 mod; 116 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/sun/security/tools/jarsigner/AltProvider.java

rev 17315 : 8181335: remove packageless CompilerUtils
Reviewed-by: duke
2 lines changed: 1 ins; 0 del; 1 mod; 160 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/sun/security/tools/jarsigner/multiRelease/MVJarSigningTest.java

rev 17315 : 8181335: remove packageless CompilerUtils
Reviewed-by: duke
2 lines changed: 1 ins; 1 del; 0 mod; 228 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/tools/jlink/basic/AllModulePath.java

rev 17315 : 8181335: remove packageless CompilerUtils
Reviewed-by: duke
4 lines changed: 1 ins; 0 del; 3 mod; 175 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/tools/jlink/basic/BasicTest.java

rev 17315 : 8181335: remove packageless CompilerUtils
Reviewed-by: duke
4 lines changed: 1 ins; 0 del; 3 mod; 159 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/tools/jlink/bindservices/BindServices.java

rev 17315 : 8181335: remove packageless CompilerUtils
Reviewed-by: duke
3 lines changed: 1 ins; 0 del; 2 mod; 216 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/tools/jlink/bindservices/SuggestProviders.java

rev 17315 : 8181335: remove packageless CompilerUtils
Reviewed-by: duke
3 lines changed: 1 ins; 0 del; 2 mod; 319 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/tools/jlink/plugins/ExcludeJmodSectionPluginTest.java

rev 17315 : 8181335: remove packageless CompilerUtils
Reviewed-by: duke
4 lines changed: 1 ins; 0 del; 3 mod; 337 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/tools/jlink/plugins/LegalFilePluginTest.java

rev 17315 : 8181335: remove packageless CompilerUtils
Reviewed-by: duke
4 lines changed: 1 ins; 0 del; 3 mod; 384 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/tools/jlink/plugins/SystemModuleDescriptors/CompiledVersionTest.java

rev 17315 : 8181335: remove packageless CompilerUtils
Reviewed-by: duke
2 lines changed: 1 ins; 0 del; 1 mod; 132 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/tools/jlink/plugins/SystemModuleDescriptors/UserModuleTest.java

rev 17315 : 8181335: remove packageless CompilerUtils
Reviewed-by: duke
2 lines changed: 1 ins; 0 del; 1 mod; 322 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/tools/jmod/JmodNegativeTest.java

rev 17315 : 8181335: remove packageless CompilerUtils
Reviewed-by: duke
3 lines changed: 1 ins; 0 del; 2 mod; 537 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/tools/jmod/JmodTest.java

rev 17315 : 8181335: remove packageless CompilerUtils
Reviewed-by: duke
3 lines changed: 1 ins; 0 del; 2 mod; 760 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/tools/launcher/modules/addexports/AddExportsTest.java

rev 17315 : 8181335: remove packageless CompilerUtils
Reviewed-by: duke
4 lines changed: 1 ins; 0 del; 3 mod; 290 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/tools/launcher/modules/addmods/AddModsTest.java

rev 17315 : 8181335: remove packageless CompilerUtils
Reviewed-by: duke
3 lines changed: 1 ins; 0 del; 2 mod; 264 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/tools/launcher/modules/addreads/AddReadsTest.java

rev 17315 : 8181335: remove packageless CompilerUtils
Reviewed-by: duke
4 lines changed: 1 ins; 0 del; 3 mod; 224 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/tools/launcher/modules/basic/BasicTest.java

rev 17315 : 8181335: remove packageless CompilerUtils
Reviewed-by: duke
4 lines changed: 1 ins; 0 del; 3 mod; 258 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/tools/launcher/modules/classpath/JavaClassPathTest.java

rev 17315 : 8181335: remove packageless CompilerUtils
Reviewed-by: duke
4 lines changed: 1 ins; 0 del; 3 mod; 222 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/tools/launcher/modules/dryrun/DryRunTest.java

rev 17315 : 8181335: remove packageless CompilerUtils
Reviewed-by: duke
5 lines changed: 1 ins; 1 del; 3 mod; 198 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/tools/launcher/modules/limitmods/LimitModsTest.java

rev 17315 : 8181335: remove packageless CompilerUtils
Reviewed-by: duke
5 lines changed: 1 ins; 1 del; 3 mod; 189 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/tools/launcher/modules/listmods/ListModsTest.java

rev 17315 : 8181335: remove packageless CompilerUtils
Reviewed-by: duke
3 lines changed: 1 ins; 0 del; 2 mod; 143 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/tools/launcher/modules/patch/basic/PatchTest.java

rev 17315 : 8181335: remove packageless CompilerUtils
Reviewed-by: duke
5 lines changed: 1 ins; 1 del; 3 mod; 214 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/tools/launcher/modules/patch/basic/PatchTestWarningError.java

rev 17315 : 8181335: remove packageless CompilerUtils
Reviewed-by: duke
4 lines changed: 1 ins; 0 del; 3 mod; 219 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/tools/launcher/modules/patch/systemmodules/PatchSystemModules.java

rev 17315 : 8181335: remove packageless CompilerUtils
Reviewed-by: duke
2 lines changed: 1 ins; 0 del; 1 mod; 269 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/tools/launcher/modules/upgrademodulepath/UpgradeModulePathTest.java

rev 17315 : 8181335: remove packageless CompilerUtils
Reviewed-by: duke
5 lines changed: 1 ins; 1 del; 3 mod; 126 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/tools/schemagen/MultiReleaseJarTest.java

rev 17315 : 8181335: remove packageless CompilerUtils
Reviewed-by: duke
4 lines changed: 2 ins; 1 del; 1 mod; 114 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/tools/wsgen/MultiReleaseJarTest.java

rev 17315 : 8181335: remove packageless CompilerUtils
Reviewed-by: duke
4 lines changed: 2 ins; 1 del; 1 mod; 117 unchg

------ ------ ------ ------ Old --- ----- --- test/lib/testlibrary/CompilerUtils.java

rev 17315 : 8181335: remove packageless CompilerUtils
Reviewed-by: duke
87 lines changed: 0 ins; 87 del; 0 mod; 0 unchg

This code review page was prepared using /Users/iignatye/ws/code-tools/webrev/webrev.ksh (vers 25.16-hg+openjdk.java.net).