--- old/doc/testing.html 2018-11-01 16:34:09.000000000 -0700
+++ new/doc/testing.html 2018-11-01 16:34:08.000000000 -0700
@@ -62,9 +62,8 @@
If you want, you can single out an individual test or a group of tests, for instance gtest:LogDecorations
or gtest:LogDecorations.level_test_vm
. This can be particularly useful if you want to run a shaky test repeatedly.
For Gtest, there is a separate test suite for each JVM variant. The JVM variant is defined by adding /<variant>
to the test descriptor, e.g. gtest:Log/client
. If you specify no variant, gtest will run once for each JVM variant present (e.g. server, client). So if you only have the server JVM present, then gtest:all
will be equivalent to gtest:all/server
.
Special tests
-A handful of odd tests that are not covered by any other testing framework are accessible using the special:
test descriptor. Currently, this includes hotspot-internal
, failure-handler
and make
.
+A handful of odd tests that are not covered by any other testing framework are accessible using the special:
test descriptor. Currently, this includes failure-handler
and make
.
-Hotspot legacy internal testing (run using -XX:+ExecuteInternalVMTests
) is run using special:hotspot-internal
or just hotspot-internal
as test descriptor, and will only work on a debug JVM.
Failure handler testing is run using special:failure-handler
or just failure-handler
as test descriptor.
Tests for the build system, including both makefiles and related functionality, is run using special:make
or just make
as test descriptor. This is equivalent to special:make:all
.
A specific make test can be run by supplying it as argument, e.g. special:make:idea
. As a special syntax, this can also be expressed as make-idea
, which allows for command lines as make test-make-idea
.
--- old/doc/testing.md 2018-11-01 16:34:12.000000000 -0700
+++ new/doc/testing.md 2018-11-01 16:34:11.000000000 -0700
@@ -108,11 +108,7 @@
A handful of odd tests that are not covered by any other testing framework are
accessible using the `special:` test descriptor. Currently, this includes
-`hotspot-internal`, `failure-handler` and `make`.
-
- * Hotspot legacy internal testing (run using `-XX:+ExecuteInternalVMTests`)
- is run using `special:hotspot-internal` or just `hotspot-internal` as test
- descriptor, and will only work on a debug JVM.
+`failure-handler` and `make`.
* Failure handler testing is run using `special:failure-handler` or just
`failure-handler` as test descriptor.
--- old/make/RunTests.gmk 2018-11-01 16:34:14.000000000 -0700
+++ new/make/RunTests.gmk 2018-11-01 16:34:13.000000000 -0700
@@ -318,7 +318,7 @@
special:make:all \
)
) \
- $(if $(filter hotspot-internal failure-handler, $1), \
+ $(if $(filter failure-handler, $1), \
special:$(strip $1) \
)
endef
@@ -674,11 +674,7 @@
$1_TEST_ARGS :=
endif
- ifeq ($$($1_TEST_NAME), hotspot-internal)
- $1_TEST_COMMAND_LINE := \
- $$(JDK_IMAGE_DIR)/bin/java -XX:+ExecuteInternalVMTests \
- -XX:+ShowMessageBoxOnError -version
- else ifeq ($$($1_TEST_NAME), failure-handler)
+ ifeq ($$($1_TEST_NAME), failure-handler)
ifeq ($(BUILD_FAILURE_HANDLER), true)
$1_TEST_COMMAND_LINE := \
($(CD) $(TOPDIR)/make/test && $(MAKE) $(MAKE_ARGS) -f \
--- old/src/hotspot/os/linux/os_linux.cpp 2018-11-01 16:34:16.000000000 -0700
+++ new/src/hotspot/os/linux/os_linux.cpp 2018-11-01 16:34:16.000000000 -0700
@@ -5956,10 +5956,6 @@
#ifndef PRODUCT
-#define test_log(...) \
- do { \
- } while (false)
-
class TestReserveMemorySpecial : AllStatic {
public:
static void small_page_write(void* addr, size_t size) {
@@ -5976,8 +5972,6 @@
return;
}
- test_log("test_reserve_memory_special_huge_tlbfs_only(" SIZE_FORMAT ")", size);
-
char* addr = os::Linux::reserve_memory_special_huge_tlbfs_only(size, NULL, false);
if (addr != NULL) {
@@ -6036,15 +6030,10 @@
::munmap(mapping1, mapping_size);
// Case 1
- test_log("%s, req_addr NULL:", __FUNCTION__);
- test_log("size align result");
-
for (int i = 0; i < num_sizes; i++) {
const size_t size = sizes[i];
for (size_t alignment = ag; is_aligned(size, alignment); alignment *= 2) {
char* p = os::Linux::reserve_memory_special_huge_tlbfs_mixed(size, alignment, NULL, false);
- test_log(SIZE_FORMAT_HEX " " SIZE_FORMAT_HEX " -> " PTR_FORMAT " %s",
- size, alignment, p2i(p), (p != NULL ? "" : "(failed)"));
if (p != NULL) {
assert(is_aligned(p, alignment), "must be");
small_page_write(p, size);
@@ -6054,17 +6043,11 @@
}
// Case 2
- test_log("%s, req_addr non-NULL:", __FUNCTION__);
- test_log("size align req_addr result");
-
for (int i = 0; i < num_sizes; i++) {
const size_t size = sizes[i];
for (size_t alignment = ag; is_aligned(size, alignment); alignment *= 2) {
char* const req_addr = align_up(mapping1, alignment);
char* p = os::Linux::reserve_memory_special_huge_tlbfs_mixed(size, alignment, req_addr, false);
- test_log(SIZE_FORMAT_HEX " " SIZE_FORMAT_HEX " " PTR_FORMAT " -> " PTR_FORMAT " %s",
- size, alignment, p2i(req_addr), p2i(p),
- ((p != NULL ? (p == req_addr ? "(exact match)" : "") : "(failed)")));
if (p != NULL) {
assert(p == req_addr, "must be");
small_page_write(p, size);
@@ -6074,16 +6057,11 @@
}
// Case 3
- test_log("%s, req_addr non-NULL with preexisting mapping:", __FUNCTION__);
- test_log("size align req_addr result");
-
for (int i = 0; i < num_sizes; i++) {
const size_t size = sizes[i];
for (size_t alignment = ag; is_aligned(size, alignment); alignment *= 2) {
char* const req_addr = align_up(mapping2, alignment);
char* p = os::Linux::reserve_memory_special_huge_tlbfs_mixed(size, alignment, req_addr, false);
- test_log(SIZE_FORMAT_HEX " " SIZE_FORMAT_HEX " " PTR_FORMAT " -> " PTR_FORMAT " %s",
- size, alignment, p2i(req_addr), p2i(p), ((p != NULL ? "" : "(failed)")));
// as the area around req_addr contains already existing mappings, the API should always
// return NULL (as per contract, it cannot return another address)
assert(p == NULL, "must be");
@@ -6108,8 +6086,6 @@
return;
}
- test_log("test_reserve_memory_special_shm(" SIZE_FORMAT ", " SIZE_FORMAT ")", size, alignment);
-
char* addr = os::Linux::reserve_memory_special_shm(size, alignment, NULL, false);
if (addr != NULL) {
--- old/src/hotspot/share/memory/virtualspace.cpp 2018-11-01 16:34:19.000000000 -0700
+++ new/src/hotspot/share/memory/virtualspace.cpp 2018-11-01 16:34:19.000000000 -0700
@@ -1059,10 +1059,6 @@
#ifndef PRODUCT
-#define test_log(...) \
- do {\
- } while (false)
-
class TestReservedSpace : AllStatic {
public:
static void small_page_write(void* addr, size_t size) {
@@ -1083,8 +1079,6 @@
}
static void test_reserved_space1(size_t size, size_t alignment) {
- test_log("test_reserved_space1(%p)", (void*) (uintptr_t) size);
-
assert(is_aligned(size, alignment), "Incorrect input parameters");
ReservedSpace rs(size, // size
@@ -1092,8 +1086,6 @@
UseLargePages, // large
(char *)NULL); // requested_address
- test_log(" rs.special() == %d", rs.special());
-
assert(rs.base() != NULL, "Must be");
assert(rs.size() == size, "Must be");
@@ -1108,14 +1100,10 @@
}
static void test_reserved_space2(size_t size) {
- test_log("test_reserved_space2(%p)", (void*)(uintptr_t)size);
-
assert(is_aligned(size, os::vm_allocation_granularity()), "Must be at least AG aligned");
ReservedSpace rs(size);
- test_log(" rs.special() == %d", rs.special());
-
assert(rs.base() != NULL, "Must be");
assert(rs.size() == size, "Must be");
@@ -1127,9 +1115,6 @@
}
static void test_reserved_space3(size_t size, size_t alignment, bool maybe_large) {
- test_log("test_reserved_space3(%p, %p, %d)",
- (void*)(uintptr_t)size, (void*)(uintptr_t)alignment, maybe_large);
-
if (size < alignment) {
// Tests might set -XX:LargePageSizeInBytes= and cause unexpected input arguments for this test.
assert((size_t)os::vm_page_size() == os::large_page_size(), "Test needs further refinement");
@@ -1143,8 +1128,6 @@
ReservedSpace rs(size, alignment, large, false);
- test_log(" rs.special() == %d", rs.special());
-
assert(rs.base() != NULL, "Must be");
assert(rs.size() == size, "Must be");