--- old/src/hotspot/share/runtime/arguments.cpp 2020-04-05 21:35:20.623049796 -0700 +++ new/src/hotspot/share/runtime/arguments.cpp 2020-04-05 21:35:20.271036546 -0700 @@ -41,9 +41,6 @@ #include "prims/jvmtiExport.hpp" #include "runtime/arguments.hpp" #include "runtime/flags/jvmFlag.hpp" -#include "runtime/flags/jvmFlagConstraintList.hpp" -#include "runtime/flags/jvmFlagRangeList.hpp" -#include "runtime/globals_extension.hpp" #include "runtime/java.hpp" #include "runtime/os.inline.hpp" #include "runtime/safepoint.hpp" @@ -860,7 +857,7 @@ } static bool set_bool_flag(JVMFlag* flag, bool value, JVMFlag::Flags origin) { - if (JVMFlag::boolAtPut(flag, &value, origin) == JVMFlag::SUCCESS) { + if (JVMFlag::boolAtPut(flag, value, origin) == JVMFlag::SUCCESS) { return true; } else { return false; @@ -875,7 +872,7 @@ return false; } - if (JVMFlag::doubleAtPut(flag, &v, origin) == JVMFlag::SUCCESS) { + if (JVMFlag::doubleAtPut(flag, v, origin) == JVMFlag::SUCCESS) { return true; } return false; @@ -907,28 +904,28 @@ if (is_neg) { int_v = -int_v; } - return JVMFlag::intAtPut(flag, &int_v, origin) == JVMFlag::SUCCESS; + return JVMFlag::intAtPut(flag, int_v, origin) == JVMFlag::SUCCESS; } else if (flag->is_uint()) { uint uint_v = (uint) v; - return JVMFlag::uintAtPut(flag, &uint_v, origin) == JVMFlag::SUCCESS; + return JVMFlag::uintAtPut(flag, uint_v, origin) == JVMFlag::SUCCESS; } else if (flag->is_intx()) { intx_v = (intx) v; if (is_neg) { intx_v = -intx_v; } - return JVMFlag::intxAtPut(flag, &intx_v, origin) == JVMFlag::SUCCESS; + return JVMFlag::intxAtPut(flag, intx_v, origin) == JVMFlag::SUCCESS; } else if (flag->is_uintx()) { uintx uintx_v = (uintx) v; - return JVMFlag::uintxAtPut(flag, &uintx_v, origin) == JVMFlag::SUCCESS; + return JVMFlag::uintxAtPut(flag, uintx_v, origin) == JVMFlag::SUCCESS; } else if (flag->is_uint64_t()) { uint64_t uint64_t_v = (uint64_t) v; - return JVMFlag::uint64_tAtPut(flag, &uint64_t_v, origin) == JVMFlag::SUCCESS; + return JVMFlag::uint64_tAtPut(flag, uint64_t_v, origin) == JVMFlag::SUCCESS; } else if (flag->is_size_t()) { size_t size_t_v = (size_t) v; - return JVMFlag::size_tAtPut(flag, &size_t_v, origin) == JVMFlag::SUCCESS; + return JVMFlag::size_tAtPut(flag, size_t_v, origin) == JVMFlag::SUCCESS; } else if (flag->is_double()) { double double_v = (double) v; - return JVMFlag::doubleAtPut(flag, &double_v, origin) == JVMFlag::SUCCESS; + return JVMFlag::doubleAtPut(flag, double_v, origin) == JVMFlag::SUCCESS; } else { return false; } @@ -1338,7 +1335,7 @@ jio_fprintf(defaultStream::error_stream(), "Did you mean '%s%s%s'? ", (fuzzy_matched->is_bool()) ? "(+/-)" : "", - fuzzy_matched->_name, + fuzzy_matched->name(), (fuzzy_matched->is_bool()) ? "" : "="); } } @@ -3843,9 +3840,9 @@ jint Arguments::parse(const JavaVMInitArgs* initial_cmd_args) { assert(verify_special_jvm_flags(false), "deprecated and obsolete flag table inconsistent"); - // Initialize ranges and constraints - JVMFlagRangeList::init(); - JVMFlagConstraintList::init(); + // Initialize custom ranges + JVMFlagCustomRange::init_all(); + JVMFlag::validate_flags(); // If flag "-XX:Flags=flags-file" is used it will be the first option to be processed. const char* hotspotrc = ".hotspotrc";