Code Review for JDK-8253081

Prepared by: iklam on Tue Oct 27 20:51:58 PDT 2020
Compare against: https://github.com/openjdk/jdk
Compare against version: ac772cd9
Summary of changes: 580 lines changed; 423 ins; 64 del; 93 mod; 28261 unchg
Patch of changes: JDK-8253081.patch
Bug id: JDK-8253081
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/classLoaderDataShared.cpp

d85eac79: Remove archived java.lang.Modules from HeapShared::roots() if full module graph is disabled. This fixes crashes in gc/g1/TestPeriodicCollectionJNI.java and gc/metaspace/TestMetaspaceInitialization.java  
17 lines changed; 17 ins; 0 del; 0 mod; 202 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/classLoaderDataShared.hpp

d85eac79: Remove archived java.lang.Modules from HeapShared::roots() if full module graph is disabled. This fixes crashes in gc/g1/TestPeriodicCollectionJNI.java and gc/metaspace/TestMetaspaceInitialization.java  
1 lines changed; 1 ins; 0 del; 0 mod; 47 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/javaClasses.cpp

9940db52: Consolidated patch 2020/10/06  
14 lines changed; 1 ins; 3 del; 10 mod; 4933 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/moduleEntry.cpp

d85eac79: Remove archived java.lang.Modules from HeapShared::roots() if full module graph is disabled. This fixes crashes in gc/g1/TestPeriodicCollectionJNI.java and gc/metaspace/TestMetaspaceInitialization.java
9940db52: Consolidated patch 2020/10/06  
8 lines changed; 4 ins; 0 del; 4 mod; 741 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/moduleEntry.hpp

d85eac79: Remove archived java.lang.Modules from HeapShared::roots() if full module graph is disabled. This fixes crashes in gc/g1/TestPeriodicCollectionJNI.java and gc/metaspace/TestMetaspaceInitialization.java
9940db52: Consolidated patch 2020/10/06  
3 lines changed; 1 ins; 0 del; 2 mod; 300 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/systemDictionary.cpp

9940db52: Consolidated patch 2020/10/06  
5 lines changed; 4 ins; 0 del; 1 mod; 3018 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/systemDictionaryShared.cpp

9940db52: Consolidated patch 2020/10/06  
14 lines changed; 12 ins; 0 del; 2 mod; 2184 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/systemDictionaryShared.hpp

9940db52: Consolidated patch 2020/10/06  
1 lines changed; 1 ins; 0 del; 0 mod; 355 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1CollectedHeap.hpp

9940db52: Consolidated patch 2020/10/06  
6 lines changed; 1 ins; 0 del; 5 mod; 1503 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1CollectedHeap.inline.hpp

9940db52: Consolidated patch 2020/10/06  
1 lines changed; 0 ins; 0 del; 1 mod; 323 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1ConcurrentMark.inline.hpp

9940db52: Consolidated patch 2020/10/06  
3 lines changed; 3 ins; 0 del; 0 mod; 294 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1FullGCMarker.inline.hpp

130f6051: Removed unnecessary checks for klass->class_loader_data()==NULL
9940db52: Consolidated patch 2020/10/06  
7 lines changed; 6 ins; 0 del; 1 mod; 175 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1HeapVerifier.cpp

9940db52: Consolidated patch 2020/10/06  
14 lines changed; 9 ins; 0 del; 5 mod; 846 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/heapRegion.inline.hpp

9940db52: Consolidated patch 2020/10/06  
7 lines changed; 6 ins; 0 del; 1 mod; 420 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/gc_globals.hpp

9940db52: Consolidated patch 2020/10/06  
3 lines changed; 3 ins; 0 del; 0 mod; 738 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/memory/filemap.cpp

d85eac79: Remove archived java.lang.Modules from HeapShared::roots() if full module graph is disabled. This fixes crashes in gc/g1/TestPeriodicCollectionJNI.java and gc/metaspace/TestMetaspaceInitialization.java
9940db52: Consolidated patch 2020/10/06  
2 lines changed; 2 ins; 0 del; 0 mod; 2298 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/memory/filemap.hpp

9940db52: Consolidated patch 2020/10/06  
4 lines changed; 3 ins; 0 del; 1 mod; 593 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/memory/heapShared.cpp

d85eac79: Remove archived java.lang.Modules from HeapShared::roots() if full module graph is disabled. This fixes crashes in gc/g1/TestPeriodicCollectionJNI.java and gc/metaspace/TestMetaspaceInitialization.java
130f6051: Removed unnecessary checks for klass->class_loader_data()==NULL
9940db52: Consolidated patch 2020/10/06  
350 lines changed; 279 ins; 46 del; 25 mod; 1110 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/memory/heapShared.hpp

d85eac79: Remove archived java.lang.Modules from HeapShared::roots() if full module graph is disabled. This fixes crashes in gc/g1/TestPeriodicCollectionJNI.java and gc/metaspace/TestMetaspaceInitialization.java
9940db52: Consolidated patch 2020/10/06  
57 lines changed; 51 ins; 0 del; 6 mod; 358 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/memory/metaspaceShared.cpp

9940db52: Consolidated patch 2020/10/06  
1 lines changed; 0 ins; 0 del; 1 mod; 1808 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/constantPool.cpp

9940db52: Consolidated patch 2020/10/06  
1 lines changed; 1 ins; 0 del; 0 mod; 2485 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/cpCache.cpp

9940db52: Consolidated patch 2020/10/06  
10 lines changed; 7 ins; 0 del; 3 mod; 858 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/cpCache.hpp

9940db52: Consolidated patch 2020/10/06  
3 lines changed; 1 ins; 0 del; 2 mod; 519 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/cpCache.inline.hpp

9940db52: Consolidated patch 2020/10/06  
1 lines changed; 0 ins; 0 del; 1 mod; 101 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/instanceMirrorKlass.inline.hpp

d85eac79: Remove archived java.lang.Modules from HeapShared::roots() if full module graph is disabled. This fixes crashes in gc/g1/TestPeriodicCollectionJNI.java and gc/metaspace/TestMetaspaceInitialization.java
130f6051: Removed unnecessary checks for klass->class_loader_data()==NULL
9940db52: Consolidated patch 2020/10/06  
7 lines changed; 6 ins; 0 del; 1 mod; 129 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/klass.cpp

9940db52: Consolidated patch 2020/10/06  
17 lines changed; 2 ins; 2 del; 13 mod; 984 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/klass.hpp

9940db52: Consolidated patch 2020/10/06  
19 lines changed; 2 ins; 10 del; 7 mod; 696 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/cds/serviceability/ReplaceCriticalClasses.java

9940db52: Consolidated patch 2020/10/06  
4 lines changed; 0 ins; 3 del; 1 mod; 243 unchg

This code review page was prepared using webrev version 0265c54a138e533a2222c77d855e8200996b01e0