Code Review for hotspot

Prepared by:iveresov on Wed Aug 23 10:14:39 PDT 2017
Workspace:/Users/iveresov/work/jdk10-hs-merge/hotspot
Compare against: ssh://hg.openjdk.java.net/jdk10/hs/hotspot
Summary of changes: 2670 lines changed: 1767 ins; 612 del; 291 mod; 21613 unchg
Patch of changes: hotspot.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.amd64/src/org/graalvm/compiler/core/amd64/AMD64ArithmeticLIRGenerator.java

2 lines changed: 0 ins; 0 del; 2 mod; 1269 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.common/src/org/graalvm/compiler/core/common/calc/FloatConvert.java

20 lines changed: 10 ins; 0 del; 10 mod; 55 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.common/src/org/graalvm/compiler/core/common/type/ArithmeticOpTable.java

45 lines changed: 38 ins; 0 del; 7 mod; 756 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.common/src/org/graalvm/compiler/core/common/type/FloatStamp.java

5 lines changed: 4 ins; 0 del; 1 mod; 828 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.common/src/org/graalvm/compiler/core/common/type/IntegerStamp.java

176 lines changed: 173 ins; 0 del; 3 mod; 1380 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/UnsafeReadEliminationTest.java

82 lines changed: 82 ins; 0 del; 0 mod; 133 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/ea/UnsafeEATest.java

79 lines changed: 0 ins; 79 del; 0 mod; 199 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core/src/org/graalvm/compiler/core/CompilationPrinter.java

5 lines changed: 5 ins; 0 del; 0 mod; 119 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core/src/org/graalvm/compiler/core/CompilationWrapper.java

20 lines changed: 0 ins; 20 del; 0 mod; 307 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core/src/org/graalvm/compiler/core/GraalCompilerOptions.java

8 lines changed: 2 ins; 0 del; 6 mod; 46 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.debug/src/org/graalvm/compiler/debug/DebugContext.java

15 lines changed: 13 ins; 0 del; 2 mod; 2031 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.debug/src/org/graalvm/compiler/debug/DebugFilter.java

57 lines changed: 10 ins; 40 del; 7 mod; 153 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.debug/src/org/graalvm/compiler/debug/DebugOptions.java

18 lines changed: 5 ins; 3 del; 10 mod; 196 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.debug/src/org/graalvm/compiler/debug/MethodFilter.java

60 lines changed: 0 ins; 59 del; 1 mod; 192 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.graph/src/org/graalvm/compiler/graph/NodeClass.java

1 line changed: 0 ins; 0 del; 1 mod; 1418 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.test/src/org/graalvm/compiler/hotspot/test/CompilationWrapperTest.java

8 lines changed: 0 ins; 8 del; 0 mod; 208 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.test/src/org/graalvm/compiler/hotspot/test/ObjectCloneTest.java

17 lines changed: 17 ins; 0 del; 0 mod; 87 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/CompilerConfigurationFactory.java

2 lines changed: 0 ins; 0 del; 2 mod; 196 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/JVMCIVersionCheck.java

32 lines changed: 0 ins; 28 del; 4 mod; 128 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/debug/BenchmarkCounters.java

20 lines changed: 0 ins; 17 del; 3 mod; 486 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/meta/HotSpotSuitesProvider.java

7 lines changed: 3 ins; 0 del; 4 mod; 169 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/replacements/HotspotSnippetsOptions.java

1 line changed: 0 ins; 0 del; 1 mod; 71 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.java/src/org/graalvm/compiler/java/ComputeLoopFrequenciesClosure.java

20 lines changed: 2 ins; 14 del; 4 mod; 106 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir.aarch64/src/org/graalvm/compiler/lir/aarch64/AArch64ArrayEqualsOp.java

2 lines changed: 2 ins; 0 del; 0 mod; 235 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir.amd64/src/org/graalvm/compiler/lir/amd64/AMD64ArrayEqualsOp.java

164 lines changed: 152 ins; 0 del; 12 mod; 378 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir.sparc/src/org/graalvm/compiler/lir/sparc/SPARCArrayEqualsOp.java

2 lines changed: 2 ins; 0 del; 0 mod; 264 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir/src/org/graalvm/compiler/lir/gen/ArithmeticLIRGenerator.java

1 line changed: 0 ins; 0 del; 1 mod; 135 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.loop.phases/src/org/graalvm/compiler/loop/phases/LoopPartialUnrollPhase.java

19 lines changed: 17 ins; 0 del; 2 mod; 82 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.loop.phases/src/org/graalvm/compiler/loop/phases/LoopTransformations.java

79 lines changed: 17 ins; 6 del; 56 mod; 396 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.loop.test/src/org/graalvm/compiler/loop/test/LoopPartialUnrollTest.java

190 lines changed: 119 ins; 40 del; 31 mod; 113 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.loop/src/org/graalvm/compiler/loop/DefaultLoopPolicies.java

5 lines changed: 4 ins; 1 del; 0 mod; 223 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.loop/src/org/graalvm/compiler/loop/LoopFragmentInside.java

60 lines changed: 38 ins; 4 del; 18 mod; 550 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes.test/src/org/graalvm/compiler/nodes/test/IntegerStampTest.java

189 lines changed: 184 ins; 3 del; 2 mod; 369 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/GraphDecoder.java

22 lines changed: 22 ins; 0 del; 0 mod; 1932 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/calc/MulNode.java

22 lines changed: 22 ins; 0 del; 0 mod; 138 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/cfg/ControlFlowGraph.java

18 lines changed: 16 ins; 0 del; 2 mod; 756 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.options.processor/src/org/graalvm/compiler/options/processor/OptionProcessor.java

113 lines changed: 76 ins; 15 del; 22 mod; 323 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.options/src/org/graalvm/compiler/options/EnumOptionKey.java

22 lines changed: 0 ins; 21 del; 1 mod; 59 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.options/src/org/graalvm/compiler/options/Option.java

13 lines changed: 10 ins; 0 del; 3 mod; 52 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.options/src/org/graalvm/compiler/options/OptionDescriptor.java

27 lines changed: 24 ins; 0 del; 3 mod; 100 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.options/src/org/graalvm/compiler/options/OptionValues.java

46 lines changed: 7 ins; 32 del; 7 mod; 224 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.phases.common/src/org/graalvm/compiler/phases/common/inlining/InliningUtil.java

4 lines changed: 1 ins; 0 del; 3 mod; 895 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.phases.common/src/org/graalvm/compiler/phases/common/inlining/policy/AbstractInliningPolicy.java

5 lines changed: 1 ins; 0 del; 4 mod; 108 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.phases/src/org/graalvm/compiler/phases/graph/FixedNodeProbabilityCache.java

4 lines changed: 2 ins; 0 del; 2 mod; 151 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.printer/src/org/graalvm/compiler/printer/BinaryGraphPrinter.java

2 lines changed: 0 ins; 0 del; 2 mod; 513 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.amd64/src/org/graalvm/compiler/replacements/amd64/AMD64GraphBuilderPlugins.java

10 lines changed: 10 ins; 0 del; 0 mod; 232 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.test/src/org/graalvm/compiler/replacements/test/ArraysSubstitutionsTest.java

62 lines changed: 0 ins; 62 del; 0 mod; 337 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.test/src/org/graalvm/compiler/replacements/test/DeoptimizeOnExceptionTest.java

64 lines changed: 64 ins; 0 del; 0 mod; 175 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/DefaultJavaLoweringProvider.java

13 lines changed: 11 ins; 0 del; 2 mod; 1034 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/StandardGraphBuilderPlugins.java

2 lines changed: 0 ins; 2 del; 0 mod; 908 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/nodes/ArrayEqualsNode.java

28 lines changed: 25 ins; 0 del; 3 mod; 217 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/nodes/ExplodeLoopNode.java

1 line changed: 0 ins; 0 del; 1 mod; 73 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/nodes/arithmetic/IntegerMulHighNode.java

85 lines changed: 14 ins; 49 del; 22 mod; 54 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/nodes/arithmetic/UnsignedMulHighNode.java

102 lines changed: 12 ins; 66 del; 24 mod; 54 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.common/src/org/graalvm/compiler/core/common/calc/FloatConvertCategory.java

29 lines changed: 29 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core/src/org/graalvm/compiler/core/doc-files/CompilationBailoutActionHelp.txt

6 lines changed: 6 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.debug/src/org/graalvm/compiler/debug/doc-files/DumpHelp.txt

61 lines changed: 61 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.debug/src/org/graalvm/compiler/debug/doc-files/MethodFilterHelp.txt

40 lines changed: 40 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.debug/src/org/graalvm/compiler/debug/doc-files/MetricsFileHelp.txt

11 lines changed: 11 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/debug/doc-files/BenchmarkDynamicCountersHelp.txt

24 lines changed: 24 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/replacements/doc-files/ProfileAllocationsContextHelp.txt

8 lines changed: 8 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.microbenchmarks/src/org/graalvm/compiler/microbenchmarks/graal/TestJMHWhitebox.java

44 lines changed: 44 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.test/src/org/graalvm/compiler/replacements/test/FloatArraysEqualsTest.java

204 lines changed: 204 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.test/src/org/graalvm/compiler/replacements/test/UnsafeBooleanAccessTest.java

81 lines changed: 81 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.micro.benchmarks/src/micro/benchmarks/TestJMHBlackbox.java

43 lines changed: 43 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.microbenchmarks/src/org/graalvm/compiler/microbenchmarks/graal/TestJMH.java

43 lines changed: 0 ins; 43 del; 0 mod; 0 unchg

This code review page was prepared using /Users/iveresov/bin/webrev (vers 23.18-hg-never-dev).