Code Review for jdkhs-event5

Prepared by:jcbeyler on Thu Apr 5 11:09:10 PDT 2018
Workspace:/usr/local/google/home/jcbeyler/mercurial/jdkhs-event5
Compare against: http://hg.openjdk.java.net/jdk/hs
Compare against version:49520
Summary of changes: 3141 lines changed: 3052 ins; 15 del; 74 mod; 154917 unchg
Changeset: jdkhs-event5.changeset
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw make/nb_native/nbproject/configurations.xml

rev 49521 : [mq]: heap8
8 lines changed: 8 ins; 0 del; 0 mod; 40886 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp

rev 49521 : [mq]: heap8
2 lines changed: 0 ins; 0 del; 2 mod; 5666 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/arm/macroAssembler_arm.cpp

rev 49521 : [mq]: heap8
1 line changed: 0 ins; 0 del; 1 mod; 3264 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/arm/templateTable_arm.cpp

rev 49521 : [mq]: heap8
1 line changed: 0 ins; 0 del; 1 mod; 5025 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/ppc/macroAssembler_ppc.cpp

rev 49521 : [mq]: heap8
1 line changed: 0 ins; 0 del; 1 mod; 5360 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/ppc/templateTable_ppc_64.cpp

rev 49521 : [mq]: heap8
1 line changed: 0 ins; 0 del; 1 mod; 4274 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/s390/macroAssembler_s390.cpp

rev 49521 : [mq]: heap8
1 line changed: 0 ins; 0 del; 1 mod; 7471 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/s390/templateTable_s390.cpp

rev 49521 : [mq]: heap8
1 line changed: 0 ins; 0 del; 1 mod; 4369 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/sparc/macroAssembler_sparc.cpp

rev 49521 : [mq]: heap8
2 lines changed: 0 ins; 0 del; 2 mod; 5062 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/sparc/templateTable_sparc.cpp

rev 49521 : [mq]: heap8
1 line changed: 0 ins; 0 del; 1 mod; 3726 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/x86/macroAssembler_x86.cpp

rev 49521 : [mq]: heap8
2 lines changed: 0 ins; 0 del; 2 mod; 11299 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/x86/templateTable_x86.cpp

rev 49521 : [mq]: heap8
1 line changed: 0 ins; 0 del; 1 mod; 4576 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/c1/c1_Runtime1.cpp

rev 49523 : [mq]: heap9
rev 49524 : [mq]: heap11
0 lines changed: 0 ins; 0 del; 0 mod; 1458 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shared/collectedHeap.cpp

rev 49521 : [mq]: heap8
rev 49523 : [mq]: heap9
26 lines changed: 25 ins; 0 del; 1 mod; 631 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shared/collectedHeap.inline.hpp

rev 49521 : [mq]: heap8
rev 49523 : [mq]: heap9
rev 49524 : [mq]: heap11
6 lines changed: 4 ins; 0 del; 2 mod; 300 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shared/threadLocalAllocBuffer.cpp

rev 49521 : [mq]: heap8
rev 49522 : [mq]: event_rebased
55 lines changed: 50 ins; 0 del; 5 mod; 430 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shared/threadLocalAllocBuffer.hpp

rev 49521 : [mq]: heap8
rev 49522 : [mq]: event_rebased
24 lines changed: 16 ins; 1 del; 7 mod; 258 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shared/threadLocalAllocBuffer.inline.hpp

rev 49521 : [mq]: heap8
1 line changed: 0 ins; 0 del; 1 mod; 96 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/interpreter/interpreterRuntime.cpp

rev 49522 : [mq]: event_rebased
rev 49523 : [mq]: heap9
rev 49524 : [mq]: heap11
4 lines changed: 4 ins; 0 del; 0 mod; 1576 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/jvmci/vmStructs_jvmci.cpp

rev 49521 : [mq]: heap8
1 line changed: 0 ins; 0 del; 1 mod; 981 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/memory/oopFactory.cpp

rev 49523 : [mq]: heap9
rev 49524 : [mq]: heap11
0 lines changed: 0 ins; 0 del; 0 mod; 99 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/memory/oopFactory.hpp

rev 49523 : [mq]: heap9
rev 49524 : [mq]: heap11
1 line changed: 1 ins; 0 del; 0 mod; 75 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/oops/instanceKlass.cpp

rev 49523 : [mq]: heap9
rev 49524 : [mq]: heap11
0 lines changed: 0 ins; 0 del; 0 mod; 3750 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/oops/objArrayKlass.cpp

rev 49523 : [mq]: heap9
rev 49524 : [mq]: heap11
0 lines changed: 0 ins; 0 del; 0 mod; 470 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/opto/macro.cpp

rev 49521 : [mq]: heap8
2 lines changed: 0 ins; 0 del; 2 mod; 2798 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/opto/runtime.cpp

rev 49521 : [mq]: heap8
rev 49524 : [mq]: heap11
7 lines changed: 7 ins; 0 del; 0 mod; 1665 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/prims/jvm.cpp

rev 49523 : [mq]: heap9
rev 49524 : [mq]: heap11
0 lines changed: 0 ins; 0 del; 0 mod; 3671 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/prims/jvmti.xml

rev 49521 : [mq]: heap8
rev 49522 : [mq]: event_rebased
rev 49523 : [mq]: heap9
rev 49524 : [mq]: heap11
116 lines changed: 112 ins; 0 del; 4 mod; 14829 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/prims/jvmtiEnv.cpp

rev 49521 : [mq]: heap8
rev 49522 : [mq]: event_rebased
rev 49524 : [mq]: heap11
19 lines changed: 18 ins; 1 del; 0 mod; 3711 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/prims/jvmtiEventController.cpp

rev 49521 : [mq]: heap8
rev 49523 : [mq]: heap9
rev 49524 : [mq]: heap11
2 lines changed: 2 ins; 0 del; 0 mod; 1077 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/prims/jvmtiExport.cpp

rev 49521 : [mq]: heap8
rev 49522 : [mq]: event_rebased
rev 49523 : [mq]: heap9
rev 49524 : [mq]: heap11
136 lines changed: 103 ins; 7 del; 26 mod; 2819 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/prims/jvmtiExport.hpp

rev 49521 : [mq]: heap8
rev 49522 : [mq]: event_rebased
56 lines changed: 43 ins; 5 del; 8 mod; 560 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/prims/jvmtiManageCapabilities.cpp

rev 49521 : [mq]: heap8
rev 49522 : [mq]: event_rebased
rev 49523 : [mq]: heap9
3 lines changed: 3 ins; 0 del; 0 mod; 451 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/prims/jvmtiThreadState.cpp

rev 49521 : [mq]: heap8
1 line changed: 1 ins; 0 del; 0 mod; 401 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/prims/jvmtiThreadState.hpp

rev 49521 : [mq]: heap8
8 lines changed: 8 ins; 0 del; 0 mod; 408 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/runtime/mutexLocker.cpp

rev 49522 : [mq]: event_rebased
rev 49523 : [mq]: heap9
rev 49524 : [mq]: heap11
5 lines changed: 5 ins; 0 del; 0 mod; 335 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/runtime/mutexLocker.hpp

rev 49522 : [mq]: event_rebased
rev 49524 : [mq]: heap11
1 line changed: 1 ins; 0 del; 0 mod; 372 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/runtime/thread.cpp

rev 49521 : [mq]: heap8
3 lines changed: 2 ins; 1 del; 0 mod; 5000 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/runtime/thread.hpp

rev 49521 : [mq]: heap8
6 lines changed: 4 ins; 0 del; 2 mod; 2227 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/runtime/vmStructs.cpp

rev 49521 : [mq]: heap8
1 line changed: 0 ins; 0 del; 1 mod; 3491 unchg

------ ------ ------ ------ ------ --- New ----- Raw src/hotspot/share/runtime/threadHeapSampler.cpp

rev 49522 : [mq]: event_rebased
rev 49523 : [mq]: heap9
rev 49524 : [mq]: heap11
162 lines changed: 162 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw src/hotspot/share/runtime/threadHeapSampler.hpp

rev 49522 : [mq]: event_rebased
rev 49523 : [mq]: heap9
rev 49524 : [mq]: heap11
82 lines changed: 82 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/Frame.java

rev 49522 : [mq]: event_rebased
38 lines changed: 38 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitor.java

rev 49522 : [mq]: event_rebased
rev 49523 : [mq]: heap9
rev 49524 : [mq]: heap11
172 lines changed: 172 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorArrayAllSampledTest.java

rev 49522 : [mq]: event_rebased
rev 49523 : [mq]: heap9
64 lines changed: 64 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorEventOnOffTest.java

rev 49522 : [mq]: event_rebased
rev 49523 : [mq]: heap9
72 lines changed: 72 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorEventsForTwoThreadsTest.java

rev 49523 : [mq]: heap9
rev 49524 : [mq]: heap11
47 lines changed: 47 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorGCCMSTest.java

rev 49522 : [mq]: event_rebased
rev 49523 : [mq]: heap9
32 lines changed: 32 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorGCParallelTest.java

rev 49522 : [mq]: event_rebased
rev 49523 : [mq]: heap9
32 lines changed: 32 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorGCSerialTest.java

rev 49522 : [mq]: event_rebased
rev 49523 : [mq]: heap9
32 lines changed: 32 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorGCTest.java

rev 49522 : [mq]: event_rebased
rev 49523 : [mq]: heap9
61 lines changed: 61 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorIllegalArgumentTest.java

rev 49522 : [mq]: event_rebased
rev 49523 : [mq]: heap9
44 lines changed: 44 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorInterpreterArrayTest.java

rev 49522 : [mq]: event_rebased
rev 49523 : [mq]: heap9
32 lines changed: 32 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorInterpreterObjectTest.java

rev 49522 : [mq]: event_rebased
rev 49523 : [mq]: heap9
32 lines changed: 32 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorNoCapabilityTest.java

rev 49522 : [mq]: event_rebased
rev 49523 : [mq]: heap9
44 lines changed: 44 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorOnlyOneAgent.java

rev 49524 : [mq]: heap11
46 lines changed: 46 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorStatArrayCorrectnessTest.java

rev 49522 : [mq]: event_rebased
rev 49523 : [mq]: heap9
85 lines changed: 85 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorStatObjectCorrectnessTest.java

rev 49522 : [mq]: event_rebased
rev 49523 : [mq]: heap9
139 lines changed: 139 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorStatRateTest.java

rev 49522 : [mq]: event_rebased
rev 49523 : [mq]: heap9
66 lines changed: 66 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorStatSimpleTest.java

rev 49522 : [mq]: event_rebased
rev 49523 : [mq]: heap9
50 lines changed: 50 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorTest.java

rev 49522 : [mq]: event_rebased
rev 49523 : [mq]: heap9
70 lines changed: 70 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorThreadOnOffTest.java

rev 49522 : [mq]: event_rebased
rev 49523 : [mq]: heap9
128 lines changed: 128 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorThreadTest.java

rev 49522 : [mq]: event_rebased
rev 49523 : [mq]: heap9
55 lines changed: 55 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/ThreadInformation.java

rev 49523 : [mq]: heap9
183 lines changed: 183 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/libHeapMonitorTest.c

rev 49522 : [mq]: event_rebased
rev 49523 : [mq]: heap9
rev 49524 : [mq]: heap11
867 lines changed: 867 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using ./webrev.ksh (vers 25.16-hg+openjdk.java.net).