Code Review for jdkhs-heap

Prepared by:jcbeyler on Thu Mar 8 15:53:40 PST 2018
Workspace:/usr/local/google/home/jcbeyler/mercurial/jdkhs-heap
Compare against: http://hg.openjdk.java.net/jdk/hs
Compare against version:-2
Summary of changes: 937 lines changed: 701 ins; 111 del; 125 mod; 33652 unchg
Patch of changes: jdkhs-heap.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/collectedHeap.cpp

rev 48551 : [mq]: heap8
rev 48552 : [mq]: heap10a
rev 48553 : [mq]: heap14_rebased
rev 48557 : [mq]: heap17
rev 48562 : [mq]: heap23
rev 48563 : [mq]: heap_to_thread
rev 48564 : [mq]: update-spec
rev 48565 : [mq]: event
1 line changed: 0 ins; 0 del; 1 mod; 636 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/collectedHeap.inline.hpp

rev 48551 : [mq]: heap8
rev 48559 : [mq]: heap20
rev 48562 : [mq]: heap23
rev 48563 : [mq]: heap_to_thread
rev 48564 : [mq]: update-spec
rev 48565 : [mq]: event
1 line changed: 0 ins; 0 del; 1 mod; 341 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/threadLocalAllocBuffer.cpp

rev 48551 : [mq]: heap8
rev 48553 : [mq]: heap14_rebased
rev 48559 : [mq]: heap20
rev 48562 : [mq]: heap23
rev 48563 : [mq]: heap_to_thread
rev 48564 : [mq]: update-spec
rev 48565 : [mq]: event
23 lines changed: 0 ins; 20 del; 3 mod; 483 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/threadLocalAllocBuffer.hpp

rev 48551 : [mq]: heap8
rev 48553 : [mq]: heap14_rebased
rev 48558 : [mq]: heap19
rev 48562 : [mq]: heap23
rev 48563 : [mq]: heap_to_thread
rev 48564 : [mq]: update-spec
rev 48565 : [mq]: event
8 lines changed: 1 ins; 4 del; 3 mod; 279 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/runtime.cpp

rev 48565 : [mq]: event
8 lines changed: 8 ins; 0 del; 0 mod; 1686 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/prims/jvmti.xml

rev 48551 : [mq]: heap8
rev 48552 : [mq]: heap10a
rev 48556 : [mq]: heap17
rev 48559 : [mq]: heap20
rev 48562 : [mq]: heap23
rev 48564 : [mq]: update-spec
rev 48565 : [mq]: event
100 lines changed: 73 ins; 1 del; 26 mod; 15140 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/prims/jvmtiEventController.cpp

rev 48565 : [mq]: event
2 lines changed: 2 ins; 0 del; 0 mod; 1077 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/prims/jvmtiExport.cpp

rev 48565 : [mq]: event
129 lines changed: 96 ins; 9 del; 24 mod; 2833 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/prims/jvmtiExport.hpp

rev 48565 : [mq]: event
57 lines changed: 44 ins; 5 del; 8 mod; 560 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/prims/jvmtiManageCapabilities.cpp

rev 48551 : [mq]: heap8
rev 48565 : [mq]: event
3 lines changed: 3 ins; 0 del; 0 mod; 467 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/prims/jvmtiThreadState.cpp

rev 48565 : [mq]: event
1 line changed: 1 ins; 0 del; 0 mod; 401 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/prims/jvmtiThreadState.hpp

rev 48565 : [mq]: event
8 lines changed: 8 ins; 0 del; 0 mod; 408 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/heapMonitoring.cpp

rev 48551 : [mq]: heap8
rev 48552 : [mq]: heap10a
rev 48553 : [mq]: heap14_rebased
rev 48555 : [mq]: heap16
rev 48556 : [mq]: heap17
rev 48557 : [mq]: heap17
rev 48558 : [mq]: heap19
rev 48559 : [mq]: heap20
rev 48560 : [mq]: heap21
rev 48562 : [mq]: heap23
rev 48564 : [mq]: update-spec
rev 48565 : [mq]: event
85 lines changed: 19 ins; 16 del; 50 mod; 841 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/heapMonitoring.hpp

rev 48551 : [mq]: heap8
rev 48552 : [mq]: heap10a
rev 48553 : [mq]: heap14_rebased
rev 48555 : [mq]: heap16
rev 48556 : [mq]: heap17
rev 48557 : [mq]: heap17
rev 48560 : [mq]: heap21
rev 48562 : [mq]: heap23
rev 48564 : [mq]: update-spec
rev 48565 : [mq]: event
1 line changed: 0 ins; 0 del; 1 mod; 113 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/thread.cpp

rev 48563 : [mq]: heap_to_thread
rev 48564 : [mq]: update-spec
rev 48565 : [mq]: event
36 lines changed: 1 ins; 35 del; 0 mod; 5020 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/thread.hpp

rev 48562 : [mq]: heap23
rev 48563 : [mq]: heap_to_thread
rev 48564 : [mq]: update-spec
rev 48565 : [mq]: event
8 lines changed: 2 ins; 5 del; 1 mod; 2262 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitor.java

rev 48552 : [mq]: heap10a
rev 48553 : [mq]: heap14_rebased
rev 48556 : [mq]: heap17
rev 48557 : [mq]: heap17
rev 48561 : [mq]: heap22
rev 48565 : [mq]: event
4 lines changed: 4 ins; 0 del; 0 mod; 150 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorCachedTest.java

rev 48556 : [mq]: heap17
rev 48561 : [mq]: heap22
rev 48565 : [mq]: event
3 lines changed: 1 ins; 0 del; 2 mod; 80 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/libHeapMonitor.c

rev 48551 : [mq]: heap8
rev 48552 : [mq]: heap10a
rev 48553 : [mq]: heap14_rebased
rev 48556 : [mq]: heap17
rev 48557 : [mq]: heap17
rev 48560 : [mq]: heap21
rev 48561 : [mq]: heap22
rev 48562 : [mq]: heap23
rev 48564 : [mq]: update-spec
rev 48565 : [mq]: event
238 lines changed: 217 ins; 16 del; 5 mod; 875 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/hotspot/share/runtime/threadHeapSampler.cpp

rev 48565 : [mq]: event
53 lines changed: 53 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/hotspot/share/runtime/threadHeapSampler.hpp

rev 48565 : [mq]: event
49 lines changed: 49 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorEventNoCapabilityTest.java

rev 48565 : [mq]: event
54 lines changed: 54 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorEventTest.java

rev 48565 : [mq]: event
65 lines changed: 65 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using ./webrev.ksh (vers 25.16-hg+openjdk.java.net).