jdkhs-heap

Code Review for jdkhs-heap

Prepared by:	jcbeyler on Thu Mar 8 15:51:19 PST 2018
Workspace:	/usr/local/google/home/jcbeyler/mercurial/jdkhs-heap
Compare against:	http://hg.openjdk.java.net/jdk/hs
Compare against version:	48550
Summary of changes:	4598 lines changed: 4502 ins; 16 del; 80 mod; 103968 unchg
Changeset:	jdkhs-heap.changeset
Legend:	Modified file Deleted file New file

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw make/test/JtregNativeHotspot.gmk

rev 48551 : [mq]: heap8
1 line changed: 1 ins; 0 del; 0 mod; 169 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp

rev 48562 : [mq]: heap23
4 lines changed: 0 ins; 0 del; 4 mod; 5597 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/arm/macroAssembler_arm.cpp

rev 48562 : [mq]: heap23
3 lines changed: 0 ins; 0 del; 3 mod; 3337 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/arm/templateTable_arm.cpp

rev 48562 : [mq]: heap23
1 line changed: 0 ins; 0 del; 1 mod; 5035 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/ppc/macroAssembler_ppc.cpp

rev 48562 : [mq]: heap23
1 line changed: 0 ins; 0 del; 1 mod; 5614 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/ppc/templateTable_ppc_64.cpp

rev 48562 : [mq]: heap23
1 line changed: 0 ins; 0 del; 1 mod; 4144 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/s390/macroAssembler_s390.cpp

rev 48562 : [mq]: heap23
1 line changed: 0 ins; 0 del; 1 mod; 7468 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/s390/templateTable_s390.cpp

rev 48562 : [mq]: heap23
1 line changed: 0 ins; 0 del; 1 mod; 4254 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/sparc/macroAssembler_sparc.cpp

rev 48562 : [mq]: heap23
4 lines changed: 0 ins; 0 del; 4 mod; 5160 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/sparc/templateTable_sparc.cpp

rev 48562 : [mq]: heap23
1 line changed: 0 ins; 0 del; 1 mod; 3730 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/x86/macroAssembler_x86.cpp

rev 48562 : [mq]: heap23
4 lines changed: 0 ins; 0 del; 4 mod; 11356 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/x86/templateTable_x86.cpp

rev 48562 : [mq]: heap23
1 line changed: 0 ins; 0 del; 1 mod; 4407 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shared/collectedHeap.cpp

rev 48551 : [mq]: heap8
rev 48552 : [mq]: heap10a
rev 48553 : [mq]: heap14_rebased
rev 48557 : [mq]: heap17
rev 48562 : [mq]: heap23
rev 48563 : [mq]: heap_to_thread
rev 48564 : [mq]: update-spec
rev 48565 : [mq]: event

21 lines changed: 20 ins; 0 del; 1 mod; 616 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shared/collectedHeap.hpp

rev 48551 : [mq]: heap8
rev 48552 : [mq]: heap10a
rev 48553 : [mq]: heap14_rebased
rev 48564 : [mq]: update-spec

0 lines changed: 0 ins; 0 del; 0 mod; 689 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shared/collectedHeap.inline.hpp

rev 48551 : [mq]: heap8
rev 48559 : [mq]: heap20
rev 48562 : [mq]: heap23
rev 48563 : [mq]: heap_to_thread
rev 48564 : [mq]: update-spec
rev 48565 : [mq]: event

7 lines changed: 5 ins; 0 del; 2 mod; 335 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shared/threadLocalAllocBuffer.cpp

rev 48551 : [mq]: heap8
rev 48553 : [mq]: heap14_rebased
rev 48559 : [mq]: heap20
rev 48562 : [mq]: heap23
rev 48563 : [mq]: heap_to_thread
rev 48564 : [mq]: update-spec
rev 48565 : [mq]: event

56 lines changed: 51 ins; 0 del; 5 mod; 430 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shared/threadLocalAllocBuffer.hpp

rev 48551 : [mq]: heap8
rev 48553 : [mq]: heap14_rebased
rev 48558 : [mq]: heap19
rev 48562 : [mq]: heap23
rev 48563 : [mq]: heap_to_thread
rev 48564 : [mq]: update-spec
rev 48565 : [mq]: event

26 lines changed: 18 ins; 1 del; 7 mod; 258 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shared/threadLocalAllocBuffer.inline.hpp

rev 48562 : [mq]: heap23
1 line changed: 0 ins; 0 del; 1 mod; 96 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shared/weakProcessor.cpp

rev 48554 : [mq]: heap_port
rev 48555 : [mq]: heap16
rev 48556 : [mq]: heap17
5 lines changed: 5 ins; 0 del; 0 mod; 41 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/jvmci/vmStructs_jvmci.cpp

rev 48562 : [mq]: heap23
1 line changed: 0 ins; 0 del; 1 mod; 977 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/opto/macro.cpp

rev 48562 : [mq]: heap23
2 lines changed: 0 ins; 0 del; 2 mod; 2801 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/opto/runtime.cpp

rev 48565 : [mq]: event
8 lines changed: 8 ins; 0 del; 0 mod; 1686 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/prims/jvmti.xml

rev 48551 : [mq]: heap8
rev 48552 : [mq]: heap10a
rev 48556 : [mq]: heap17
rev 48559 : [mq]: heap20
rev 48562 : [mq]: heap23
rev 48564 : [mq]: update-spec
rev 48565 : [mq]: event

411 lines changed: 406 ins; 0 del; 5 mod; 14828 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/prims/jvmtiEnv.cpp

rev 48551 : [mq]: heap8
rev 48552 : [mq]: heap10a
rev 48556 : [mq]: heap17
rev 48562 : [mq]: heap23
rev 48564 : [mq]: update-spec

87 lines changed: 87 ins; 0 del; 0 mod; 3710 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/prims/jvmtiEventController.cpp

rev 48565 : [mq]: event
2 lines changed: 2 ins; 0 del; 0 mod; 1077 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/prims/jvmtiExport.cpp

rev 48565 : [mq]: event
129 lines changed: 96 ins; 9 del; 24 mod; 2833 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/prims/jvmtiExport.hpp

rev 48565 : [mq]: event
57 lines changed: 44 ins; 5 del; 8 mod; 560 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/prims/jvmtiManageCapabilities.cpp

rev 48551 : [mq]: heap8
rev 48565 : [mq]: event
6 lines changed: 6 ins; 0 del; 0 mod; 464 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/prims/jvmtiThreadState.cpp

rev 48565 : [mq]: event
1 line changed: 1 ins; 0 del; 0 mod; 401 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/prims/jvmtiThreadState.hpp

rev 48565 : [mq]: event
8 lines changed: 8 ins; 0 del; 0 mod; 408 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/runtime/mutexLocker.cpp

rev 48552 : [mq]: heap10a
rev 48553 : [mq]: heap14_rebased
7 lines changed: 7 ins; 0 del; 0 mod; 330 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/runtime/mutexLocker.hpp

rev 48552 : [mq]: heap10a
rev 48553 : [mq]: heap14_rebased
3 lines changed: 3 ins; 0 del; 0 mod; 367 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/runtime/thread.cpp

rev 48563 : [mq]: heap_to_thread
rev 48564 : [mq]: update-spec
rev 48565 : [mq]: event
3 lines changed: 2 ins; 1 del; 0 mod; 5019 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/runtime/thread.hpp

rev 48562 : [mq]: heap23
rev 48563 : [mq]: heap_to_thread
rev 48564 : [mq]: update-spec
rev 48565 : [mq]: event

5 lines changed: 4 ins; 0 del; 1 mod; 2260 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/runtime/vmStructs.cpp

rev 48562 : [mq]: heap23
1 line changed: 0 ins; 0 del; 1 mod; 3511 unchg

------ ------ ------ ------ ------ --- New ----- Raw src/hotspot/share/prims/jvmtiHeapTransition.hpp

rev 48551 : [mq]: heap8
rev 48557 : [mq]: heap17
rev 48560 : [mq]: heap21
63 lines changed: 63 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw src/hotspot/share/runtime/heapMonitoring.cpp

rev 48551 : [mq]: heap8
rev 48552 : [mq]: heap10a
rev 48553 : [mq]: heap14_rebased
rev 48555 : [mq]: heap16
rev 48556 : [mq]: heap17
rev 48557 : [mq]: heap17
rev 48558 : [mq]: heap19
rev 48559 : [mq]: heap20
rev 48560 : [mq]: heap21
rev 48562 : [mq]: heap23
rev 48564 : [mq]: update-spec
rev 48565 : [mq]: event

910 lines changed: 910 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw src/hotspot/share/runtime/heapMonitoring.hpp

rev 48551 : [mq]: heap8
rev 48552 : [mq]: heap10a
rev 48553 : [mq]: heap14_rebased
rev 48555 : [mq]: heap16
rev 48556 : [mq]: heap17
rev 48557 : [mq]: heap17
rev 48560 : [mq]: heap21
rev 48562 : [mq]: heap23
rev 48564 : [mq]: update-spec
rev 48565 : [mq]: event

114 lines changed: 114 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw src/hotspot/share/runtime/threadHeapSampler.cpp

rev 48565 : [mq]: event
53 lines changed: 53 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw src/hotspot/share/runtime/threadHeapSampler.hpp

rev 48565 : [mq]: event
49 lines changed: 49 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/Frame.java

rev 48551 : [mq]: heap8
38 lines changed: 38 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitor.java

rev 48552 : [mq]: heap10a
rev 48553 : [mq]: heap14_rebased
rev 48556 : [mq]: heap17
rev 48557 : [mq]: heap17
rev 48561 : [mq]: heap22
rev 48565 : [mq]: event

154 lines changed: 154 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorCachedTest.java

rev 48556 : [mq]: heap17
rev 48561 : [mq]: heap22
rev 48565 : [mq]: event
83 lines changed: 83 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorEventNoCapabilityTest.java

rev 48565 : [mq]: event
54 lines changed: 54 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorEventTest.java

rev 48565 : [mq]: event
65 lines changed: 65 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorFrequentTest.java

rev 48551 : [mq]: heap8
rev 48552 : [mq]: heap10a
rev 48561 : [mq]: heap22
76 lines changed: 76 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorNoCapabilityTest.java

rev 48551 : [mq]: heap8
rev 48552 : [mq]: heap10a
54 lines changed: 54 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorOnOffTest.java

rev 48551 : [mq]: heap8
rev 48552 : [mq]: heap10a
rev 48556 : [mq]: heap17
rev 48561 : [mq]: heap22

58 lines changed: 58 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorRecentTest.java

rev 48551 : [mq]: heap8
rev 48552 : [mq]: heap10a
rev 48561 : [mq]: heap22
75 lines changed: 75 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorStackDepthTest.java

rev 48552 : [mq]: heap10a
rev 48556 : [mq]: heap17
rev 48561 : [mq]: heap22
rev 48562 : [mq]: heap23

91 lines changed: 91 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorStatArrayCorrectnessTest.java

rev 48553 : [mq]: heap14_rebased
84 lines changed: 84 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorStatObjectCorrectnessCMSTest.java

rev 48560 : [mq]: heap21
32 lines changed: 32 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorStatObjectCorrectnessParallelTest.java

rev 48560 : [mq]: heap21
32 lines changed: 32 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorStatObjectCorrectnessSerialTest.java

rev 48560 : [mq]: heap21
32 lines changed: 32 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorStatObjectCorrectnessTest.java

rev 48553 : [mq]: heap14_rebased
rev 48561 : [mq]: heap22
114 lines changed: 114 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorStatRateTest.java

rev 48552 : [mq]: heap10a
rev 48555 : [mq]: heap16
60 lines changed: 60 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorStatSimpleTest.java

rev 48551 : [mq]: heap8
rev 48552 : [mq]: heap10a
49 lines changed: 49 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorTest.java

rev 48551 : [mq]: heap8
rev 48552 : [mq]: heap10a
rev 48556 : [mq]: heap17
56 lines changed: 56 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorThreadOnOffTest.java

rev 48552 : [mq]: heap10a
rev 48557 : [mq]: heap17
127 lines changed: 127 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorThreadTest.java

rev 48552 : [mq]: heap10a
rev 48557 : [mq]: heap17
108 lines changed: 108 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/libHeapMonitor.c

rev 48551 : [mq]: heap8
rev 48552 : [mq]: heap10a
rev 48553 : [mq]: heap14_rebased
rev 48556 : [mq]: heap17
rev 48557 : [mq]: heap17
rev 48560 : [mq]: heap21
rev 48561 : [mq]: heap22
rev 48562 : [mq]: heap23
rev 48564 : [mq]: update-spec
rev 48565 : [mq]: event

1097 lines changed: 1097 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using ./webrev.ksh (vers 25.16-hg+openjdk.java.net).