Code Review for jdk12-assign2

Prepared by:jcbeyler jcbeyler on Thu Oct 25 08:50:14 PDT 2018
Workspace:/usr/local/google/home/jcbeyler/mercurial/jdk12-assign2
Compare against: ssh://hg.openjdk.java.net/jdk/jdk
Compare against version:52284
Summary of changes: 295 lines changed: 124 ins; 2 del; 169 mod; 15195 unchg
Changeset: jdk12-assign2.changeset
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/hotspot/jtreg/vmTestbase/nsk/aod/VirtualMachine/VirtualMachine09/agent00.cpp 

rev 52285 : 8212884: Remove the assignments in ifs for vmTestbase/[a-s]
Summary: Extract assignments from if statements in vmTestbase
Reviewed-by: cjplummer, sspitsyn
4 lines changed: 2 ins; 0 del; 2 mod; 67 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/hotspot/jtreg/vmTestbase/nsk/jvmti/AttachOnDemand/attach002/attach002Agent00.cpp 

rev 52285 : 8212884: Remove the assignments in ifs for vmTestbase/[a-s]
Summary: Extract assignments from if statements in vmTestbase
Reviewed-by: cjplummer, sspitsyn
8 lines changed: 3 ins; 0 del; 5 mod; 237 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/hotspot/jtreg/vmTestbase/nsk/jvmti/AttachOnDemand/attach002a/attach002aAgent00.cpp 

rev 52285 : 8212884: Remove the assignments in ifs for vmTestbase/[a-s]
Summary: Extract assignments from if statements in vmTestbase
Reviewed-by: cjplummer, sspitsyn
6 lines changed: 3 ins; 0 del; 3 mod; 128 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/hotspot/jtreg/vmTestbase/nsk/jvmti/AttachOnDemand/attach008/attach008Agent00.cpp 

rev 52285 : 8212884: Remove the assignments in ifs for vmTestbase/[a-s]
Summary: Extract assignments from if statements in vmTestbase
Reviewed-by: cjplummer, sspitsyn
6 lines changed: 3 ins; 0 del; 3 mod; 146 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/hotspot/jtreg/vmTestbase/nsk/jvmti/AttachOnDemand/attach009/attach009Agent00.cpp 

rev 52285 : 8212884: Remove the assignments in ifs for vmTestbase/[a-s]
Summary: Extract assignments from if statements in vmTestbase
Reviewed-by: cjplummer, sspitsyn
6 lines changed: 3 ins; 0 del; 3 mod; 157 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/hotspot/jtreg/vmTestbase/nsk/jvmti/AttachOnDemand/attach012/attach012Agent00.cpp 

rev 52285 : 8212884: Remove the assignments in ifs for vmTestbase/[a-s]
Summary: Extract assignments from if statements in vmTestbase
Reviewed-by: cjplummer, sspitsyn
6 lines changed: 3 ins; 0 del; 3 mod; 89 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/hotspot/jtreg/vmTestbase/nsk/jvmti/AttachOnDemand/attach014/attach014Agent00.cpp 

rev 52285 : 8212884: Remove the assignments in ifs for vmTestbase/[a-s]
Summary: Extract assignments from if statements in vmTestbase
Reviewed-by: cjplummer, sspitsyn
6 lines changed: 3 ins; 0 del; 3 mod; 120 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/hotspot/jtreg/vmTestbase/nsk/jvmti/AttachOnDemand/attach015/attach015Agent00.cpp 

rev 52285 : 8212884: Remove the assignments in ifs for vmTestbase/[a-s]
Summary: Extract assignments from if statements in vmTestbase
Reviewed-by: cjplummer, sspitsyn
6 lines changed: 3 ins; 0 del; 3 mod; 112 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/hotspot/jtreg/vmTestbase/nsk/jvmti/AttachOnDemand/attach015/attach015Agent01.cpp 

rev 52285 : 8212884: Remove the assignments in ifs for vmTestbase/[a-s]
Summary: Extract assignments from if statements in vmTestbase
Reviewed-by: cjplummer, sspitsyn
6 lines changed: 3 ins; 0 del; 3 mod; 112 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/hotspot/jtreg/vmTestbase/nsk/jvmti/AttachOnDemand/attach020/attach020Agent00.cpp 

rev 52285 : 8212884: Remove the assignments in ifs for vmTestbase/[a-s]
Summary: Extract assignments from if statements in vmTestbase
Reviewed-by: cjplummer, sspitsyn
8 lines changed: 4 ins; 0 del; 4 mod; 186 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/hotspot/jtreg/vmTestbase/nsk/jvmti/AttachOnDemand/attach021/attach021Agent00.cpp 

rev 52285 : 8212884: Remove the assignments in ifs for vmTestbase/[a-s]
Summary: Extract assignments from if statements in vmTestbase
Reviewed-by: cjplummer, sspitsyn
8 lines changed: 3 ins; 0 del; 5 mod; 162 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/hotspot/jtreg/vmTestbase/nsk/jvmti/AttachOnDemand/attach022/attach022Agent00.cpp 

rev 52285 : 8212884: Remove the assignments in ifs for vmTestbase/[a-s]
Summary: Extract assignments from if statements in vmTestbase
Reviewed-by: cjplummer, sspitsyn
8 lines changed: 3 ins; 0 del; 5 mod; 224 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/hotspot/jtreg/vmTestbase/nsk/jvmti/AttachOnDemand/attach037/attach037Agent00.cpp 

rev 52285 : 8212884: Remove the assignments in ifs for vmTestbase/[a-s]
Summary: Extract assignments from if statements in vmTestbase
Reviewed-by: cjplummer, sspitsyn
6 lines changed: 3 ins; 0 del; 3 mod; 145 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/hotspot/jtreg/vmTestbase/nsk/jvmti/AttachOnDemand/attach038/attach038Agent00.cpp 

rev 52285 : 8212884: Remove the assignments in ifs for vmTestbase/[a-s]
Summary: Extract assignments from if statements in vmTestbase
Reviewed-by: cjplummer, sspitsyn
6 lines changed: 3 ins; 0 del; 3 mod; 135 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/hotspot/jtreg/vmTestbase/nsk/jvmti/AttachOnDemand/attach039/attach039Agent00.cpp 

rev 52285 : 8212884: Remove the assignments in ifs for vmTestbase/[a-s]
Summary: Extract assignments from if statements in vmTestbase
Reviewed-by: cjplummer, sspitsyn
8 lines changed: 4 ins; 0 del; 4 mod; 174 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/hotspot/jtreg/vmTestbase/nsk/jvmti/AttachOnDemand/attach040/attach040Agent00.cpp 

rev 52285 : 8212884: Remove the assignments in ifs for vmTestbase/[a-s]
Summary: Extract assignments from if statements in vmTestbase
Reviewed-by: cjplummer, sspitsyn
6 lines changed: 3 ins; 0 del; 3 mod; 166 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/hotspot/jtreg/vmTestbase/nsk/jvmti/AttachOnDemand/attach041/attach041Agent00.cpp 

rev 52285 : 8212884: Remove the assignments in ifs for vmTestbase/[a-s]
Summary: Extract assignments from if statements in vmTestbase
Reviewed-by: cjplummer, sspitsyn
6 lines changed: 3 ins; 0 del; 3 mod; 188 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/hotspot/jtreg/vmTestbase/nsk/jvmti/AttachOnDemand/attach042/attach042Agent00.cpp 

rev 52285 : 8212884: Remove the assignments in ifs for vmTestbase/[a-s]
Summary: Extract assignments from if statements in vmTestbase
Reviewed-by: cjplummer, sspitsyn
6 lines changed: 3 ins; 0 del; 3 mod; 152 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/hotspot/jtreg/vmTestbase/nsk/jvmti/AttachOnDemand/attach045/attach045Agent00.cpp 

rev 52285 : 8212884: Remove the assignments in ifs for vmTestbase/[a-s]
Summary: Extract assignments from if statements in vmTestbase
Reviewed-by: cjplummer, sspitsyn
6 lines changed: 3 ins; 0 del; 3 mod; 131 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/hotspot/jtreg/vmTestbase/nsk/jvmti/AttachOnDemand/attach045/attach045Agent01.cpp 

rev 52285 : 8212884: Remove the assignments in ifs for vmTestbase/[a-s]
Summary: Extract assignments from if statements in vmTestbase
Reviewed-by: cjplummer, sspitsyn
6 lines changed: 3 ins; 0 del; 3 mod; 142 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/hotspot/jtreg/vmTestbase/nsk/jvmti/AttachOnDemand/attach045/attach045Agent02.cpp 

rev 52285 : 8212884: Remove the assignments in ifs for vmTestbase/[a-s]
Summary: Extract assignments from if statements in vmTestbase
Reviewed-by: cjplummer, sspitsyn
6 lines changed: 3 ins; 0 del; 3 mod; 163 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/hotspot/jtreg/vmTestbase/nsk/jvmti/AttachOnDemand/attach045/attach045Agent03.cpp 

rev 52285 : 8212884: Remove the assignments in ifs for vmTestbase/[a-s]
Summary: Extract assignments from if statements in vmTestbase
Reviewed-by: cjplummer, sspitsyn
6 lines changed: 3 ins; 0 del; 3 mod; 158 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/hotspot/jtreg/vmTestbase/nsk/jvmti/AttachOnDemand/attach046/attach046Agent00.cpp 

rev 52285 : 8212884: Remove the assignments in ifs for vmTestbase/[a-s]
Summary: Extract assignments from if statements in vmTestbase
Reviewed-by: cjplummer, sspitsyn
8 lines changed: 4 ins; 0 del; 4 mod; 138 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/hotspot/jtreg/vmTestbase/nsk/jvmti/AttachOnDemand/attach050/attach050Agent00.cpp 

rev 52285 : 8212884: Remove the assignments in ifs for vmTestbase/[a-s]
Summary: Extract assignments from if statements in vmTestbase
Reviewed-by: cjplummer, sspitsyn
6 lines changed: 3 ins; 0 del; 3 mod; 92 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/hotspot/jtreg/vmTestbase/nsk/jvmti/AttachOnDemand/sharedAgents/simpleAgent00.cpp 

rev 52285 : 8212884: Remove the assignments in ifs for vmTestbase/[a-s]
Summary: Extract assignments from if statements in vmTestbase
Reviewed-by: cjplummer, sspitsyn
6 lines changed: 3 ins; 0 del; 3 mod; 75 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/hotspot/jtreg/vmTestbase/nsk/jvmti/IterateThroughHeap/abort/Abort.cpp 

rev 52285 : 8212884: Remove the assignments in ifs for vmTestbase/[a-s]
Summary: Extract assignments from if statements in vmTestbase
Reviewed-by: cjplummer, sspitsyn
2 lines changed: 1 ins; 0 del; 1 mod; 156 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/hotspot/jtreg/vmTestbase/nsk/jvmti/IterateThroughHeap/callbacks/Callbacks.cpp 

rev 52285 : 8212884: Remove the assignments in ifs for vmTestbase/[a-s]
Summary: Extract assignments from if statements in vmTestbase
Reviewed-by: cjplummer, sspitsyn
2 lines changed: 1 ins; 0 del; 1 mod; 616 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/hotspot/jtreg/vmTestbase/nsk/jvmti/IterateThroughHeap/concrete-klass-filter/ConcreteKlassFilter.cpp 

rev 52285 : 8212884: Remove the assignments in ifs for vmTestbase/[a-s]
Summary: Extract assignments from if statements in vmTestbase
Reviewed-by: cjplummer, sspitsyn
2 lines changed: 1 ins; 0 del; 1 mod; 299 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/hotspot/jtreg/vmTestbase/nsk/jvmti/IterateThroughHeap/filter-tagged/HeapFilter.cpp 

rev 52285 : 8212884: Remove the assignments in ifs for vmTestbase/[a-s]
Summary: Extract assignments from if statements in vmTestbase
Reviewed-by: cjplummer, sspitsyn
2 lines changed: 1 ins; 0 del; 1 mod; 579 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/hotspot/jtreg/vmTestbase/nsk/jvmti/IterateThroughHeap/non-concrete-klass-filter/NonConcreteKlassFilter.cpp 

rev 52285 : 8212884: Remove the assignments in ifs for vmTestbase/[a-s]
Summary: Extract assignments from if statements in vmTestbase
Reviewed-by: cjplummer, sspitsyn
2 lines changed: 1 ins; 0 del; 1 mod; 238 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/hotspot/jtreg/vmTestbase/nsk/jvmti/ThreadEnd/threadend002/threadend002.cpp 

rev 52285 : 8212884: Remove the assignments in ifs for vmTestbase/[a-s]
Summary: Extract assignments from if statements in vmTestbase
Reviewed-by: cjplummer, sspitsyn
2 lines changed: 1 ins; 0 del; 1 mod; 165 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/allocation/AP04/ap04t003/ap04t003.cpp 

rev 52285 : 8212884: Remove the assignments in ifs for vmTestbase/[a-s]
Summary: Extract assignments from if statements in vmTestbase
Reviewed-by: cjplummer, sspitsyn
16 lines changed: 5 ins; 0 del; 11 mod; 631 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/bcinstr/BI01/bi01t001/bi01t001.cpp 

rev 52285 : 8212884: Remove the assignments in ifs for vmTestbase/[a-s]
Summary: Extract assignments from if statements in vmTestbase
Reviewed-by: cjplummer, sspitsyn
8 lines changed: 2 ins; 0 del; 6 mod; 280 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/bcinstr/BI01/bi01t002/bi01t002.cpp 

rev 52285 : 8212884: Remove the assignments in ifs for vmTestbase/[a-s]
Summary: Extract assignments from if statements in vmTestbase
Reviewed-by: cjplummer, sspitsyn
8 lines changed: 2 ins; 0 del; 6 mod; 293 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/bcinstr/BI04/bi04t002/bi04t002.cpp 

rev 52285 : 8212884: Remove the assignments in ifs for vmTestbase/[a-s]
Summary: Extract assignments from if statements in vmTestbase
Reviewed-by: cjplummer, sspitsyn
6 lines changed: 2 ins; 0 del; 4 mod; 174 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/events/EM01/em01t001/em01t001.cpp 

rev 52285 : 8212884: Remove the assignments in ifs for vmTestbase/[a-s]
Summary: Extract assignments from if statements in vmTestbase
Reviewed-by: cjplummer, sspitsyn
4 lines changed: 2 ins; 0 del; 2 mod; 462 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/events/EM01/em01t002/em01t002.cpp 

rev 52285 : 8212884: Remove the assignments in ifs for vmTestbase/[a-s]
Summary: Extract assignments from if statements in vmTestbase
Reviewed-by: cjplummer, sspitsyn
17 lines changed: 4 ins; 0 del; 13 mod; 544 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/events/EM02/em02t001/em02t001.cpp 

rev 52285 : 8212884: Remove the assignments in ifs for vmTestbase/[a-s]
Summary: Extract assignments from if statements in vmTestbase
Reviewed-by: cjplummer, sspitsyn
26 lines changed: 8 ins; 2 del; 16 mod; 772 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/events/EM02/em02t002/em02t002.cpp 

rev 52285 : 8212884: Remove the assignments in ifs for vmTestbase/[a-s]
Summary: Extract assignments from if statements in vmTestbase
Reviewed-by: cjplummer, sspitsyn
2 lines changed: 1 ins; 0 del; 1 mod; 547 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/events/EM02/em02t003/em02t003.cpp 

rev 52285 : 8212884: Remove the assignments in ifs for vmTestbase/[a-s]
Summary: Extract assignments from if statements in vmTestbase
Reviewed-by: cjplummer, sspitsyn
2 lines changed: 1 ins; 0 del; 1 mod; 586 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/events/EM02/em02t004/em02t004.cpp 

rev 52285 : 8212884: Remove the assignments in ifs for vmTestbase/[a-s]
Summary: Extract assignments from if statements in vmTestbase
Reviewed-by: cjplummer, sspitsyn
2 lines changed: 1 ins; 0 del; 1 mod; 592 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/events/EM02/em02t005/em02t005.cpp 

rev 52285 : 8212884: Remove the assignments in ifs for vmTestbase/[a-s]
Summary: Extract assignments from if statements in vmTestbase
Reviewed-by: cjplummer, sspitsyn
2 lines changed: 1 ins; 0 del; 1 mod; 571 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/events/EM02/em02t006/em02t006.cpp 

rev 52285 : 8212884: Remove the assignments in ifs for vmTestbase/[a-s]
Summary: Extract assignments from if statements in vmTestbase
Reviewed-by: cjplummer, sspitsyn
2 lines changed: 1 ins; 0 del; 1 mod; 522 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/events/EM02/em02t007/em02t007.cpp 

rev 52285 : 8212884: Remove the assignments in ifs for vmTestbase/[a-s]
Summary: Extract assignments from if statements in vmTestbase
Reviewed-by: cjplummer, sspitsyn
2 lines changed: 1 ins; 0 del; 1 mod; 557 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/events/EM02/em02t008/em02t008.cpp 

rev 52285 : 8212884: Remove the assignments in ifs for vmTestbase/[a-s]
Summary: Extract assignments from if statements in vmTestbase
Reviewed-by: cjplummer, sspitsyn
2 lines changed: 1 ins; 0 del; 1 mod; 569 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/events/EM02/em02t009/em02t009.cpp 

rev 52285 : 8212884: Remove the assignments in ifs for vmTestbase/[a-s]
Summary: Extract assignments from if statements in vmTestbase
Reviewed-by: cjplummer, sspitsyn
2 lines changed: 1 ins; 0 del; 1 mod; 577 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/events/EM02/em02t010/em02t010.cpp 

rev 52285 : 8212884: Remove the assignments in ifs for vmTestbase/[a-s]
Summary: Extract assignments from if statements in vmTestbase
Reviewed-by: cjplummer, sspitsyn
8 lines changed: 2 ins; 0 del; 6 mod; 553 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/events/EM02/em02t011/em02t011.cpp 

rev 52285 : 8212884: Remove the assignments in ifs for vmTestbase/[a-s]
Summary: Extract assignments from if statements in vmTestbase
Reviewed-by: cjplummer, sspitsyn
6 lines changed: 2 ins; 0 del; 4 mod; 532 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/events/EM02/em02t012/em02t012.cpp 

rev 52285 : 8212884: Remove the assignments in ifs for vmTestbase/[a-s]
Summary: Extract assignments from if statements in vmTestbase
Reviewed-by: cjplummer, sspitsyn
4 lines changed: 2 ins; 0 del; 2 mod; 537 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/events/EM04/em04t001/em04t001.cpp 

rev 52285 : 8212884: Remove the assignments in ifs for vmTestbase/[a-s]
Summary: Extract assignments from if statements in vmTestbase
Reviewed-by: cjplummer, sspitsyn
4 lines changed: 2 ins; 0 del; 2 mod; 244 unchg

This code review page was prepared using ./webrev.ksh (vers 25.16-hg+openjdk.java.net).