Code Review for rt

Prepared by:jgiles on Fri May 5 11:01:05 NZST 2017
Workspace:/Users/jonathan/Code/JavaFX-10/rt
Compare against version:-2
Summary of changes: 992 lines changed: 856 ins; 95 del; 41 mod; 36722 unchg
Patch of changes: rt.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.controls/src/main/java/javafx/scene/control/Cell.java

rev 10463 : 8089514: [TableView, TreeView, ListView, TreeTableView] Clicking outside of the edited cell, node, or entry should commit the value
38 lines changed: 28 ins; 6 del; 4 mod; 774 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.controls/src/main/java/javafx/scene/control/ControlUtils.java

rev 10463 : 8089514: [TableView, TreeView, ListView, TreeTableView] Clicking outside of the edited cell, node, or entry should commit the value
30 lines changed: 22 ins; 2 del; 6 mod; 220 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.controls/src/main/java/javafx/scene/control/ListCell.java

rev 10463 : 8089514: [TableView, TreeView, ListView, TreeTableView] Clicking outside of the edited cell, node, or entry should commit the value
39 lines changed: 13 ins; 21 del; 5 mod; 581 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.controls/src/main/java/javafx/scene/control/ListView.java

rev 10463 : 8089514: [TableView, TreeView, ListView, TreeTableView] Clicking outside of the edited cell, node, or entry should commit the value
18 lines changed: 16 ins; 2 del; 0 mod; 1676 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.controls/src/main/java/javafx/scene/control/TableCell.java

rev 10463 : 8089514: [TableView, TreeView, ListView, TreeTableView] Clicking outside of the edited cell, node, or entry should commit the value
27 lines changed: 8 ins; 16 del; 3 mod; 801 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.controls/src/main/java/javafx/scene/control/TableView.java

rev 10463 : 8089514: [TableView, TreeView, ListView, TreeTableView] Clicking outside of the edited cell, node, or entry should commit the value
17 lines changed: 17 ins; 0 del; 0 mod; 3372 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.controls/src/main/java/javafx/scene/control/TreeCell.java

rev 10463 : 8089514: [TableView, TreeView, ListView, TreeTableView] Clicking outside of the edited cell, node, or entry should commit the value
32 lines changed: 11 ins; 18 del; 3 mod; 702 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.controls/src/main/java/javafx/scene/control/TreeTableCell.java

rev 10463 : 8089514: [TableView, TreeView, ListView, TreeTableView] Clicking outside of the edited cell, node, or entry should commit the value
42 lines changed: 16 ins; 24 del; 2 mod; 785 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.controls/src/main/java/javafx/scene/control/TreeTableView.java

rev 10463 : 8089514: [TableView, TreeView, ListView, TreeTableView] Clicking outside of the edited cell, node, or entry should commit the value
16 lines changed: 16 ins; 0 del; 0 mod; 3705 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.controls/src/main/java/javafx/scene/control/TreeView.java

rev 10463 : 8089514: [TableView, TreeView, ListView, TreeTableView] Clicking outside of the edited cell, node, or entry should commit the value
18 lines changed: 18 ins; 0 del; 0 mod; 1718 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.controls/src/main/java/javafx/scene/control/cell/TextFieldListCell.java

rev 10463 : 8089514: [TableView, TreeView, ListView, TreeTableView] Clicking outside of the edited cell, node, or entry should commit the value
9 lines changed: 9 ins; 0 del; 0 mod; 207 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.controls/src/main/java/javafx/scene/control/cell/TextFieldTableCell.java

rev 10463 : 8089514: [TableView, TreeView, ListView, TreeTableView] Clicking outside of the edited cell, node, or entry should commit the value
9 lines changed: 8 ins; 0 del; 1 mod; 212 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.controls/src/main/java/javafx/scene/control/cell/TextFieldTreeCell.java

rev 10463 : 8089514: [TableView, TreeView, ListView, TreeTableView] Clicking outside of the edited cell, node, or entry should commit the value
8 lines changed: 8 ins; 0 del; 0 mod; 234 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.controls/src/main/java/javafx/scene/control/cell/TextFieldTreeTableCell.java

rev 10463 : 8089514: [TableView, TreeView, ListView, TreeTableView] Clicking outside of the edited cell, node, or entry should commit the value
10 lines changed: 8 ins; 0 del; 2 mod; 213 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.controls/src/test/java/test/javafx/scene/control/ListCellTest.java

rev 10463 : 8089514: [TableView, TreeView, ListView, TreeTableView] Clicking outside of the edited cell, node, or entry should commit the value
2 lines changed: 1 ins; 0 del; 1 mod; 725 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.controls/src/test/java/test/javafx/scene/control/ListViewKeyInputTest.java

rev 10463 : 8089514: [TableView, TreeView, ListView, TreeTableView] Clicking outside of the edited cell, node, or entry should commit the value
9 lines changed: 0 ins; 6 del; 3 mod; 2368 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.controls/src/test/java/test/javafx/scene/control/ListViewTest.java

rev 10463 : 8089514: [TableView, TreeView, ListView, TreeTableView] Clicking outside of the edited cell, node, or entry should commit the value
2 lines changed: 0 ins; 0 del; 2 mod; 1919 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.controls/src/test/java/test/javafx/scene/control/TableViewTest.java

rev 10463 : 8089514: [TableView, TreeView, ListView, TreeTableView] Clicking outside of the edited cell, node, or entry should commit the value
3 lines changed: 0 ins; 0 del; 3 mod; 5426 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.controls/src/test/java/test/javafx/scene/control/TreeCellTest.java

rev 10463 : 8089514: [TableView, TreeView, ListView, TreeTableView] Clicking outside of the edited cell, node, or entry should commit the value
1 line changed: 1 ins; 0 del; 0 mod; 733 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.controls/src/test/java/test/javafx/scene/control/TreeTableViewTest.java

rev 10463 : 8089514: [TableView, TreeView, ListView, TreeTableView] Clicking outside of the edited cell, node, or entry should commit the value
2 lines changed: 0 ins; 0 del; 2 mod; 6307 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.controls/src/test/java/test/javafx/scene/control/TreeViewTest.java

rev 10463 : 8089514: [TableView, TreeView, ListView, TreeTableView] Clicking outside of the edited cell, node, or entry should commit the value
2 lines changed: 0 ins; 0 del; 2 mod; 3622 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.controls/src/test/java/test/javafx/scene/control/cell/TextFieldTableCellTest.java

rev 10463 : 8089514: [TableView, TreeView, ListView, TreeTableView] Clicking outside of the edited cell, node, or entry should commit the value
27 lines changed: 25 ins; 0 del; 2 mod; 422 unchg

------ ------ ------ ------ --- New Patch Raw apps/toys/Hello/src/main/java/hello/HelloCommitOnFocusLoss.java

rev 10463 : 8089514: [TableView, TreeView, ListView, TreeTableView] Clicking outside of the edited cell, node, or entry should commit the value
631 lines changed: 631 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /Users/jonathan/Code/webrev.ksh (vers 25.16-hg+openjdk.java.net).