Code Review for rt

Prepared by:jgiles on Wed Aug 2 10:49:13 NZST 2017
Workspace:/Users/jonathan/Code/JavaFX-10/rt
Compare against version:-2
Summary of changes: 1318 lines changed: 2 ins; 1308 del; 8 mod; 9096 unchg
Patch of changes: rt.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/ContextMenuContent.java

rev 10594 : 8178519: Consider removing two-level focus support from UI controls
Reviewed-by: kcr
9 lines changed: 0 ins; 9 del; 0 mod; 1582 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/behavior/ChoiceBoxBehavior.java

rev 10594 : 8178519: Consider removing two-level focus support from UI controls
Reviewed-by: kcr
17 lines changed: 0 ins; 17 del; 0 mod; 146 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/behavior/ComboBoxBaseBehavior.java

rev 10594 : 8178519: Consider removing two-level focus support from UI controls
Reviewed-by: kcr
25 lines changed: 0 ins; 18 del; 7 mod; 293 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/behavior/ListViewBehavior.java

rev 10594 : 8178519: Consider removing two-level focus support from UI controls
Reviewed-by: kcr
8 lines changed: 0 ins; 8 del; 0 mod; 856 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/behavior/SliderBehavior.java

rev 10594 : 8178519: Consider removing two-level focus support from UI controls
Reviewed-by: kcr
8 lines changed: 0 ins; 8 del; 0 mod; 208 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/behavior/TableViewBehavior.java

rev 10594 : 8178519: Consider removing two-level focus support from UI controls
Reviewed-by: kcr
8 lines changed: 0 ins; 8 del; 0 mod; 163 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/behavior/TextAreaBehavior.java

rev 10594 : 8178519: Consider removing two-level focus support from UI controls
Reviewed-by: kcr
7 lines changed: 0 ins; 7 del; 0 mod; 426 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/behavior/TextFieldBehavior.java

rev 10594 : 8178519: Consider removing two-level focus support from UI controls
Reviewed-by: kcr
7 lines changed: 0 ins; 7 del; 0 mod; 425 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/behavior/ToggleButtonBehavior.java

rev 10594 : 8178519: Consider removing two-level focus support from UI controls
Reviewed-by: kcr
5 lines changed: 0 ins; 4 del; 1 mod; 147 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/skin/Utils.java

rev 10594 : 8178519: Consider removing two-level focus support from UI controls
Reviewed-by: kcr
14 lines changed: 0 ins; 14 del; 0 mod; 784 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.controls/src/main/java/javafx/scene/control/skin/ContextMenuSkin.java

rev 10594 : 8178519: Consider removing two-level focus support from UI controls
Reviewed-by: kcr
8 lines changed: 0 ins; 8 del; 0 mod; 229 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.graphics/src/main/java/com/sun/glass/ui/Application.java

rev 10594 : 8178519: Consider removing two-level focus support from UI controls
Reviewed-by: kcr
4 lines changed: 0 ins; 4 del; 0 mod; 742 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.graphics/src/main/java/com/sun/glass/ui/monocle/MonocleApplication.java

rev 10594 : 8178519: Consider removing two-level focus support from UI controls
Reviewed-by: kcr
5 lines changed: 0 ins; 5 del; 0 mod; 348 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.graphics/src/main/java/com/sun/javafx/application/PlatformImpl.java

rev 10594 : 8178519: Consider removing two-level focus support from UI controls
Reviewed-by: kcr
13 lines changed: 0 ins; 13 del; 0 mod; 922 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.graphics/src/main/java/com/sun/javafx/tk/quantum/QuantumToolkit.java

rev 10594 : 8178519: Consider removing two-level focus support from UI controls
Reviewed-by: kcr
2 lines changed: 0 ins; 2 del; 0 mod; 1595 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.graphics/src/main/java/javafx/application/ConditionalFeature.java

rev 10594 : 8178519: Consider removing two-level focus support from UI controls
Reviewed-by: kcr
2 lines changed: 2 ins; 0 del; 0 mod; 230 unchg

------ ------ ------ ------ Old --- Patch --- modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/behavior/TwoLevelFocusBehavior.java

rev 10594 : 8178519: Consider removing two-level focus support from UI controls
Reviewed-by: kcr
235 lines changed: 0 ins; 235 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/behavior/TwoLevelFocusComboBehavior.java

rev 10594 : 8178519: Consider removing two-level focus support from UI controls
Reviewed-by: kcr
185 lines changed: 0 ins; 185 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/behavior/TwoLevelFocusListBehavior.java

rev 10594 : 8178519: Consider removing two-level focus support from UI controls
Reviewed-by: kcr
207 lines changed: 0 ins; 207 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/behavior/TwoLevelFocusPopupBehavior.java

rev 10594 : 8178519: Consider removing two-level focus support from UI controls
Reviewed-by: kcr
275 lines changed: 0 ins; 275 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- modules/javafx.controls/src/main/resources/com/sun/javafx/scene/control/skin/caspian/two-level-focus.css

rev 10594 : 8178519: Consider removing two-level focus support from UI controls
Reviewed-by: kcr
125 lines changed: 0 ins; 125 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- modules/javafx.controls/src/main/resources/com/sun/javafx/scene/control/skin/modena/two-level-focus.css

rev 10594 : 8178519: Consider removing two-level focus support from UI controls
Reviewed-by: kcr
149 lines changed: 0 ins; 149 del; 0 mod; 0 unchg

This code review page was prepared using /Users/jonathan/Code/webrev.ksh (vers 25.16-hg+openjdk.java.net).