Code Review for langtools

Prepared by: Jan Lahoda (jlahoda) on Tue Jun 2 08:51:52 PDT 2015
Workspace:/scratch/jlahoda/hudson-standalone/.hudson/jobs/dash-platform-patches/workspace/sandbox/langtools
Compare against: http://hg.openjdk.java.net/jdk9/sandbox/langtools
Compare against version:2969
Summary of changes: 88714 lines changed: 88641 ins; 49 del; 24 mod; 12830 unchg
Changeset: langtools.changeset
Author comments:
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/jdk.compiler/share/classes/com/sun/tools/javac/api/BasicJavacTask.java

rev 2989 : JDK-8058150
19 lines changed: 19 ins; 0 del; 0 mod; 205 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/jdk.compiler/share/classes/com/sun/tools/javac/code/ClassFinder.java

rev 2989 : JDK-8058150
24 lines changed: 21 ins; 0 del; 3 mod; 627 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/jdk.compiler/share/classes/com/sun/tools/javac/code/Scope.java

55 lines changed: 0 ins; 46 del; 9 mod; 1012 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/jdk.compiler/share/classes/com/sun/tools/javac/file/JavacFileManager.java

rev 2989 : JDK-8058150
2 lines changed: 2 ins; 0 del; 0 mod; 1055 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/ClassReader.java

rev 2989 : JDK-8058150
21 lines changed: 15 ins; 0 del; 6 mod; 2590 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/jdk.compiler/share/classes/com/sun/tools/javac/main/Arguments.java

rev 2989 : JDK-8058150
98 lines changed: 92 ins; 3 del; 3 mod; 575 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/jdk.compiler/share/classes/com/sun/tools/javac/main/JavaCompiler.java

rev 2989 : JDK-8058150
6 lines changed: 6 ins; 0 del; 0 mod; 1715 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/jdk.compiler/share/classes/com/sun/tools/javac/main/Main.java

rev 2989 : JDK-8058150
2 lines changed: 1 ins; 0 del; 1 mod; 380 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/jdk.compiler/share/classes/com/sun/tools/javac/main/Option.java

rev 2989 : JDK-8058150
36 lines changed: 36 ins; 0 del; 0 mod; 800 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/jdk.compiler/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java

rev 2989 : JDK-8058150
25 lines changed: 24 ins; 0 del; 1 mod; 1475 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/jdk.compiler/share/classes/com/sun/tools/javac/resources/javac.properties

rev 2989 : JDK-8058150
13 lines changed: 13 ins; 0 del; 0 mod; 340 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/tools/lib/ToolBox.java

1 line changed: 0 ins; 0 del; 1 mod; 2056 unchg

------ ------ ------ ------ --- New ----- Raw make/data/symbols/README

rev 2989 : JDK-8058150
3 lines changed: 3 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw make/data/symbols/include.list

311 lines changed: 311 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw make/data/symbols/java.activation-6.sym.txt

28 lines changed: 28 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw make/data/symbols/java.activation-7.sym.txt

79 lines changed: 79 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw make/data/symbols/java.activation-8.sym.txt

201 lines changed: 201 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw make/data/symbols/java.annotations.common-6.sym.txt

31 lines changed: 31 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw make/data/symbols/java.annotations.common-7.sym.txt

46 lines changed: 46 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw make/data/symbols/java.annotations.common-8.sym.txt

63 lines changed: 63 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw make/data/symbols/java.base-6.sym.txt

890 lines changed: 890 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw make/data/symbols/java.base-7.sym.txt

4129 lines changed: 4129 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw make/data/symbols/java.base-8.sym.txt

17692 lines changed: 17692 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw make/data/symbols/java.compiler-6.sym.txt

102 lines changed: 102 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw make/data/symbols/java.compiler-7.sym.txt

344 lines changed: 344 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw make/data/symbols/java.compiler-8.sym.txt

943 lines changed: 943 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw make/data/symbols/java.corba-6.sym.txt

28 lines changed: 28 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw make/data/symbols/java.corba-7.sym.txt

1663 lines changed: 1663 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw make/data/symbols/java.corba-8.sym.txt

5065 lines changed: 5065 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw make/data/symbols/java.datatransfer-6.sym.txt

28 lines changed: 28 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw make/data/symbols/java.datatransfer-7.sym.txt

67 lines changed: 67 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw make/data/symbols/java.datatransfer-8.sym.txt

160 lines changed: 160 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw make/data/symbols/java.desktop-6.sym.txt

1136 lines changed: 1136 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw make/data/symbols/java.desktop-7.sym.txt

4264 lines changed: 4264 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw make/data/symbols/java.desktop-8.sym.txt

28287 lines changed: 28287 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw make/data/symbols/java.instrument-6.sym.txt

28 lines changed: 28 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw make/data/symbols/java.instrument-7.sym.txt

43 lines changed: 43 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw make/data/symbols/java.instrument-8.sym.txt

66 lines changed: 66 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw make/data/symbols/java.logging-6.sym.txt

49 lines changed: 49 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw make/data/symbols/java.logging-7.sym.txt

133 lines changed: 133 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw make/data/symbols/java.logging-8.sym.txt

272 lines changed: 272 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw make/data/symbols/java.management-6.sym.txt

122 lines changed: 122 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw make/data/symbols/java.management-7.sym.txt

675 lines changed: 675 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw make/data/symbols/java.management-8.sym.txt

2473 lines changed: 2473 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw make/data/symbols/java.naming-6.sym.txt

28 lines changed: 28 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw make/data/symbols/java.naming-7.sym.txt

344 lines changed: 344 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw make/data/symbols/java.naming-8.sym.txt

1038 lines changed: 1038 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw make/data/symbols/java.prefs-6.sym.txt

28 lines changed: 28 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw make/data/symbols/java.prefs-7.sym.txt

55 lines changed: 55 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw make/data/symbols/java.prefs-8.sym.txt

164 lines changed: 164 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw make/data/symbols/java.rmi-6.sym.txt

31 lines changed: 31 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw make/data/symbols/java.rmi-7.sym.txt

241 lines changed: 241 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw make/data/symbols/java.rmi-8.sym.txt

531 lines changed: 531 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw make/data/symbols/java.scripting-6.sym.txt

28 lines changed: 28 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw make/data/symbols/java.scripting-7.sym.txt

66 lines changed: 66 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw make/data/symbols/java.scripting-8.sym.txt

201 lines changed: 201 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw make/data/symbols/java.security.jgss-6.sym.txt

30 lines changed: 30 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw make/data/symbols/java.security.jgss-7.sym.txt

76 lines changed: 76 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw make/data/symbols/java.security.jgss-8.sym.txt

298 lines changed: 298 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw make/data/symbols/java.security.sasl-6.sym.txt

28 lines changed: 28 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw make/data/symbols/java.security.sasl-7.sym.txt

59 lines changed: 59 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw make/data/symbols/java.security.sasl-8.sym.txt

115 lines changed: 115 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw make/data/symbols/java.sql-6.sym.txt

65 lines changed: 65 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw make/data/symbols/java.sql-7.sym.txt

326 lines changed: 326 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw make/data/symbols/java.sql-8.sym.txt

1697 lines changed: 1697 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw make/data/symbols/java.sql.rowset-6.sym.txt

74 lines changed: 74 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw make/data/symbols/java.sql.rowset-7.sym.txt

143 lines changed: 143 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw make/data/symbols/java.sql.rowset-8.sym.txt

594 lines changed: 594 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw make/data/symbols/java.transaction-6.sym.txt

28 lines changed: 28 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw make/data/symbols/java.transaction-7.sym.txt

37 lines changed: 37 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw make/data/symbols/java.transaction-8.sym.txt

43 lines changed: 43 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw make/data/symbols/java.xml-6.sym.txt

61 lines changed: 61 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw make/data/symbols/java.xml-7.sym.txt

581 lines changed: 581 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw make/data/symbols/java.xml-8.sym.txt

2206 lines changed: 2206 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw make/data/symbols/java.xml.bind-6.sym.txt

37 lines changed: 37 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw make/data/symbols/java.xml.bind-7.sym.txt

286 lines changed: 286 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw make/data/symbols/java.xml.bind-8.sym.txt

822 lines changed: 822 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw make/data/symbols/java.xml.crypto-6.sym.txt

28 lines changed: 28 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw make/data/symbols/java.xml.crypto-7.sym.txt

193 lines changed: 193 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw make/data/symbols/java.xml.crypto-8.sym.txt

489 lines changed: 489 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw make/data/symbols/java.xml.ws-6.sym.txt

103 lines changed: 103 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw make/data/symbols/java.xml.ws-7.sym.txt

317 lines changed: 317 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw make/data/symbols/java.xml.ws-8.sym.txt

957 lines changed: 957 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw make/data/symbols/jdk.httpserver-6.sym.txt

28 lines changed: 28 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw make/data/symbols/jdk.httpserver-7.sym.txt

96 lines changed: 96 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw make/data/symbols/jdk.httpserver-8.sym.txt

214 lines changed: 214 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw make/data/symbols/jdk.management-6.sym.txt

39 lines changed: 39 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw make/data/symbols/jdk.management-7.sym.txt

63 lines changed: 63 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw make/data/symbols/jdk.management-8.sym.txt

123 lines changed: 123 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw make/data/symbols/jdk.scripting.nashorn-6.sym.txt

28 lines changed: 28 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw make/data/symbols/jdk.scripting.nashorn-7.sym.txt

44 lines changed: 44 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw make/data/symbols/jdk.scripting.nashorn-8.sym.txt

195 lines changed: 195 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw make/data/symbols/jdk.sctp-6.sym.txt

70 lines changed: 70 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw make/data/symbols/jdk.sctp-7.sym.txt

97 lines changed: 97 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw make/data/symbols/jdk.sctp-8.sym.txt

230 lines changed: 230 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw make/data/symbols/jdk.security.auth-6.sym.txt

28 lines changed: 28 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw make/data/symbols/jdk.security.auth-7.sym.txt

90 lines changed: 90 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw make/data/symbols/jdk.security.auth-8.sym.txt

183 lines changed: 183 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw make/data/symbols/jdk.security.jgss-6.sym.txt

36 lines changed: 36 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw make/data/symbols/jdk.security.jgss-7.sym.txt

45 lines changed: 45 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw make/data/symbols/jdk.security.jgss-8.sym.txt

63 lines changed: 63 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw make/data/symbols/symbols

rev 2989 : JDK-8058150
32 lines changed: 32 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw make/gendata/Gendata-jdk.compiler.gmk

rev 2989 : JDK-8058150
72 lines changed: 72 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw make/src/classes/build/tools/symbolgenerator/CreateSymbols.java

rev 2989 : JDK-8058150
2481 lines changed: 2481 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw make/src/classes/build/tools/symbolgenerator/Probe.java

93 lines changed: 93 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw make/test/sym/CreateSymbolsTest.java

132 lines changed: 132 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw make/test/sym/CreateSymbolsTestImpl.java

611 lines changed: 611 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/jdk.compiler/share/classes/META-INF/services/com.sun.tools.javac.platform.PlatformProviderFactory

rev 2989 : JDK-8058150
1 line changed: 1 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/jdk.compiler/share/classes/com/sun/tools/javac/platform/JDKPlatformProviderFactory.java

rev 2989 : JDK-8058150
191 lines changed: 191 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/jdk.compiler/share/classes/com/sun/tools/javac/platform/PlatformProvider.java

rev 2989 : JDK-8058150
124 lines changed: 124 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/jdk.compiler/share/classes/com/sun/tools/javac/platform/PlatformProviderFactory.java

rev 2989 : JDK-8058150
44 lines changed: 44 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/jdk.compiler/share/classes/com/sun/tools/javac/util/Iterators.java

rev 2989 : JDK-8058150
66 lines changed: 66 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw test/tools/javac/options/release/ReleaseOption-release7.out

rev 2989 : JDK-8058150
2 lines changed: 2 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw test/tools/javac/options/release/ReleaseOption.java

rev 2989 : JDK-8058150
10 lines changed: 10 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw test/tools/javac/options/release/ReleaseOptionClashes.java

rev 2989 : JDK-8058150
86 lines changed: 86 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw test/tools/javac/options/release/ReleaseOptionThroughAPI.java

rev 2989 : JDK-8058150
64 lines changed: 64 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw test/tools/javac/platform/PlatformProviderTest.java

rev 2989 : JDK-8058150
220 lines changed: 220 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw test/tools/javac/platform/PlatformProviderTestSource.java

5 lines changed: 5 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw test/tools/javac/sym/ElementStructureTest.java

rev 2989 : JDK-8058150
637 lines changed: 637 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /scratch/jlahoda/hudson-standalone/.hudson/jobs/dash-platform-patches/workspace/webrev/webrev.ksh (vers 25.10-hg+openjdk.java.net).