Code Review for langtools

Prepared by:jlahoda on Mon Feb 6 16:38:23 CET 2017
Workspace:/usr/local/home/lahvac/src/jdk/tl/langtools
Compare against: http://hg.openjdk.java.net/jdk9/dev/langtools
Compare against version:3946
Summary of changes: 1142 lines changed: 720 ins; 334 del; 88 mod; 20594 unchg
Changeset: langtools.changeset
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/java.compiler/share/classes/javax/tools/StandardLocation.java

rev 3947 : imported patch xmodule-to-patch-module
9 lines changed: 8 ins; 0 del; 1 mod; 165 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk.compiler/share/classes/com/sun/tools/javac/code/ClassFinder.java

rev 3947 : imported patch xmodule-to-patch-module
32 lines changed: 19 ins; 0 del; 13 mod; 750 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk.compiler/share/classes/com/sun/tools/javac/code/ModuleFinder.java

rev 3947 : imported patch xmodule-to-patch-module
3 lines changed: 3 ins; 0 del; 0 mod; 370 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk.compiler/share/classes/com/sun/tools/javac/code/Symbol.java

rev 3947 : imported patch xmodule-to-patch-module
1 line changed: 1 ins; 0 del; 0 mod; 2214 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Modules.java

rev 3947 : imported patch xmodule-to-patch-module
101 lines changed: 75 ins; 11 del; 15 mod; 1581 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk.compiler/share/classes/com/sun/tools/javac/file/JavacFileManager.java

rev 3947 : imported patch xmodule-to-patch-module
1 line changed: 0 ins; 0 del; 1 mod; 1159 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk.compiler/share/classes/com/sun/tools/javac/file/Locations.java

rev 3947 : imported patch xmodule-to-patch-module
165 lines changed: 96 ins; 57 del; 12 mod; 1638 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk.compiler/share/classes/com/sun/tools/javac/main/Arguments.java

rev 3947 : imported patch xmodule-to-patch-module
3 lines changed: 0 ins; 3 del; 0 mod; 948 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk.compiler/share/classes/com/sun/tools/javac/main/JavaCompiler.java

rev 3947 : imported patch xmodule-to-patch-module
5 lines changed: 5 ins; 0 del; 0 mod; 1820 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk.compiler/share/classes/com/sun/tools/javac/main/Option.java

rev 3947 : imported patch xmodule-to-patch-module
1 line changed: 0 ins; 0 del; 1 mod; 1313 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler.properties

rev 3947 : imported patch xmodule-to-patch-module
10 lines changed: 4 ins; 0 del; 6 mod; 3048 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/ToolOption.java

rev 3947 : imported patch xmodule-to-patch-module
7 lines changed: 0 ins; 7 del; 0 mod; 438 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk.javadoc/share/classes/com/sun/tools/javadoc/resources/javadoc.properties

rev 3947 : imported patch xmodule-to-patch-module
1 line changed: 0 ins; 1 del; 0 mod; 156 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/tool/ToolOption.java

rev 3947 : imported patch xmodule-to-patch-module
7 lines changed: 0 ins; 7 del; 0 mod; 590 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/tool/resources/javadoc.properties

rev 3947 : imported patch xmodule-to-patch-module
5 lines changed: 0 ins; 5 del; 0 mod; 309 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk.jshell/share/classes/jdk/jshell/MemoryFileManager.java

rev 3947 : imported patch xmodule-to-patch-module
63 lines changed: 20 ins; 43 del; 0 mod; 568 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw test/tools/javac/6627362/T6627362.java

rev 3947 : imported patch xmodule-to-patch-module
2 lines changed: 0 ins; 0 del; 2 mod; 120 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw test/tools/javac/diags/Example.java

rev 3947 : imported patch xmodule-to-patch-module
16 lines changed: 16 ins; 0 del; 0 mod; 727 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw test/tools/javac/diags/examples.not-yet.txt

rev 3947 : imported patch xmodule-to-patch-module
1 line changed: 1 ins; 0 del; 0 mod; 151 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw test/tools/javac/modules/AddLimitMods.java

rev 3947 : imported patch xmodule-to-patch-module
1 line changed: 0 ins; 0 del; 1 mod; 596 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw test/tools/javac/modules/AddReadsTest.java

rev 3947 : imported patch xmodule-to-patch-module
3 lines changed: 0 ins; 0 del; 3 mod; 663 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw test/tools/javac/modules/InheritRuntimeEnvironmentTest.java

rev 3947 : imported patch xmodule-to-patch-module
1 line changed: 0 ins; 0 del; 1 mod; 425 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw test/tools/javac/modules/PatchModulesTest.java

rev 3947 : imported patch xmodule-to-patch-module
57 lines changed: 44 ins; 2 del; 11 mod; 141 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw test/tools/javac/modules/XModuleTest.java

rev 3947 : imported patch xmodule-to-patch-module
192 lines changed: 131 ins; 47 del; 14 mod; 361 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw test/tools/javac/synthesize/Main.java

rev 3947 : imported patch xmodule-to-patch-module
9 lines changed: 5 ins; 3 del; 1 mod; 128 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw test/tools/jdeps/jdkinternals/RemovedJDKInternals.java

rev 3947 : imported patch xmodule-to-patch-module
1 line changed: 0 ins; 0 del; 1 mod; 148 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/tools/javac/6627362/x/java/lang/Object.java (was test/tools/javac/6627362/x/Object.java)

rev 3947 : imported patch xmodule-to-patch-module
0 lines changed: 0 ins; 0 del; 0 mod; 30 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/tools/javac/diags/examples/ModuleInfoWithPatchedModuleClasspath/ModuleInfoWithXmoduleClasspath.java

rev 3947 : imported patch xmodule-to-patch-module
24 lines changed: 24 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/tools/javac/diags/examples/ModuleInfoWithPatchedModuleClasspath/additional/module-info.java (was test/tools/javac/diags/examples/ModuleInfoWithXmoduleClasspath/additional/module-info.java)

rev 3947 : imported patch xmodule-to-patch-module
0 lines changed: 0 ins; 0 del; 0 mod; 24 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/tools/javac/diags/examples/ModuleInfoWithPatchedModuleClasspath/patchmodule/java.compiler/javax/lang/model/element/Extra.java

rev 3947 : imported patch xmodule-to-patch-module
26 lines changed: 26 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/tools/javac/diags/examples/ModuleInfoWithPatchedModuleSourcePath/ModuleInfoWithPatchedModuleSourcePath.java

rev 3947 : imported patch xmodule-to-patch-module
24 lines changed: 24 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/tools/javac/diags/examples/ModuleInfoWithPatchedModuleSourcePath/patchmodule/java.compiler/javax/lang/model/element/Extra.java

rev 3947 : imported patch xmodule-to-patch-module
26 lines changed: 26 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/tools/javac/diags/examples/ModuleInfoWithPatchedModuleSourcePath/patchmodule/java.compiler/module-info.java

rev 3947 : imported patch xmodule-to-patch-module
24 lines changed: 24 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/tools/javac/diags/examples/NoSuperclass/NoSuperclass.java

rev 3947 : imported patch xmodule-to-patch-module
24 lines changed: 24 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/tools/javac/diags/examples/NoSuperclass/patchmodule/java.base/java/lang/Object.java

rev 3947 : imported patch xmodule-to-patch-module
30 lines changed: 30 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/tools/javac/diags/examples/TooManyPatchedModules/TooManyPatchedModules.java

rev 3947 : imported patch xmodule-to-patch-module
24 lines changed: 24 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/tools/javac/diags/examples/TooManyPatchedModules/patchmodule/java.compiler/p/C.java

rev 3947 : imported patch xmodule-to-patch-module
25 lines changed: 25 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/tools/javac/diags/examples/TooManyPatchedModules/patchmodule/jdk.compiler/p/C.java

rev 3947 : imported patch xmodule-to-patch-module
25 lines changed: 25 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw test/tools/javac/meth/BadPolySig/BadPolySig.java (was test/tools/javac/meth/BadPolySig.java)

rev 3947 : imported patch xmodule-to-patch-module
31 lines changed: 24 ins; 6 del; 1 mod; 5 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw test/tools/javac/meth/BadPolySig/java.base/java/lang/invoke/MethodHandle.java (was test/tools/javac/meth/BadPolySig.java)

rev 3947 : imported patch xmodule-to-patch-module
20 lines changed: 16 ins; 0 del; 4 mod; 8 unchg

------ ------ ------ ------ ------ Old --- ----- --- test/tools/javac/diags/examples/ModuleInfoWithXModuleSourcePath/Extra.java

rev 3947 : imported patch xmodule-to-patch-module
29 lines changed: 0 ins; 29 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- ----- --- test/tools/javac/diags/examples/ModuleInfoWithXModuleSourcePath/module-info.java

rev 3947 : imported patch xmodule-to-patch-module
24 lines changed: 0 ins; 24 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- ----- --- test/tools/javac/diags/examples/ModuleInfoWithXmoduleClasspath/ModuleInfoWithXmoduleClasspath.java

rev 3947 : imported patch xmodule-to-patch-module
29 lines changed: 0 ins; 29 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- ----- --- test/tools/javac/diags/examples/NoSuperclass.java

rev 3947 : imported patch xmodule-to-patch-module
33 lines changed: 0 ins; 33 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- ----- --- test/tools/javac/diags/examples/XModuleWithModulePath/XModuleWithModulePath.java

rev 3947 : imported patch xmodule-to-patch-module
27 lines changed: 0 ins; 27 del; 0 mod; 0 unchg

This code review page was prepared using /usr/local/home/lahvac/src/jdk/webrev/webrev.ksh (vers 25.16-hg+openjdk.java.net).