Code Review for jdk

Prepared by:jlaskey on Tue Jun 28 11:35:32 ADT 2016
Workspace:/Volumes/Elephant/Projects/jdk9-dev/jdk
Compare against: ssh://hg.openjdk.java.net/jdk9/dev/jdk
Compare against version:14896
Summary of changes: 171 lines changed: 18 ins; 79 del; 74 mod; 7870 unchg
Changeset: jdk.changeset
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/jdk.jlink/share/classes/jdk/tools/jlink/internal/AbstractModuleEntry.java

rev 14897 : 8160459: jlink minor code clean up
Reviewed-by: sundar
4 lines changed: 0 ins; 3 del; 1 mod; 94 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/jdk.jlink/share/classes/jdk/tools/jlink/internal/Archive.java

rev 14897 : 8160459: jlink minor code clean up
Reviewed-by: sundar
16 lines changed: 0 ins; 5 del; 11 mod; 113 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/jdk.jlink/share/classes/jdk/tools/jlink/internal/ArchiveEntryModuleEntry.java

rev 14897 : 8160459: jlink minor code clean up
Reviewed-by: sundar
3 lines changed: 0 ins; 2 del; 1 mod; 79 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/jdk.jlink/share/classes/jdk/tools/jlink/internal/BasicImageWriter.java

rev 14897 : 8160459: jlink minor code clean up
Reviewed-by: sundar
4 lines changed: 1 ins; 0 del; 3 mod; 187 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/jdk.jlink/share/classes/jdk/tools/jlink/internal/ByteArrayModuleEntry.java

rev 14897 : 8160459: jlink minor code clean up
Reviewed-by: sundar
1 line changed: 0 ins; 1 del; 0 mod; 77 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/jdk.jlink/share/classes/jdk/tools/jlink/internal/DirArchive.java

rev 14897 : 8160459: jlink minor code clean up
Reviewed-by: sundar
3 lines changed: 0 ins; 2 del; 1 mod; 163 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/jdk.jlink/share/classes/jdk/tools/jlink/internal/ImageFileCreator.java

rev 14897 : 8160459: jlink minor code clean up
Reviewed-by: sundar
21 lines changed: 0 ins; 18 del; 3 mod; 323 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/jdk.jlink/share/classes/jdk/tools/jlink/internal/ImagePluginConfiguration.java

rev 14897 : 8160459: jlink minor code clean up
Reviewed-by: sundar
18 lines changed: 0 ins; 0 del; 18 mod; 133 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/jdk.jlink/share/classes/jdk/tools/jlink/internal/ImagePluginStack.java

rev 14897 : 8160459: jlink minor code clean up
Reviewed-by: sundar
23 lines changed: 3 ins; 4 del; 16 mod; 467 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/jdk.jlink/share/classes/jdk/tools/jlink/internal/ImageResourcesTree.java

rev 14897 : 8160459: jlink minor code clean up
Reviewed-by: sundar
10 lines changed: 1 ins; 6 del; 3 mod; 441 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/jdk.jlink/share/classes/jdk/tools/jlink/internal/ImageStringsWriter.java

rev 14897 : 8160459: jlink minor code clean up
Reviewed-by: sundar
14 lines changed: 10 ins; 0 del; 4 mod; 105 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/jdk.jlink/share/classes/jdk/tools/jlink/internal/JarArchive.java

rev 14897 : 8160459: jlink minor code clean up
Reviewed-by: sundar
4 lines changed: 0 ins; 2 del; 2 mod; 141 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/jdk.jlink/share/classes/jdk/tools/jlink/internal/JlinkTask.java

rev 14897 : 8160459: jlink minor code clean up
Reviewed-by: sundar
2 lines changed: 0 ins; 1 del; 1 mod; 552 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/jdk.jlink/share/classes/jdk/tools/jlink/internal/JmodArchive.java

rev 14897 : 8160459: jlink minor code clean up
Reviewed-by: sundar
5 lines changed: 1 ins; 2 del; 2 mod; 84 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/jdk.jlink/share/classes/jdk/tools/jlink/internal/ModularJarArchive.java

rev 14897 : 8160459: jlink minor code clean up
Reviewed-by: sundar
2 lines changed: 1 ins; 0 del; 1 mod; 54 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/jdk.jlink/share/classes/jdk/tools/jlink/internal/ModuleEntryFactory.java

rev 14897 : 8160459: jlink minor code clean up
Reviewed-by: sundar
1 line changed: 0 ins; 1 del; 0 mod; 66 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/jdk.jlink/share/classes/jdk/tools/jlink/internal/ModulePoolImpl.java

rev 14897 : 8160459: jlink minor code clean up
Reviewed-by: sundar
4 lines changed: 0 ins; 2 del; 2 mod; 415 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/jdk.jlink/share/classes/jdk/tools/jlink/internal/PathModuleEntry.java

rev 14897 : 8160459: jlink minor code clean up
Reviewed-by: sundar
3 lines changed: 0 ins; 1 del; 2 mod; 72 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/jdk.jlink/share/classes/jdk/tools/jlink/internal/ResourcePrevisitor.java

rev 14897 : 8160459: jlink minor code clean up
Reviewed-by: sundar
1 line changed: 0 ins; 1 del; 0 mod; 47 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/jdk.jlink/share/classes/jdk/tools/jlink/internal/Utils.java

rev 14897 : 8160459: jlink minor code clean up
Reviewed-by: sundar
1 line changed: 0 ins; 1 del; 0 mod; 152 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/jdk.jlink/share/classes/jdk/tools/jlink/internal/packager/AppRuntimeImageBuilder.java

rev 14897 : 8160459: jlink minor code clean up
Reviewed-by: sundar
1 line changed: 0 ins; 0 del; 1 mod; 138 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/DefaultCompressPlugin.java

rev 14897 : 8160459: jlink minor code clean up
Reviewed-by: sundar
1 line changed: 0 ins; 1 del; 0 mod; 120 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/ExcludeFilesPlugin.java

rev 14897 : 8160459: jlink minor code clean up
Reviewed-by: sundar
3 lines changed: 0 ins; 3 del; 0 mod; 81 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/ExcludePlugin.java

rev 14897 : 8160459: jlink minor code clean up
Reviewed-by: sundar
1 line changed: 0 ins; 1 del; 0 mod; 81 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/ExcludeVMPlugin.java

rev 14897 : 8160459: jlink minor code clean up
Reviewed-by: sundar
2 lines changed: 0 ins; 2 del; 0 mod; 265 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/FileCopierPlugin.java

rev 14897 : 8160459: jlink minor code clean up
Reviewed-by: sundar
2 lines changed: 0 ins; 2 del; 0 mod; 262 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/GenerateJLIClassesPlugin.java

rev 14897 : 8160459: jlink minor code clean up
Reviewed-by: sundar
2 lines changed: 0 ins; 2 del; 0 mod; 219 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/IncludeLocalesPlugin.java

rev 14897 : 8160459: jlink minor code clean up
Reviewed-by: sundar
2 lines changed: 0 ins; 2 del; 0 mod; 354 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/OptimizationPlugin.java

rev 14897 : 8160459: jlink minor code clean up
Reviewed-by: sundar
1 line changed: 0 ins; 1 del; 0 mod; 285 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/OrderResourcesPlugin.java

rev 14897 : 8160459: jlink minor code clean up
Reviewed-by: sundar
2 lines changed: 0 ins; 2 del; 0 mod; 194 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/ReleaseInfoPlugin.java

rev 14897 : 8160459: jlink minor code clean up
Reviewed-by: sundar
1 line changed: 0 ins; 1 del; 0 mod; 125 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/StringSharingPlugin.java

rev 14897 : 8160459: jlink minor code clean up
Reviewed-by: sundar
1 line changed: 0 ins; 1 del; 0 mod; 408 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/StripDebugPlugin.java

rev 14897 : 8160459: jlink minor code clean up
Reviewed-by: sundar
3 lines changed: 0 ins; 3 del; 0 mod; 84 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/StripNativeCommandsPlugin.java

rev 14897 : 8160459: jlink minor code clean up
Reviewed-by: sundar
1 line changed: 0 ins; 1 del; 0 mod; 60 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/SystemModuleDescriptorPlugin.java

rev 14897 : 8160459: jlink minor code clean up
Reviewed-by: sundar
1 line changed: 1 ins; 0 del; 0 mod; 786 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/ZipPlugin.java

rev 14897 : 8160459: jlink minor code clean up
Reviewed-by: sundar
1 line changed: 0 ins; 1 del; 0 mod; 129 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/optim/ControlFlow.java

rev 14897 : 8160459: jlink minor code clean up
Reviewed-by: sundar
6 lines changed: 0 ins; 4 del; 2 mod; 514 unchg

This code review page was prepared using /Volumes/Elephant/Users/jlaskey/local/bin/webrev (vers 25.16-hg+openjdk.java.net).