Code Review for jmc

Prepared by: Joshua Matsuoka (jmatsuok) on Fri Nov 2 16:33:31 EDT 2018
Workspace:/home/jmatsuok/clean-jmc/jmc
Summary of changes: 169 lines changed: 169 ins; 0 del; 0 mod; 7738 unchg
Patch of changes: jmc.patch
Bug id: JMC-5506 : Rule that detects fatal errors in the end of the recording
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/JVMInformationPage.java

2 lines changed: 2 ins; 0 del; 0 mod; 245 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/Messages.java

3 lines changed: 3 ins; 0 del; 0 mod; 543 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/META-INF/services/org.openjdk.jmc.flightrecorder.rules.IRule

1 line changed: 1 ins; 0 del; 0 mod; 87 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages.properties

3 lines changed: 3 ins; 0 del; 0 mod; 612 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/jdk/JdkAggregators.java

5 lines changed: 5 ins; 0 del; 0 mod; 441 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/jdk/JdkAttributes.java

4 lines changed: 4 ins; 0 del; 0 mod; 1190 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/jdk/JdkTypeIDs.java

1 line changed: 1 ins; 0 del; 0 mod; 197 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/jdk/messages/internal/Messages.java

3 lines changed: 3 ins; 0 del; 0 mod; 457 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw core/org.openjdk.jmc.flightrecorder/src/main/resources/org/openjdk/jmc/flightrecorder/jdk/messages/internal/messages.properties

3 lines changed: 3 ins; 0 del; 0 mod; 437 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw core/tests/org.openjdk.jmc.flightrecorder.rules.jdk.test/src/test/resources/baseline/JfrRuleBaseline.xml

63 lines changed: 63 ins; 0 del; 0 mod; 3529 unchg

------ ------ ------ ------ --- New Patch Raw core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/exceptions/FatalErrorRule.java

81 lines changed: 81 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /home/jmatsuok/Downloads/webrev.ksh (vers 25.17-hg+openjdk.java.net).