Code Review for jaxp

Prepared by:joehw on Wed May 8 13:36:30 PDT 2013
Workspace:/u/huizwang/openjdk/jdk8-tl/jaxp
Compare against: ssh://hg.openjdk.java.net/jdk8/tl-gate/jaxp
Summary of changes: 1875 lines changed: 1656 ins; 114 del; 105 mod; 60706 unchg
Patch of changes: jaxp.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/com/sun/org/apache/xalan/internal/XalanConstants.java

94 lines changed: 80 ins; 2 del; 12 mod; 46 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/com/sun/org/apache/xalan/internal/utils/SecuritySupport.java

138 lines changed: 137 ins; 0 del; 1 mod; 205 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/com/sun/org/apache/xalan/internal/xsltc/compiler/Import.java

23 lines changed: 16 ins; 4 del; 3 mod; 149 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/com/sun/org/apache/xalan/internal/xsltc/compiler/Include.java

25 lines changed: 17 ins; 5 del; 3 mod; 148 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/com/sun/org/apache/xalan/internal/xsltc/compiler/Parser.java

42 lines changed: 32 ins; 10 del; 0 mod; 1395 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/com/sun/org/apache/xalan/internal/xsltc/compiler/XSLTC.java

37 lines changed: 37 ins; 0 del; 0 mod; 922 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages.java

6 lines changed: 6 ins; 0 del; 0 mod; 1017 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_ca.java

6 lines changed: 6 ins; 0 del; 0 mod; 858 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_cs.java

6 lines changed: 6 ins; 0 del; 0 mod; 858 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_de.java

6 lines changed: 6 ins; 0 del; 0 mod; 918 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_es.java

6 lines changed: 6 ins; 0 del; 0 mod; 918 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_fr.java

6 lines changed: 6 ins; 0 del; 0 mod; 918 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_it.java

6 lines changed: 6 ins; 0 del; 0 mod; 918 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_ja.java

6 lines changed: 6 ins; 0 del; 0 mod; 918 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_ko.java

6 lines changed: 6 ins; 0 del; 0 mod; 918 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_pt_BR.java

6 lines changed: 6 ins; 0 del; 0 mod; 918 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_sk.java

6 lines changed: 6 ins; 0 del; 0 mod; 858 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_sv.java

6 lines changed: 6 ins; 0 del; 0 mod; 918 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_zh_CN.java

6 lines changed: 6 ins; 0 del; 0 mod; 918 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_zh_TW.java

6 lines changed: 6 ins; 0 del; 0 mod; 918 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMsg.java

1 line changed: 1 ins; 0 del; 0 mod; 324 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/com/sun/org/apache/xalan/internal/xsltc/dom/LoadDocument.java

10 lines changed: 10 ins; 0 del; 0 mod; 295 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/com/sun/org/apache/xalan/internal/xsltc/runtime/AbstractTranslet.java

20 lines changed: 20 ins; 0 del; 0 mod; 775 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/com/sun/org/apache/xalan/internal/xsltc/trax/TemplatesHandlerImpl.java

6 lines changed: 6 ins; 0 del; 0 mod; 344 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/com/sun/org/apache/xalan/internal/xsltc/trax/TemplatesImpl.java

8 lines changed: 8 ins; 0 del; 0 mod; 451 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/com/sun/org/apache/xalan/internal/xsltc/trax/TransformerFactoryImpl.java

48 lines changed: 44 ins; 1 del; 3 mod; 1471 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/com/sun/org/apache/xalan/internal/xsltc/trax/TransformerImpl.java

13 lines changed: 13 ins; 0 del; 0 mod; 1411 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/com/sun/org/apache/xalan/internal/xsltc/trax/Util.java

2 lines changed: 2 ins; 0 del; 0 mod; 224 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/com/sun/org/apache/xerces/internal/dom/DOMConfigurationImpl.java

44 lines changed: 29 ins; 13 del; 2 mod; 1075 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/com/sun/org/apache/xerces/internal/impl/Constants.java

97 lines changed: 97 ins; 0 del; 0 mod; 748 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/com/sun/org/apache/xerces/internal/impl/PropertyManager.java

20 lines changed: 18 ins; 2 del; 0 mod; 169 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/com/sun/org/apache/xerces/internal/impl/XMLDocumentFragmentScannerImpl.java

64 lines changed: 52 ins; 11 del; 1 mod; 3219 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/com/sun/org/apache/xerces/internal/impl/XMLDocumentScannerImpl.java

48 lines changed: 25 ins; 12 del; 11 mod; 1463 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/com/sun/org/apache/xerces/internal/impl/XMLEntityManager.java

138 lines changed: 85 ins; 47 del; 6 mod; 2907 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/com/sun/org/apache/xerces/internal/impl/msg/XIncludeMessages.properties

1 line changed: 0 ins; 0 del; 1 mod; 35 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/com/sun/org/apache/xerces/internal/impl/msg/XIncludeMessages_de.properties

1 line changed: 0 ins; 0 del; 1 mod; 63 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/com/sun/org/apache/xerces/internal/impl/msg/XIncludeMessages_es.properties

1 line changed: 0 ins; 0 del; 1 mod; 63 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/com/sun/org/apache/xerces/internal/impl/msg/XIncludeMessages_fr.properties

1 line changed: 0 ins; 0 del; 1 mod; 63 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/com/sun/org/apache/xerces/internal/impl/msg/XIncludeMessages_it.properties

1 line changed: 0 ins; 0 del; 1 mod; 63 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/com/sun/org/apache/xerces/internal/impl/msg/XIncludeMessages_ja.properties

1 line changed: 0 ins; 0 del; 1 mod; 63 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/com/sun/org/apache/xerces/internal/impl/msg/XIncludeMessages_ko.properties

1 line changed: 0 ins; 0 del; 1 mod; 63 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/com/sun/org/apache/xerces/internal/impl/msg/XIncludeMessages_pt_BR.properties

1 line changed: 0 ins; 0 del; 1 mod; 63 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/com/sun/org/apache/xerces/internal/impl/msg/XIncludeMessages_sv.properties

1 line changed: 0 ins; 0 del; 1 mod; 63 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/com/sun/org/apache/xerces/internal/impl/msg/XIncludeMessages_zh_CN.properties

1 line changed: 0 ins; 0 del; 1 mod; 63 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/com/sun/org/apache/xerces/internal/impl/msg/XIncludeMessages_zh_TW.properties

1 line changed: 0 ins; 0 del; 1 mod; 63 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages.properties

3 lines changed: 3 ins; 0 del; 0 mod; 296 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_de.properties

3 lines changed: 3 ins; 0 del; 0 mod; 324 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_es.properties

3 lines changed: 3 ins; 0 del; 0 mod; 324 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_fr.properties

3 lines changed: 3 ins; 0 del; 0 mod; 324 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_it.properties

3 lines changed: 3 ins; 0 del; 0 mod; 324 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_ja.properties

3 lines changed: 3 ins; 0 del; 0 mod; 324 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_ko.properties

3 lines changed: 3 ins; 0 del; 0 mod; 324 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_pt_BR.properties

3 lines changed: 3 ins; 0 del; 0 mod; 324 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_sv.properties

3 lines changed: 3 ins; 0 del; 0 mod; 324 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_zh_CN.properties

3 lines changed: 3 ins; 0 del; 0 mod; 324 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_zh_TW.properties

3 lines changed: 3 ins; 0 del; 0 mod; 324 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages.properties

4 lines changed: 1 ins; 3 del; 0 mod; 291 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages_de.properties

1 line changed: 1 ins; 0 del; 0 mod; 319 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages_es.properties

1 line changed: 1 ins; 0 del; 0 mod; 319 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages_fr.properties

1 line changed: 1 ins; 0 del; 0 mod; 319 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages_it.properties

1 line changed: 1 ins; 0 del; 0 mod; 319 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages_ja.properties

1 line changed: 1 ins; 0 del; 0 mod; 319 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages_ko.properties

1 line changed: 1 ins; 0 del; 0 mod; 319 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages_pt_BR.properties

1 line changed: 1 ins; 0 del; 0 mod; 319 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages_sv.properties

1 line changed: 1 ins; 0 del; 0 mod; 319 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages_zh_CN.properties

1 line changed: 1 ins; 0 del; 0 mod; 319 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages_zh_TW.properties

1 line changed: 1 ins; 0 del; 0 mod; 319 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/com/sun/org/apache/xerces/internal/impl/xs/XMLSchemaLoader.java

31 lines changed: 30 ins; 0 del; 1 mod; 1353 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/com/sun/org/apache/xerces/internal/impl/xs/XMLSchemaValidator.java

10 lines changed: 8 ins; 0 del; 2 mod; 4306 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/com/sun/org/apache/xerces/internal/impl/xs/XSDDescription.java

12 lines changed: 12 ins; 0 del; 0 mod; 262 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/com/sun/org/apache/xerces/internal/impl/xs/traversers/XSDHandler.java

24 lines changed: 24 ins; 0 del; 0 mod; 4304 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/com/sun/org/apache/xerces/internal/jaxp/DocumentBuilderFactoryImpl.java

8 lines changed: 4 ins; 2 del; 2 mod; 217 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/com/sun/org/apache/xerces/internal/jaxp/DocumentBuilderImpl.java

29 lines changed: 29 ins; 0 del; 0 mod; 374 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/com/sun/org/apache/xerces/internal/jaxp/SAXParserFactoryImpl.java

2 lines changed: 1 ins; 0 del; 1 mod; 212 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/com/sun/org/apache/xerces/internal/jaxp/SAXParserImpl.java

26 lines changed: 26 ins; 0 del; 0 mod; 659 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/com/sun/org/apache/xerces/internal/jaxp/validation/AbstractXMLSchema.java

26 lines changed: 23 ins; 1 del; 2 mod; 84 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/com/sun/org/apache/xerces/internal/jaxp/validation/StreamValidatorHelper.java

3 lines changed: 3 ins; 0 del; 0 mod; 186 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/com/sun/org/apache/xerces/internal/jaxp/validation/ValidatorHandlerImpl.java

4 lines changed: 4 ins; 0 del; 0 mod; 1071 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/com/sun/org/apache/xerces/internal/jaxp/validation/XMLSchemaFactory.java

27 lines changed: 27 ins; 0 del; 0 mod; 493 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/com/sun/org/apache/xerces/internal/jaxp/validation/XMLSchemaValidatorComponentManager.java

9 lines changed: 9 ins; 0 del; 0 mod; 529 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/com/sun/org/apache/xerces/internal/jaxp/validation/XSGrammarPoolContainer.java

17 lines changed: 17 ins; 0 del; 0 mod; 58 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/com/sun/org/apache/xerces/internal/parsers/XML11Configuration.java

43 lines changed: 23 ins; 0 del; 20 mod; 1536 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/com/sun/org/apache/xerces/internal/utils/SecuritySupport.java

139 lines changed: 138 ins; 0 del; 1 mod; 198 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/com/sun/org/apache/xerces/internal/xinclude/XIncludeHandler.java

27 lines changed: 26 ins; 0 del; 1 mod; 3022 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/com/sun/org/apache/xml/internal/utils/XMLReaderManager.java

29 lines changed: 25 ins; 1 del; 3 mod; 180 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/com/sun/xml/internal/stream/StaxXMLInputSource.java

13 lines changed: 13 ins; 0 del; 0 mod; 75 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/javax/xml/XMLConstants.java

210 lines changed: 198 ins; 0 del; 12 mod; 182 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/javax/xml/parsers/DocumentBuilderFactory.java

25 lines changed: 25 ins; 0 del; 0 mod; 576 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/javax/xml/parsers/SAXParser.java

23 lines changed: 23 ins; 0 del; 0 mod; 532 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/javax/xml/stream/XMLInputFactory.java

19 lines changed: 16 ins; 0 del; 3 mod; 472 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/javax/xml/transform/TransformerFactory.java

40 lines changed: 40 ins; 0 del; 0 mod; 373 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/javax/xml/validation/SchemaFactory.java

38 lines changed: 36 ins; 0 del; 2 mod; 755 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/javax/xml/validation/Validator.java

21 lines changed: 19 ins; 0 del; 2 mod; 503 unchg

This code review page was prepared using ../make/scripts/webrev.ksh (vers 24.0-hg+jbs).