Code Review for jaxp

Prepared by:joehw on Thu Dec 15 10:07:02 PST 2016
Workspace:/scratch/w/huizwang/openjdk/9-dev/jaxp
Compare against: ssh://hg.openjdk.java.net/jdk9/dev/jaxp
Summary of changes: 1841 lines changed: 460 ins; 422 del; 959 mod; 19331 unchg
Patch of changes: jaxp.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/XMLDocumentFragmentScannerImpl.java

211 lines changed: 35 ins; 120 del; 56 mod; 3135 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/XMLDocumentScannerImpl.java

20 lines changed: 0 ins; 16 del; 4 mod; 1456 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/XMLEntityManager.java

7 lines changed: 0 ins; 0 del; 7 mod; 3193 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/XMLStreamReaderImpl.java

687 lines changed: 176 ins; 61 del; 450 mod; 856 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/xml/internal/stream/XMLEntityStorage.java

16 lines changed: 0 ins; 10 del; 6 mod; 609 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/xml/internal/stream/dtd/DTDGrammarUtil.java

19 lines changed: 5 ins; 9 del; 5 mod; 484 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/xml/internal/stream/dtd/nonvalidating/DTDGrammar.java

22 lines changed: 6 ins; 5 del; 11 mod; 863 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/xml/internal/stream/dtd/nonvalidating/XMLAttributeDecl.java

11 lines changed: 5 ins; 4 del; 2 mod; 56 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/xml/internal/stream/dtd/nonvalidating/XMLElementDecl.java

11 lines changed: 5 ins; 4 del; 2 mod; 77 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/xml/internal/stream/dtd/nonvalidating/XMLNotationDecl.java

11 lines changed: 5 ins; 4 del; 2 mod; 65 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/xml/internal/stream/events/DTDEvent.java

32 lines changed: 11 ins; 3 del; 18 mod; 83 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/xml/internal/stream/events/EndElementEvent.java

39 lines changed: 8 ins; 5 del; 26 mod; 93 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/xml/internal/stream/events/StartElementEvent.java

96 lines changed: 24 ins; 7 del; 65 mod; 159 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/xml/internal/stream/events/XMLEventAllocatorImpl.java

92 lines changed: 18 ins; 4 del; 70 mod; 183 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/xml/internal/stream/events/XMLEventFactoryImpl.java

69 lines changed: 44 ins; 0 del; 25 mod; 176 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/xml/internal/stream/util/ReadOnlyIterator.java

12 lines changed: 1 ins; 4 del; 7 mod; 56 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/xml/internal/stream/util/ThreadLocalBufferAllocator.java

3 lines changed: 0 ins; 0 del; 3 mod; 50 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/xml/internal/stream/writers/UTF8OutputStreamWriter.java

1 line changed: 0 ins; 0 del; 1 mod; 148 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/xml/internal/stream/writers/XMLEventWriterImpl.java

112 lines changed: 34 ins; 6 del; 72 mod; 184 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/xml/internal/stream/writers/XMLStreamWriterImpl.java

120 lines changed: 42 ins; 7 del; 71 mod; 2141 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/javax/xml/stream/EventFilter.java

5 lines changed: 1 ins; 4 del; 0 mod; 46 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/javax/xml/stream/FactoryConfigurationError.java

4 lines changed: 1 ins; 3 del; 0 mod; 122 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/javax/xml/stream/Location.java

5 lines changed: 1 ins; 4 del; 0 mod; 73 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/javax/xml/stream/SecuritySupport.java

29 lines changed: 0 ins; 19 del; 10 mod; 62 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/javax/xml/stream/StreamFilter.java

5 lines changed: 1 ins; 4 del; 0 mod; 47 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/javax/xml/stream/XMLEventFactory.java

16 lines changed: 2 ins; 5 del; 9 mod; 493 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/javax/xml/stream/XMLEventReader.java

6 lines changed: 1 ins; 4 del; 1 mod; 111 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/javax/xml/stream/XMLEventWriter.java

5 lines changed: 1 ins; 4 del; 0 mod; 252 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/javax/xml/stream/XMLInputFactory.java

7 lines changed: 3 ins; 4 del; 0 mod; 547 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/javax/xml/stream/XMLOutputFactory.java

7 lines changed: 2 ins; 4 del; 1 mod; 400 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/javax/xml/stream/XMLReporter.java

5 lines changed: 1 ins; 4 del; 0 mod; 61 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/javax/xml/stream/XMLResolver.java

5 lines changed: 1 ins; 4 del; 0 mod; 56 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/javax/xml/stream/XMLStreamConstants.java

1 line changed: 1 ins; 0 del; 0 mod; 127 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/javax/xml/stream/XMLStreamException.java

5 lines changed: 1 ins; 4 del; 0 mod; 126 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/javax/xml/stream/XMLStreamReader.java

5 lines changed: 1 ins; 4 del; 0 mod; 720 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/javax/xml/stream/XMLStreamWriter.java

5 lines changed: 1 ins; 4 del; 0 mod; 528 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/javax/xml/stream/events/Attribute.java

5 lines changed: 1 ins; 4 del; 0 mod; 65 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/javax/xml/stream/events/Characters.java

5 lines changed: 1 ins; 4 del; 0 mod; 72 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/javax/xml/stream/events/Comment.java

5 lines changed: 1 ins; 4 del; 0 mod; 41 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/javax/xml/stream/events/DTD.java

41 lines changed: 5 ins; 4 del; 32 mod; 38 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/javax/xml/stream/events/EndDocument.java

5 lines changed: 1 ins; 4 del; 0 mod; 38 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/javax/xml/stream/events/EndElement.java

6 lines changed: 1 ins; 4 del; 1 mod; 54 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/javax/xml/stream/events/EntityDeclaration.java

5 lines changed: 1 ins; 4 del; 0 mod; 76 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/javax/xml/stream/events/EntityReference.java

5 lines changed: 1 ins; 4 del; 0 mod; 58 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/javax/xml/stream/events/Namespace.java

5 lines changed: 1 ins; 4 del; 0 mod; 55 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/javax/xml/stream/events/NotationDeclaration.java

5 lines changed: 1 ins; 4 del; 0 mod; 54 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/javax/xml/stream/events/ProcessingInstruction.java

5 lines changed: 1 ins; 4 del; 0 mod; 48 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/javax/xml/stream/events/StartDocument.java

5 lines changed: 1 ins; 4 del; 0 mod; 70 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/javax/xml/stream/events/StartElement.java

9 lines changed: 1 ins; 6 del; 2 mod; 109 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/javax/xml/stream/events/XMLEvent.java

5 lines changed: 1 ins; 4 del; 0 mod; 174 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/javax/xml/stream/util/EventReaderDelegate.java

8 lines changed: 1 ins; 7 del; 0 mod; 127 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/javax/xml/stream/util/StreamReaderDelegate.java

6 lines changed: 1 ins; 5 del; 0 mod; 282 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/javax/xml/stream/util/XMLEventAllocator.java

5 lines changed: 1 ins; 4 del; 0 mod; 78 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/javax/xml/stream/util/XMLEventConsumer.java

5 lines changed: 1 ins; 4 del; 0 mod; 54 unchg

This code review page was prepared using /scratch/w/huizwang/openjdk/9-dev/make/scripts/webrev.ksh (vers 25.16-hg+openjdk.java.net).