Code Review for 7009266_intrinsify_get

Prepared by:johnc on Mon Mar 28 10:10:33 PDT 2011
Workspace:/home/jc234399/ws/7009266/7009266_intrinsify_get
Compare against: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot
Compare against version:2236
Summary of changes: 1194 lines changed: 954 ins; 110 del; 130 mod; 77274 unchg
Patch of changes: 7009266_intrinsify_get.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/cpu/sparc/vm/assembler_sparc.cpp

rev 2237 : [mq]: initial-intrinsification-changes
rev 2238 : [mq]: code-review-comments-vladimir
rev 2239 : [mq]: client_assertion_fauilure
94 lines changed: 25 ins; 46 del; 23 mod; 4861 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/cpu/sparc/vm/assembler_sparc.hpp

rev 2237 : [mq]: initial-intrinsification-changes
rev 2238 : [mq]: code-review-comments-vladimir
8 lines changed: 1 ins; 5 del; 2 mod; 2522 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/cpu/sparc/vm/c1_CodeStubs_sparc.cpp

rev 2237 : [mq]: initial-intrinsification-changes
rev 2238 : [mq]: code-review-comments-vladimir
rev 2239 : [mq]: client_assertion_fauilure
10 lines changed: 8 ins; 1 del; 1 mod; 466 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/cpu/sparc/vm/c1_LIRGenerator_sparc.cpp

rev 2238 : [mq]: code-review-comments-vladimir
rev 2239 : [mq]: client_assertion_fauilure
rev 2240 : [mq]: code-review-comments-tom
7 lines changed: 3 ins; 0 del; 4 mod; 1209 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/cpu/sparc/vm/cppInterpreter_sparc.cpp

rev 2237 : [mq]: initial-intrinsification-changes
20 lines changed: 20 ins; 0 del; 0 mod; 2268 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/cpu/sparc/vm/interpreterGenerator_sparc.hpp

rev 2237 : [mq]: initial-intrinsification-changes
rev 2239 : [mq]: client_assertion_fauilure
2 lines changed: 1 ins; 0 del; 1 mod; 45 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/cpu/sparc/vm/interpreter_sparc.cpp

rev 2237 : [mq]: initial-intrinsification-changes
2 lines changed: 2 ins; 0 del; 0 mod; 461 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/cpu/sparc/vm/templateInterpreter_sparc.cpp

rev 2237 : [mq]: initial-intrinsification-changes
rev 2238 : [mq]: code-review-comments-vladimir
81 lines changed: 81 ins; 0 del; 0 mod; 2029 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/cpu/sparc/vm/templateTable_sparc.cpp

rev 2238 : [mq]: code-review-comments-vladimir
5 lines changed: 4 ins; 0 del; 1 mod; 3844 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/cpu/x86/vm/assembler_x86.cpp

rev 2237 : [mq]: initial-intrinsification-changes
rev 2238 : [mq]: code-review-comments-vladimir
rev 2239 : [mq]: client_assertion_fauilure
109 lines changed: 61 ins; 22 del; 26 mod; 9429 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/cpu/x86/vm/assembler_x86.hpp

rev 2237 : [mq]: initial-intrinsification-changes
rev 2238 : [mq]: code-review-comments-vladimir
11 lines changed: 5 ins; 3 del; 3 mod; 2348 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/cpu/x86/vm/c1_CodeStubs_x86.cpp

rev 2237 : [mq]: initial-intrinsification-changes
rev 2238 : [mq]: code-review-comments-vladimir
rev 2239 : [mq]: client_assertion_fauilure
7 lines changed: 4 ins; 0 del; 3 mod; 506 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/cpu/x86/vm/c1_LIRGenerator_x86.cpp

rev 2238 : [mq]: code-review-comments-vladimir
rev 2240 : [mq]: code-review-comments-tom
6 lines changed: 3 ins; 0 del; 3 mod; 1348 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/cpu/x86/vm/cppInterpreterGenerator_x86.hpp

rev 2237 : [mq]: initial-intrinsification-changes
rev 2239 : [mq]: client_assertion_fauilure
2 lines changed: 1 ins; 0 del; 1 mod; 51 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/cpu/x86/vm/cppInterpreter_x86.cpp

rev 2237 : [mq]: initial-intrinsification-changes
22 lines changed: 22 ins; 0 del; 0 mod; 2433 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/cpu/x86/vm/interpreterGenerator_x86.hpp

rev 2237 : [mq]: initial-intrinsification-changes
rev 2239 : [mq]: client_assertion_fauilure
2 lines changed: 1 ins; 0 del; 1 mod; 47 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/cpu/x86/vm/templateInterpreter_x86_32.cpp

rev 2237 : [mq]: initial-intrinsification-changes
rev 2238 : [mq]: code-review-comments-vladimir
94 lines changed: 94 ins; 0 del; 0 mod; 1868 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/cpu/x86/vm/templateInterpreter_x86_64.cpp

rev 2237 : [mq]: initial-intrinsification-changes
rev 2238 : [mq]: code-review-comments-vladimir
91 lines changed: 91 ins; 0 del; 0 mod; 1910 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/cpu/x86/vm/templateTable_x86_32.cpp

rev 2238 : [mq]: code-review-comments-vladimir
11 lines changed: 9 ins; 0 del; 2 mod; 3614 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/cpu/x86/vm/templateTable_x86_64.cpp

rev 2238 : [mq]: code-review-comments-vladimir
11 lines changed: 9 ins; 0 del; 2 mod; 3669 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/cpu/zero/vm/cppInterpreter_zero.cpp

rev 2237 : [mq]: initial-intrinsification-changes
24 lines changed: 24 ins; 0 del; 0 mod; 975 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/cpu/zero/vm/interpreterGenerator_zero.hpp

rev 2237 : [mq]: initial-intrinsification-changes
rev 2239 : [mq]: client_assertion_fauilure
2 lines changed: 1 ins; 0 del; 1 mod; 41 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/c1/c1_CodeStubs.hpp

rev 2237 : [mq]: initial-intrinsification-changes
rev 2238 : [mq]: code-review-comments-vladimir
rev 2239 : [mq]: client_assertion_fauilure
rev 2240 : [mq]: code-review-comments-tom
29 lines changed: 20 ins; 0 del; 9 mod; 585 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/c1/c1_GraphBuilder.cpp

rev 2237 : [mq]: initial-intrinsification-changes
rev 2239 : [mq]: client_assertion_fauilure
49 lines changed: 49 ins; 0 del; 0 mod; 3813 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/c1/c1_LIRGenerator.cpp

rev 2237 : [mq]: initial-intrinsification-changes
rev 2238 : [mq]: code-review-comments-vladimir
rev 2239 : [mq]: client_assertion_fauilure
rev 2240 : [mq]: code-review-comments-tom
rev 2242 : [mq]: reflection-unsafe-read-barrier
119 lines changed: 102 ins; 5 del; 12 mod; 2857 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/c1/c1_LIRGenerator.hpp

rev 2237 : [mq]: initial-intrinsification-changes
rev 2238 : [mq]: code-review-comments-vladimir
4 lines changed: 2 ins; 0 del; 2 mod; 607 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/classfile/vmSymbols.hpp

rev 2237 : [mq]: initial-intrinsification-changes
4 lines changed: 4 ins; 0 del; 0 mod; 1124 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/gc_implementation/g1/g1_globals.hpp

rev 2238 : [mq]: code-review-comments-vladimir
9 lines changed: 0 ins; 9 del; 0 mod; 305 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/interpreter/abstractInterpreter.hpp

rev 2237 : [mq]: initial-intrinsification-changes
2 lines changed: 1 ins; 0 del; 1 mod; 294 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/interpreter/cppInterpreter.cpp

rev 2237 : [mq]: initial-intrinsification-changes
rev 2239 : [mq]: client_assertion_fauilure
2 lines changed: 1 ins; 0 del; 1 mod; 138 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/interpreter/interpreter.cpp

rev 2237 : [mq]: initial-intrinsification-changes
15 lines changed: 9 ins; 6 del; 0 mod; 429 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/interpreter/templateInterpreter.cpp

rev 2237 : [mq]: initial-intrinsification-changes
1 line changed: 1 ins; 0 del; 0 mod; 619 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/oops/instanceKlass.hpp

rev 2242 : [mq]: reflection-unsafe-read-barrier
2 lines changed: 2 ins; 0 del; 0 mod; 1020 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/opto/callGenerator.cpp

rev 2237 : [mq]: initial-intrinsification-changes
rev 2238 : [mq]: code-review-comments-vladimir
rev 2239 : [mq]: client_assertion_fauilure
rev 2240 : [mq]: code-review-comments-tom
rev 2242 : [mq]: reflection-unsafe-read-barrier
1 line changed: 0 ins; 0 del; 1 mod; 1034 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/opto/callGenerator.hpp

rev 2237 : [mq]: initial-intrinsification-changes
rev 2239 : [mq]: client_assertion_fauilure
rev 2240 : [mq]: code-review-comments-tom
0 lines changed: 0 ins; 0 del; 0 mod; 293 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/opto/compile.cpp

rev 2240 : [mq]: code-review-comments-tom
19 lines changed: 15 ins; 0 del; 4 mod; 3120 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/opto/graphKit.cpp

rev 2237 : [mq]: initial-intrinsification-changes
rev 2238 : [mq]: code-review-comments-vladimir
rev 2239 : [mq]: client_assertion_fauilure
55 lines changed: 33 ins; 12 del; 10 mod; 3671 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/opto/graphKit.hpp

rev 2237 : [mq]: initial-intrinsification-changes
rev 2238 : [mq]: code-review-comments-vladimir
8 lines changed: 4 ins; 0 del; 4 mod; 844 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/opto/library_call.cpp

rev 2237 : [mq]: initial-intrinsification-changes
rev 2238 : [mq]: code-review-comments-vladimir
rev 2239 : [mq]: client_assertion_fauilure
rev 2240 : [mq]: code-review-comments-tom
rev 2242 : [mq]: reflection-unsafe-read-barrier
174 lines changed: 163 ins; 1 del; 10 mod; 5306 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/prims/jni.cpp

rev 2241 : [mq]: jni-read-barrier
rev 2242 : [mq]: reflection-unsafe-read-barrier
19 lines changed: 19 ins; 0 del; 0 mod; 3674 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/prims/unsafe.cpp

rev 2242 : [mq]: reflection-unsafe-read-barrier
61 lines changed: 59 ins; 0 del; 2 mod; 1597 unchg

This code review page was prepared using /java/j2se/bin/webrev (vers 23.18-hg).