Code Review for hotspot

Prepared by:johnc on Mon Oct 17 15:06:26 PDT 2011
Workspace:/export/workspaces/g1-print-gc-details/hotspot
Compare against: http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot
Compare against version:2754
Summary of changes: 161 lines changed: 75 ins; 58 del; 28 mod; 6991 unchg
Patch of changes: hotspot.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp

rev 2755 : 7096030: G1: PrintGCDetails enhancements
Summary: Add a new per-worker thread line in the PrintGCDetails output.
GC Worker Other is the difference between the elapsed time for the
parallel phase of the evacuation pause and the sum of the times of the
sub-phases (external root scanning, mark stack scanning, RSet updating,
RSet scanning, object copying, and termination) for that worker.
Additionally, during RSet scanning, stack allocate DirtyCardToOopClosure
objects; allocating these in a resource area was causing abnormally high
GC Worker Other times.
Reviewed-by: tonyp, jwilhelm
133 lines changed: 68 ins; 43 del; 22 mod; 3004 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/gc_implementation/g1/g1CollectorPolicy.hpp

rev 2755 : 7096030: G1: PrintGCDetails enhancements
Summary: Add a new per-worker thread line in the PrintGCDetails output.
GC Worker Other is the difference between the elapsed time for the
parallel phase of the evacuation pause and the sum of the times of the
sub-phases (external root scanning, mark stack scanning, RSet updating,
RSet scanning, object copying, and termination) for that worker.
Additionally, during RSet scanning, stack allocate DirtyCardToOopClosure
objects; allocating these in a resource area was causing abnormally high
GC Worker Other times.
Reviewed-by: tonyp, jwilhelm
10 lines changed: 7 ins; 2 del; 1 mod; 1243 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/gc_implementation/g1/g1RemSet.cpp

rev 2755 : 7096030: G1: PrintGCDetails enhancements
Summary: Add a new per-worker thread line in the PrintGCDetails output.
GC Worker Other is the difference between the elapsed time for the
parallel phase of the evacuation pause and the sum of the times of the
sub-phases (external root scanning, mark stack scanning, RSet updating,
RSet scanning, object copying, and termination) for that worker.
Additionally, during RSet scanning, stack allocate DirtyCardToOopClosure
objects; allocating these in a resource area was causing abnormally high
GC Worker Other times.
Reviewed-by: tonyp, jwilhelm
5 lines changed: 0 ins; 0 del; 5 mod; 943 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/gc_implementation/g1/heapRegion.cpp

rev 2755 : 7096030: G1: PrintGCDetails enhancements
Summary: Add a new per-worker thread line in the PrintGCDetails output.
GC Worker Other is the difference between the elapsed time for the
parallel phase of the evacuation pause and the sum of the times of the
sub-phases (external root scanning, mark stack scanning, RSet updating,
RSet scanning, object copying, and termination) for that worker.
Additionally, during RSet scanning, stack allocate DirtyCardToOopClosure
objects; allocating these in a resource area was causing abnormally high
GC Worker Other times.
Reviewed-by: tonyp, jwilhelm
8 lines changed: 0 ins; 8 del; 0 mod; 962 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/gc_implementation/g1/heapRegion.hpp

rev 2755 : 7096030: G1: PrintGCDetails enhancements
Summary: Add a new per-worker thread line in the PrintGCDetails output.
GC Worker Other is the difference between the elapsed time for the
parallel phase of the evacuation pause and the sum of the times of the
sub-phases (external root scanning, mark stack scanning, RSet updating,
RSet scanning, object copying, and termination) for that worker.
Additionally, during RSet scanning, stack allocate DirtyCardToOopClosure
objects; allocating these in a resource area was causing abnormally high
GC Worker Other times.
Reviewed-by: tonyp, jwilhelm
5 lines changed: 0 ins; 5 del; 0 mod; 839 unchg

This code review page was prepared using /java/j2se/bin/webrev (vers 23.18-hg).