Code Review for hotspot

Prepared by:johnc on Fri Oct 7 10:28:26 PDT 2011
Workspace:/export/workspaces/g1-ref-policy-assert/hotspot
Compare against: http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot
Compare against version:2725
Summary of changes: 75 lines changed: 46 ins; 13 del; 16 mod; 2220 unchg
Patch of changes: hotspot.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/memory/referencePolicy.cpp

rev 2726 : 7098282: G1: assert(interval >= 0) failed: Sanity check, referencePolicy.cpp: 76
Summary: There is a race between one thread successfully forwarding and copying the klass mirror for the SoftReference class (including the static master clock) and another thread attempting to use the master clock while attempting to discover a soft reference object. Maintain a shadow copy of the soft reference master clock and use the shadow during reference discovery and reference processing.
Reviewed-by:
5 lines changed: 0 ins; 0 del; 5 mod; 79 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/memory/referencePolicy.hpp

rev 2726 : 7098282: G1: assert(interval >= 0) failed: Sanity check, referencePolicy.cpp: 76
Summary: There is a race between one thread successfully forwarding and copying the klass mirror for the SoftReference class (including the static master clock) and another thread attempting to use the master clock while attempting to discover a soft reference object. Maintain a shadow copy of the soft reference master clock and use the shadow during reference discovery and reference processing.
Reviewed-by:
10 lines changed: 4 ins; 0 del; 6 mod; 67 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/memory/referenceProcessor.cpp

rev 2726 : 7098282: G1: assert(interval >= 0) failed: Sanity check, referencePolicy.cpp: 76
Summary: There is a race between one thread successfully forwarding and copying the klass mirror for the SoftReference class (including the static master clock) and another thread attempting to use the master clock while attempting to discover a soft reference object. Maintain a shadow copy of the soft reference master clock and use the shadow during reference discovery and reference processing.
Reviewed-by:
43 lines changed: 39 ins; 0 del; 4 mod; 1363 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/memory/referenceProcessor.hpp

rev 2726 : 7098282: G1: assert(interval >= 0) failed: Sanity check, referencePolicy.cpp: 76
Summary: There is a race between one thread successfully forwarding and copying the klass mirror for the SoftReference class (including the static master clock) and another thread attempting to use the master clock while attempting to discover a soft reference object. Maintain a shadow copy of the soft reference master clock and use the shadow during reference discovery and reference processing.
Reviewed-by:
17 lines changed: 3 ins; 13 del; 1 mod; 711 unchg

This code review page was prepared using /java/j2se/bin/webrev (vers 23.18-hg).