Prepared by: | johnc on Mon Oct 17 14:23:40 PDT 2011 |
---|---|
Workspace: | /export/workspaces/7099824/hotspot |
Compare against: | http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot |
Compare against version: | 2754 |
Summary of changes: | 42 lines changed: 34 ins; 5 del; 3 mod; 952 unchg |
Patch of changes: | hotspot.patch |
Legend: |
Modified file Deleted file New file |
Cdiffs
Udiffs
Wdiffs
Sdiffs
Frames
Old
New
Patch
Raw
src/share/vm/gc_implementation/g1/concurrentMarkThread.cpp
rev 2755 : 7099824: G1: we should take the pending list lock before doing the remark pause Summary: Acquire the pending list lock in the prologue method of G1's concurrent VM_Operation and release the lock in the epilogue() method. The locking/unlocking order of the pending list lock and the Heap_lock should match that in the prologue and epilogue methods of VM_GC_Operation. Reviewed-by:11 lines changed: 4 ins; 5 del; 2 mod; 340 unchg
Cdiffs
Udiffs
Wdiffs
Sdiffs
Frames
Old
New
Patch
Raw
src/share/vm/gc_implementation/g1/vm_operations_g1.cpp
rev 2755 : 7099824: G1: we should take the pending list lock before doing the remark pause Summary: Acquire the pending list lock in the prologue method of G1's concurrent VM_Operation and release the lock in the epilogue() method. The locking/unlocking order of the pending list lock and the Heap_lock should match that in the prologue and epilogue methods of VM_GC_Operation. Reviewed-by:22 lines changed: 22 ins; 0 del; 0 mod; 191 unchg
Cdiffs
Udiffs
Wdiffs
Sdiffs
Frames
Old
New
Patch
Raw
src/share/vm/gc_implementation/g1/vm_operations_g1.hpp
rev 2755 : 7099824: G1: we should take the pending list lock before doing the remark pause Summary: Acquire the pending list lock in the prologue method of G1's concurrent VM_Operation and release the lock in the epilogue() method. The locking/unlocking order of the pending list lock and the Heap_lock should match that in the prologue and epilogue methods of VM_GC_Operation. Reviewed-by:7 lines changed: 6 ins; 0 del; 1 mod; 112 unchg
Cdiffs
Udiffs
Wdiffs
Sdiffs
Frames
Old
New
Patch
Raw
src/share/vm/gc_implementation/shared/concurrentGCThread.cpp
rev 2755 : 7099824: G1: we should take the pending list lock before doing the remark pause Summary: Acquire the pending list lock in the prologue method of G1's concurrent VM_Operation and release the lock in the epilogue() method. The locking/unlocking order of the pending list lock and the Heap_lock should match that in the prologue and epilogue methods of VM_GC_Operation. Reviewed-by:2 lines changed: 2 ins; 0 del; 0 mod; 309 unchg
This code review page was prepared using /java/j2se/bin/webrev (vers 23.18-hg).