Print this page
rev 3849 : 7194633: G1: Assertion and guarantee failures in block offset table
Summary: Add detailed error messages to assertions and guarantees in G1's block offset table.
Reviewed-by:
| Split |
Close |
| Expand all |
| Collapse all |
--- old/src/share/vm/gc_implementation/g1/g1BlockOffsetTable.inline.hpp
+++ new/src/share/vm/gc_implementation/g1/g1BlockOffsetTable.inline.hpp
1 1 /*
2 2 * Copyright (c) 2001, 2012, Oracle and/or its affiliates. All rights reserved.
3 3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
4 4 *
5 5 * This code is free software; you can redistribute it and/or modify it
6 6 * under the terms of the GNU General Public License version 2 only, as
7 7 * published by the Free Software Foundation.
8 8 *
9 9 * This code is distributed in the hope that it will be useful, but WITHOUT
10 10 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
11 11 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
12 12 * version 2 for more details (a copy is included in the LICENSE file that
13 13 * accompanied this code).
14 14 *
15 15 * You should have received a copy of the GNU General Public License version
16 16 * 2 along with this work; if not, write to the Free Software Foundation,
17 17 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
18 18 *
19 19 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
20 20 * or visit www.oracle.com if you need additional information or have any
21 21 * questions.
22 22 *
23 23 */
24 24
25 25 #ifndef SHARE_VM_GC_IMPLEMENTATION_G1_G1BLOCKOFFSETTABLE_INLINE_HPP
26 26 #define SHARE_VM_GC_IMPLEMENTATION_G1_G1BLOCKOFFSETTABLE_INLINE_HPP
27 27
28 28 #include "gc_implementation/g1/g1BlockOffsetTable.hpp"
29 29 #include "memory/space.hpp"
30 30
31 31 inline HeapWord* G1BlockOffsetTable::block_start(const void* addr) {
32 32 if (addr >= _bottom && addr < _end) {
33 33 return block_start_unsafe(addr);
34 34 } else {
35 35 return NULL;
36 36 }
37 37 }
38 38
39 39 inline HeapWord*
40 40 G1BlockOffsetTable::block_start_const(const void* addr) const {
41 41 if (addr >= _bottom && addr < _end) {
|
↓ open down ↓ |
41 lines elided |
↑ open up ↑ |
42 42 return block_start_unsafe_const(addr);
43 43 } else {
44 44 return NULL;
45 45 }
46 46 }
47 47
48 48 inline size_t G1BlockOffsetSharedArray::index_for(const void* p) const {
49 49 char* pc = (char*)p;
50 50 assert(pc >= (char*)_reserved.start() &&
51 51 pc < (char*)_reserved.end(),
52 - "p not in range.");
52 + err_msg("p ("PTR_FORMAT") not in reserved ["PTR_FORMAT", "PTR_FORMAT")",
53 + p, (char*)_reserved.start(), (char*)_reserved.end()));
53 54 size_t delta = pointer_delta(pc, _reserved.start(), sizeof(char));
54 55 size_t result = delta >> LogN;
55 - assert(result < _vs.committed_size(), "bad index from address");
56 + check_index(result, "bad index from address");
56 57 return result;
57 58 }
58 59
59 60 inline HeapWord*
60 61 G1BlockOffsetSharedArray::address_for_index(size_t index) const {
61 - assert(index < _vs.committed_size(), "bad index");
62 + check_index(index, "index out of range");
62 63 HeapWord* result = _reserved.start() + (index << LogN_words);
63 64 assert(result >= _reserved.start() && result < _reserved.end(),
64 65 err_msg("bad address from index result " PTR_FORMAT
65 66 " _reserved.start() " PTR_FORMAT " _reserved.end() "
66 67 PTR_FORMAT,
67 68 result, _reserved.start(), _reserved.end()));
68 69 return result;
69 70 }
70 71
71 72 inline HeapWord*
72 73 G1BlockOffsetArray::block_at_or_preceding(const void* addr,
73 74 bool has_max_index,
74 75 size_t max_index) const {
75 76 assert(_array->offset_array(0) == 0, "objects can't cross covered areas");
76 77 size_t index = _array->index_for(addr);
77 78 // We must make sure that the offset table entry we use is valid. If
78 79 // "addr" is past the end, start at the last known one and go forward.
79 80 if (has_max_index) {
80 81 index = MIN2(index, max_index);
81 82 }
82 83 HeapWord* q = _array->address_for_index(index);
83 84
84 85 uint offset = _array->offset_array(index); // Extend u_char to uint.
85 86 while (offset >= N_words) {
86 87 // The excess of the offset from N_words indicates a power of Base
87 88 // to go back by.
88 89 size_t n_cards_back = BlockOffsetArray::entry_to_cards_back(offset);
89 90 q -= (N_words * n_cards_back);
90 91 assert(q >= _sp->bottom(), "Went below bottom!");
91 92 index -= n_cards_back;
92 93 offset = _array->offset_array(index);
93 94 }
94 95 assert(offset < N_words, "offset too large");
95 96 q -= offset;
96 97 return q;
97 98 }
98 99
99 100 inline HeapWord*
100 101 G1BlockOffsetArray::
101 102 forward_to_block_containing_addr_const(HeapWord* q, HeapWord* n,
102 103 const void* addr) const {
103 104 if (csp() != NULL) {
104 105 if (addr >= csp()->top()) return csp()->top();
105 106 while (n <= addr) {
106 107 q = n;
107 108 oop obj = oop(q);
108 109 if (obj->klass_or_null() == NULL) return q;
109 110 n += obj->size();
110 111 }
111 112 } else {
112 113 while (n <= addr) {
113 114 q = n;
114 115 oop obj = oop(q);
115 116 if (obj->klass_or_null() == NULL) return q;
116 117 n += _sp->block_size(q);
117 118 }
118 119 }
119 120 assert(q <= n, "wrong order for q and addr");
120 121 assert(addr < n, "wrong order for addr and n");
121 122 return q;
122 123 }
123 124
124 125 inline HeapWord*
125 126 G1BlockOffsetArray::forward_to_block_containing_addr(HeapWord* q,
126 127 const void* addr) {
127 128 if (oop(q)->klass_or_null() == NULL) return q;
128 129 HeapWord* n = q + _sp->block_size(q);
129 130 // In the normal case, where the query "addr" is a card boundary, and the
130 131 // offset table chunks are the same size as cards, the block starting at
131 132 // "q" will contain addr, so the test below will fail, and we'll fall
132 133 // through quickly.
133 134 if (n <= addr) {
134 135 q = forward_to_block_containing_addr_slow(q, n, addr);
135 136 }
136 137 assert(q <= addr, "wrong order for current and arg");
137 138 return q;
138 139 }
139 140
140 141 //////////////////////////////////////////////////////////////////////////
141 142 // BlockOffsetArrayNonContigSpace inlines
142 143 //////////////////////////////////////////////////////////////////////////
143 144 inline void G1BlockOffsetArray::freed(HeapWord* blk_start, HeapWord* blk_end) {
144 145 // Verify that the BOT shows [blk_start, blk_end) to be one block.
145 146 verify_single_block(blk_start, blk_end);
146 147 // adjust _unallocated_block upward or downward
147 148 // as appropriate
148 149 if (BlockOffsetArrayUseUnallocatedBlock) {
149 150 assert(_unallocated_block <= _end,
150 151 "Inconsistent value for _unallocated_block");
151 152 if (blk_end >= _unallocated_block && blk_start <= _unallocated_block) {
152 153 // CMS-specific note: a block abutting _unallocated_block to
153 154 // its left is being freed, a new block is being added or
154 155 // we are resetting following a compaction
155 156 _unallocated_block = blk_start;
156 157 }
157 158 }
158 159 }
159 160
160 161 inline void G1BlockOffsetArray::freed(HeapWord* blk, size_t size) {
161 162 freed(blk, blk + size);
162 163 }
163 164
164 165 #endif // SHARE_VM_GC_IMPLEMENTATION_G1_G1BLOCKOFFSETTABLE_INLINE_HPP
|
↓ open down ↓ |
93 lines elided |
↑ open up ↑ |
XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX