Code Review for jdk

Prepared by: Jorn Vernee on Wed Apr 15 12:12:20 CEST 2020
Compare against: https://github.com/openjdk/jdk
Compare against version: 8cd92414
Summary of changes: 329 lines changed; 317 ins; 1 del; 11 mod; 13305 unchg
Patch of changes: jdk.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src\java.base\share\classes\java\lang\Boolean.java

3650ff0d: Make Boolean, Short, Character, and Byte Constable & Add ConstantBootstraps::convert method to facilitate Integer -> (char|byte|short) conversions.  
22 lines changed; 21 ins; 0 del; 1 mod; 346 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src\java.base\share\classes\java\lang\Byte.java

efa10b30: Removed source type
f8491ec2: Review comments: rename bootstrap to "explicitCast" & specify in terms of MH::explicitCastArguments
3650ff0d: Make Boolean, Short, Character, and Byte Constable & Add ConstantBootstraps::convert method to facilitate Integer -> (char|byte|short) conversions.  
23 lines changed; 21 ins; 0 del; 2 mod; 564 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src\java.base\share\classes\java\lang\Character.java

efa10b30: Removed source type
f8491ec2: Review comments: rename bootstrap to "explicitCast" & specify in terms of MH::explicitCastArguments
3650ff0d: Make Boolean, Short, Character, and Byte Constable & Add ConstantBootstraps::convert method to facilitate Integer -> (char|byte|short) conversions.  
24 lines changed; 20 ins; 1 del; 3 mod; 11151 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src\java.base\share\classes\java\lang\Short.java

efa10b30: Removed source type
f8491ec2: Review comments: rename bootstrap to "explicitCast" & specify in terms of MH::explicitCastArguments
3650ff0d: Make Boolean, Short, Character, and Byte Constable & Add ConstantBootstraps::convert method to facilitate Integer -> (char|byte|short) conversions.  
23 lines changed; 21 ins; 0 del; 2 mod; 582 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src\java.base\share\classes\java\lang\constant\ConstantDescs.java

d6609ad4: Replaced  tags with @code & added @since tags to constants
efa10b30: Removed source type
f8491ec2: Review comments: rename bootstrap to "explicitCast" & specify in terms of MH::explicitCastArguments
3650ff0d: Make Boolean, Short, Character, and Byte Constable & Add ConstantBootstraps::convert method to facilitate Integer -> (char|byte|short) conversions.  
34 lines changed; 32 ins; 0 del; 2 mod; 296 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src\java.base\share\classes\java\lang\invoke\ConstantBootstraps.java

d28a3e4b: Fixed typo in exception message
d6609ad4: Replaced  tags with @code & added @since tags to constants
b9cfbedc: Using inline @jls tag & fixed a typo
efa10b30: Removed source type
f8491ec2: Review comments: rename bootstrap to "explicitCast" & specify in terms of MH::explicitCastArguments
3650ff0d: Make Boolean, Short, Character, and Byte Constable & Add ConstantBootstraps::convert method to facilitate Integer -> (char|byte|short) conversions.  
66 lines changed; 65 ins; 0 del; 1 mod; 366 unchg

------ ------ ------ ------ --- New Patch Raw test\jdk\java\lang\constant\ConvertTest.java

efa10b30: Removed source type
f8491ec2: Review comments: rename bootstrap to "explicitCast" & specify in terms of MH::explicitCastArguments  
79 lines changed; 79 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test\jdk\java\lang\constant\DescribeResolveTest.java

3650ff0d: Make Boolean, Short, Character, and Byte Constable & Add ConstantBootstraps::convert method to facilitate Integer -> (char|byte|short) conversions.  
58 lines changed; 58 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using webrev version d48c124c04062e398a61ab93c7b185f0cc64429a