src/share/vm/runtime/os.cpp

rev 5732 : [mq]: comments2

*** 234,244 ****
  static void signal_thread_entry(JavaThread* thread, TRAPS) {
    os::set_priority(thread, NearMaxPriority);
    while (true) {
      int sig;
      {
!       // FIXME : Currently we have not decieded what should be the status
        //         for this java thread blocked here. Once we decide about
        //         that we should fix this.
        sig = os::signal_wait();
      }
      if (sig == os::sigexitnum_pd()) {
--- 234,244 ----
  static void signal_thread_entry(JavaThread* thread, TRAPS) {
    os::set_priority(thread, NearMaxPriority);
    while (true) {
      int sig;
      {
!       // FIXME : Currently we have not decided what should be the status
        //         for this java thread blocked here. Once we decide about
        //         that we should fix this.
        sig = os::signal_wait();
      }
      if (sig == os::sigexitnum_pd()) {
*** 581,591 ****
    // look for cushion in front of prev. block
    u_char* start_of_prev_block = find_cushion_backwards(end_of_prev_block_data);
    ptrdiff_t size = *size_addr_from_base(start_of_prev_block);
    u_char* obj = start_of_prev_block + space_before;
    if (size <= 0 ) {
!     // start is bad; mayhave been confused by OS data inbetween objects
      // search one more backwards
      start_of_prev_block = find_cushion_backwards(start_of_prev_block);
      size = *size_addr_from_base(start_of_prev_block);
      obj = start_of_prev_block + space_before;
    }
--- 581,591 ----
    // look for cushion in front of prev. block
    u_char* start_of_prev_block = find_cushion_backwards(end_of_prev_block_data);
    ptrdiff_t size = *size_addr_from_base(start_of_prev_block);
    u_char* obj = start_of_prev_block + space_before;
    if (size <= 0 ) {
!     // start is bad; may have been confused by OS data in between objects
      // search one more backwards
      start_of_prev_block = find_cushion_backwards(start_of_prev_block);
      size = *size_addr_from_base(start_of_prev_block);
      obj = start_of_prev_block + space_before;
    }
*** 1009,1019 ****
    }
  
    if (Universe::heap()->is_in(addr)) {
      HeapWord* p = Universe::heap()->block_start(addr);
      bool print = false;
!     // If we couldn't find it it just may mean that heap wasn't parseable
      // See if we were just given an oop directly
      if (p != NULL && Universe::heap()->block_is_obj(p)) {
        print = true;
      } else if (p == NULL && ((oopDesc*)addr)->is_oop()) {
        p = (HeapWord*) addr;
--- 1009,1019 ----
    }
  
    if (Universe::heap()->is_in(addr)) {
      HeapWord* p = Universe::heap()->block_start(addr);
      bool print = false;
!     // If we couldn't find it it just may mean that heap wasn't parsable
      // See if we were just given an oop directly
      if (p != NULL && Universe::heap()->block_is_obj(p)) {
        print = true;
      } else if (p == NULL && ((oopDesc*)addr)->is_oop()) {
        p = (HeapWord*) addr;
*** 1446,1456 ****
  
  // This is the working definition of a server class machine:
  // >= 2 physical CPU's and >=2GB of memory, with some fuzz
  // because the graphics memory (?) sometimes masks physical memory.
  // If you want to change the definition of a server class machine
! // on some OS or platform, e.g., >=4GB on Windohs platforms,
  // then you'll have to parameterize this method based on that state,
  // as was done for logical processors here, or replicate and
  // specialize this method for each platform.  (Or fix os to have
  // some inheritance structure and use subclassing.  Sigh.)
  // If you want some platform to always or never behave as a server
--- 1446,1456 ----
  
  // This is the working definition of a server class machine:
  // >= 2 physical CPU's and >=2GB of memory, with some fuzz
  // because the graphics memory (?) sometimes masks physical memory.
  // If you want to change the definition of a server class machine
! // on some OS or platform, e.g., >=4GB on Windows platforms,
  // then you'll have to parameterize this method based on that state,
  // as was done for logical processors here, or replicate and
  // specialize this method for each platform.  (Or fix os to have
  // some inheritance structure and use subclassing.  Sigh.)
  // If you want some platform to always or never behave as a server