--- old/src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/CompilationTask.java 2019-05-06 15:58:49.211306071 +0200 +++ new/src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/CompilationTask.java 2019-05-06 15:58:48.807303485 +0200 @@ -32,7 +32,6 @@ import static org.graalvm.compiler.java.BytecodeParserOptions.InlineDuringParsing; import java.io.PrintStream; -import java.util.List; import jdk.internal.vm.compiler.collections.EconomicMap; import org.graalvm.compiler.api.replacements.SnippetReflectionProvider; @@ -44,7 +43,6 @@ import org.graalvm.compiler.debug.DebugCloseable; import org.graalvm.compiler.debug.DebugContext; import org.graalvm.compiler.debug.DebugDumpScope; -import org.graalvm.compiler.debug.GraalError; import org.graalvm.compiler.debug.TimerKey; import org.graalvm.compiler.options.OptionKey; import org.graalvm.compiler.options.OptionValues; @@ -52,7 +50,6 @@ import jdk.vm.ci.code.BailoutException; import jdk.vm.ci.code.CodeCacheProvider; -import jdk.vm.ci.hotspot.EventProvider; import jdk.vm.ci.hotspot.HotSpotCompilationRequest; import jdk.vm.ci.hotspot.HotSpotCompilationRequestResult; import jdk.vm.ci.hotspot.HotSpotInstalledCode; @@ -60,23 +57,9 @@ import jdk.vm.ci.hotspot.HotSpotNmethod; import jdk.vm.ci.hotspot.HotSpotResolvedJavaMethod; import jdk.vm.ci.runtime.JVMCICompiler; -import jdk.vm.ci.services.JVMCIServiceLocator; public class CompilationTask { - private static final EventProvider eventProvider; - - static { - List providers = JVMCIServiceLocator.getProviders(EventProvider.class); - if (providers.size() > 1) { - throw new GraalError("Multiple %s providers found: %s", EventProvider.class.getName(), providers); - } else if (providers.isEmpty()) { - eventProvider = EventProvider.createEmptyEventProvider(); - } else { - eventProvider = providers.get(0); - } - } - private final HotSpotJVMCIRuntime jvmciRuntime; private final HotSpotGraalCompiler compiler; @@ -94,12 +77,10 @@ private final boolean shouldRetainLocalVariables; final class HotSpotCompilationWrapper extends CompilationWrapper { - private final EventProvider.CompilationEvent compilationEvent; CompilationResult result; - HotSpotCompilationWrapper(EventProvider.CompilationEvent compilationEvent) { + HotSpotCompilationWrapper() { super(compiler.getGraalRuntime().getOutputDirectory(), compiler.getGraalRuntime().getCompilationProblemsPerAction()); - this.compilationEvent = compilationEvent; } @Override @@ -125,13 +106,6 @@ */ return HotSpotCompilationRequestResult.failure(bailout.getMessage(), !bailout.isPermanent()); } - // Log a failure event. - EventProvider.CompilerFailureEvent event = eventProvider.newCompilerFailureEvent(); - if (event.shouldWrite()) { - event.setCompileId(getId()); - event.setMessage(t.getMessage()); - event.commit(); - } /* * Treat random exceptions from the compiler as indicating a problem compiling this @@ -181,14 +155,9 @@ final CompilationPrinter printer = CompilationPrinter.begin(debug.getOptions(), compilationId, method, entryBCI); try (DebugContext.Scope s = debug.scope("Compiling", new DebugDumpScope(getIdString(), true))) { - // Begin the compilation event. - compilationEvent.begin(); result = compiler.compile(method, entryBCI, useProfilingInfo, shouldRetainLocalVariables, compilationId, debug); } catch (Throwable e) { throw debug.handle(e); - } finally { - // End the compilation event. - compilationEvent.end(); } if (result != null) { @@ -322,9 +291,6 @@ boolean isOSR = entryBCI != JVMCICompiler.INVOCATION_ENTRY_BCI; HotSpotResolvedJavaMethod method = getMethod(); - // Log a compilation event. - EventProvider.CompilationEvent compilationEvent = eventProvider.newCompilationEvent(); - if (installAsDefault || isOSR) { // If there is already compiled code for this method on our level we simply return. // JVMCI compiles are always at the highest compile level, even in non-tiered mode so we @@ -337,7 +303,7 @@ } } - HotSpotCompilationWrapper compilation = new HotSpotCompilationWrapper(compilationEvent); + HotSpotCompilationWrapper compilation = new HotSpotCompilationWrapper(); try (DebugCloseable a = CompilationTime.start(debug)) { return compilation.run(debug); } finally { @@ -354,18 +320,6 @@ InstalledCodeSize.add(debug, codeSize); } } - - // Log a compilation event. - if (compilationEvent.shouldWrite()) { - compilationEvent.setMethod(method.format("%H.%n(%p)")); - compilationEvent.setCompileId(getId()); - compilationEvent.setCompileLevel(config.compilationLevelFullOptimization); - compilationEvent.setSucceeded(compilation.result != null && installedCode != null); - compilationEvent.setIsOsr(isOSR); - compilationEvent.setCodeSize(codeSize); - compilationEvent.setInlinedBytes(compiledBytecodes); - compilationEvent.commit(); - } } catch (Throwable t) { return compilation.handleException(t); }