Code Review for open

Prepared by:Krishna Addepalli on Fri Feb 23 19:27:25 IST 2018
Workspace:/cygdrive/d/Code_Base/jdklatest/client/open
Compare against: http://hg.openjdk.java.net/jdk/client
Compare against version:tip:tip~1
Summary of changes: 146 lines changed: 24 ins; 30 del; 92 mod; 22854 unchg
Patch of changes: open.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/macosx/classes/com/apple/laf/AquaFileChooserUI.java

rev 48858 : Work in progress for JDK-6303622
Use generic in Swing components like JComboBox
1. Added generic return type and parameter type for JComboBox.
2. Modified JList related classes as well.
3. Reverted the changes made to "getSelectedValues" as suggested by Joe.
4. Modified files that were failing on Linux and Mac as well.
9 lines changed: 0 ins; 0 del; 9 mod; 2383 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/macosx/classes/sun/lwawt/LWChoicePeer.java

rev 48858 : Work in progress for JDK-6303622
Use generic in Swing components like JComboBox
1. Added generic return type and parameter type for JComboBox.
2. Modified JList related classes as well.
3. Reverted the changes made to "getSelectedValues" as suggested by Joe.
4. Modified files that were failing on Linux and Mac as well.
2 lines changed: 0 ins; 0 del; 2 mod; 195 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/com/sun/java/swing/plaf/gtk/GTKFileChooserUI.java

rev 48858 : Work in progress for JDK-6303622
Use generic in Swing components like JComboBox
1. Added generic return type and parameter type for JComboBox.
2. Modified JList related classes as well.
3. Reverted the changes made to "getSelectedValues" as suggested by Joe.
4. Modified files that were failing on Linux and Mac as well.
7 lines changed: 0 ins; 0 del; 7 mod; 1418 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/com/sun/java/swing/plaf/motif/MotifFileChooserUI.java

rev 48858 : Work in progress for JDK-6303622
Use generic in Swing components like JComboBox
1. Added generic return type and parameter type for JComboBox.
2. Modified JList related classes as well.
3. Reverted the changes made to "getSelectedValues" as suggested by Joe.
4. Modified files that were failing on Linux and Mac as well.
3 lines changed: 0 ins; 0 del; 3 mod; 870 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/javax/swing/ComboBoxModel.java

rev 48858 : Work in progress for JDK-6303622
Use generic in Swing components like JComboBox
1. Added generic return type and parameter type for JComboBox.
2. Modified JList related classes as well.
3. Reverted the changes made to "getSelectedValues" as suggested by Joe.
4. Modified files that were failing on Linux and Mac as well.
4 lines changed: 2 ins; 0 del; 2 mod; 56 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/javax/swing/DefaultCellEditor.java

rev 48858 : Work in progress for JDK-6303622
Use generic in Swing components like JComboBox
1. Added generic return type and parameter type for JComboBox.
2. Modified JList related classes as well.
3. Reverted the changes made to "getSelectedValues" as suggested by Joe.
4. Modified files that were failing on Linux and Mac as well.
4 lines changed: 1 ins; 0 del; 3 mod; 397 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/javax/swing/DefaultComboBoxModel.java

rev 48858 : Work in progress for JDK-6303622
Use generic in Swing components like JComboBox
1. Added generic return type and parameter type for JComboBox.
2. Modified JList related classes as well.
3. Reverted the changes made to "getSelectedValues" as suggested by Joe.
4. Modified files that were failing on Linux and Mac as well.
9 lines changed: 3 ins; 0 del; 6 mod; 174 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/javax/swing/DefaultListModel.java

rev 48858 : Work in progress for JDK-6303622
Use generic in Swing components like JComboBox
1. Added generic return type and parameter type for JComboBox.
2. Modified JList related classes as well.
3. Reverted the changes made to "getSelectedValues" as suggested by Joe.
4. Modified files that were failing on Linux and Mac as well.
12 lines changed: 6 ins; 0 del; 6 mod; 543 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/javax/swing/JComboBox.java

rev 48858 : Work in progress for JDK-6303622
Use generic in Swing components like JComboBox
1. Added generic return type and parameter type for JComboBox.
2. Modified JList related classes as well.
3. Reverted the changes made to "getSelectedValues" as suggested by Joe.
4. Modified files that were failing on Linux and Mac as well.
30 lines changed: 9 ins; 3 del; 18 mod; 2418 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/javax/swing/JList.java

rev 48858 : Work in progress for JDK-6303622
Use generic in Swing components like JComboBox
1. Added generic return type and parameter type for JComboBox.
2. Modified JList related classes as well.
3. Reverted the changes made to "getSelectedValues" as suggested by Joe.
4. Modified files that were failing on Linux and Mac as well.
22 lines changed: 1 ins; 19 del; 2 mod; 3817 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/javax/swing/MutableComboBoxModel.java

rev 48858 : Work in progress for JDK-6303622
Use generic in Swing components like JComboBox
1. Added generic return type and parameter type for JComboBox.
2. Modified JList related classes as well.
3. Reverted the changes made to "getSelectedValues" as suggested by Joe.
4. Modified files that were failing on Linux and Mac as well.
1 line changed: 0 ins; 0 del; 1 mod; 73 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/javax/swing/text/html/FormView.java

rev 48858 : Work in progress for JDK-6303622
Use generic in Swing components like JComboBox
1. Added generic return type and parameter type for JComboBox.
2. Modified JList related classes as well.
3. Reverted the changes made to "getSelectedValues" as suggested by Joe.
4. Modified files that were failing on Linux and Mac as well.
8 lines changed: 0 ins; 3 del; 5 mod; 964 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/javax/swing/text/html/HTMLDocument.java

rev 48858 : Work in progress for JDK-6303622
Use generic in Swing components like JComboBox
1. Added generic return type and parameter type for JComboBox.
2. Modified JList related classes as well.
3. Reverted the changes made to "getSelectedValues" as suggested by Joe.
4. Modified files that were failing on Linux and Mac as well.
6 lines changed: 0 ins; 2 del; 4 mod; 4444 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/javax/swing/text/html/HTMLWriter.java

rev 48858 : Work in progress for JDK-6303622
Use generic in Swing components like JComboBox
1. Added generic return type and parameter type for JComboBox.
2. Modified JList related classes as well.
3. Reverted the changes made to "getSelectedValues" as suggested by Joe.
4. Modified files that were failing on Linux and Mac as well.
4 lines changed: 0 ins; 2 del; 2 mod; 1292 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/javax/swing/text/html/OptionComboBoxModel.java

rev 48858 : Work in progress for JDK-6303622
Use generic in Swing components like JComboBox
1. Added generic return type and parameter type for JComboBox.
2. Modified JList related classes as well.
3. Reverted the changes made to "getSelectedValues" as suggested by Joe.
4. Modified files that were failing on Linux and Mac as well.
1 line changed: 0 ins; 0 del; 1 mod; 61 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/javax/swing/text/html/OptionListModel.java

rev 48858 : Work in progress for JDK-6303622
Use generic in Swing components like JComboBox
1. Added generic return type and parameter type for JComboBox.
2. Modified JList related classes as well.
3. Reverted the changes made to "getSelectedValues" as suggested by Joe.
4. Modified files that were failing on Linux and Mac as well.
6 lines changed: 0 ins; 1 del; 5 mod; 564 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/sun/swing/plaf/synth/SynthFileChooserUIImpl.java

rev 48858 : Work in progress for JDK-6303622
Use generic in Swing components like JComboBox
1. Added generic return type and parameter type for JComboBox.
2. Modified JList related classes as well.
3. Reverted the changes made to "getSelectedValues" as suggested by Joe.
4. Modified files that were failing on Linux and Mac as well.
8 lines changed: 2 ins; 0 del; 6 mod; 1102 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/windows/classes/com/sun/java/swing/plaf/windows/WindowsFileChooserUI.java

rev 48858 : Work in progress for JDK-6303622
Use generic in Swing components like JComboBox
1. Added generic return type and parameter type for JComboBox.
2. Modified JList related classes as well.
3. Reverted the changes made to "getSelectedValues" as suggested by Joe.
4. Modified files that were failing on Linux and Mac as well.
7 lines changed: 0 ins; 0 del; 7 mod; 1318 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jconsole/share/classes/sun/tools/jconsole/MemoryTab.java

rev 48858 : Work in progress for JDK-6303622
Use generic in Swing components like JComboBox
1. Added generic return type and parameter type for JComboBox.
2. Modified JList related classes as well.
3. Reverted the changes made to "getSelectedValues" as suggested by Joe.
4. Modified files that were failing on Linux and Mac as well.
3 lines changed: 0 ins; 0 del; 3 mod; 765 unchg

This code review page was prepared using webrev.ksh (vers 25.16-hg+openjdk.java.net).